[gentoo-dev] Re: bzr.eclass

[Christian Faulhammer <fauli@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]

Hi,

René 'Necoro' Neumann <lists@necoro.eu>:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Jorge Manuel B. S. Vicetto schrieb:
> > Hi.
> > 
> > Christian Faulhammer wrote:
> >> Hi,
> >>
> >> a user maintained a Bazaar overlay for some time now and introduced
> >> some changes to bzr eclass, I would like to introduce into the
> >> tree. Please review the attached patch.
> >>
> >> V-Li
> > 
> > I'm attaching a revised patch that tries to improve some issues in
> > the current version in the tree, incorporates your changes and Peter
> > Volkov's (pva) patch about sftp URIs.
> > 
> > 
> 
> if [[ ${EBZR_REPO_URI} == */* ]]; then
> 	repository="${EBZR_REPO_URI}/${EBZR_BRANCH}"
> elif [[ -n ${EBZR_BRANCH} ]] ; then
> 	...
> else
> 	...
> fi
> 
> If I see this correctly, this appends EBZR_BRANCH if there is a slash
> in the REPO_URI ... what kind of guess is this supposed to be? I
> think, the second test (append iff EBZR_BRANCH is set) should be
> sufficient.

 Not sure, though I will investigate (and likely drop it).

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]