From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1LbgkV-00019l-4V for garchives@archives.gentoo.org; Mon, 23 Feb 2009 19:45:55 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id D1D66E051C; Mon, 23 Feb 2009 19:45:53 +0000 (UTC) Received: from mo-p05-ob.rzone.de (mo-p05-ob.rzone.de [81.169.146.181]) by pigeon.gentoo.org (Postfix) with ESMTP id 8E4C7E051C for ; Mon, 23 Feb 2009 19:45:53 +0000 (UTC) X-RZG-AUTH: :K2kKYU+nW/MMMlTokcN5Yot1/Bj/FTl+WviP6RIJci0HRMpbh/x+X6ShOQjVOj0+68XVNhUFMW8= X-RZG-CLASS-ID: mo05 Received: from terra.solaris (p54AE7F20.dip.t-dialin.net [84.174.127.32]) by post.strato.de (fruni mo5) (RZmta 18.21) with ESMTP id Y0690fl1NHXHXy for ; Mon, 23 Feb 2009 20:45:50 +0100 (MET) Date: Mon, 23 Feb 2009 20:45:28 +0100 From: Christian Faulhammer To: gentoo-dev@lists.gentoo.org Subject: [gentoo-dev] Re: bzr.eclass Message-ID: <20090223204528.636b5be9@terra.solaris> In-Reply-To: <499EA27D.5060608@necoro.eu> References: <20090214132152.2aff08a0@terra.solaris> <49970B3F.40809@gentoo.org> <499EA27D.5060608@necoro.eu> X-Mailer: Claws Mail 3.7.0 (GTK+ 2.12.11; i686-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/lrT1qEs4piGMqtnyi7b1m8="; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-Archives-Salt: 638c9d6c-5176-46ac-918e-62855c21a391 X-Archives-Hash: 0f158f5514038ec3e0a4ae5b2b32e39c --Sig_/lrT1qEs4piGMqtnyi7b1m8= Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi, Ren=E9 'Necoro' Neumann : > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 >=20 > Jorge Manuel B. S. Vicetto schrieb: > > Hi. > >=20 > > Christian Faulhammer wrote: > >> Hi, > >> > >> a user maintained a Bazaar overlay for some time now and introduced > >> some changes to bzr eclass, I would like to introduce into the > >> tree. Please review the attached patch. > >> > >> V-Li > >=20 > > I'm attaching a revised patch that tries to improve some issues in > > the current version in the tree, incorporates your changes and Peter > > Volkov's (pva) patch about sftp URIs. > >=20 > >=20 >=20 > if [[ ${EBZR_REPO_URI} =3D=3D */* ]]; then > repository=3D"${EBZR_REPO_URI}/${EBZR_BRANCH}" > elif [[ -n ${EBZR_BRANCH} ]] ; then > ... > else > ... > fi >=20 > If I see this correctly, this appends EBZR_BRANCH if there is a slash > in the REPO_URI ... what kind of guess is this supposed to be? I > think, the second test (append iff EBZR_BRANCH is set) should be > sufficient. Not sure, though I will investigate (and likely drop it). V-Li --=20 Christian Faulhammer, Gentoo Lisp project , #gentoo-lisp on FreeNode --Sig_/lrT1qEs4piGMqtnyi7b1m8= Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkmi/NgACgkQNQqtfCuFneNmqQCfS4c6iBr81qBtyfOm6z7+Yu5D Q5sAn1y+pvFi6NzT8bFii3LP/sLC2592 =mxGb -----END PGP SIGNATURE----- --Sig_/lrT1qEs4piGMqtnyi7b1m8=--