From: Ulrich Mueller <ulm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: [gentoo-dev] Re: bzr.eclass
Date: Thu, 19 Feb 2009 10:26:02 +0100 [thread overview]
Message-ID: <18845.9642.146547.895690@a1ihome1.kph.uni-mainz.de> (raw)
In-Reply-To: <20090219095927.65e82e61@terra.solaris>
>>>>> On Thu, 19 Feb 2009, Christian Faulhammer wrote:
>> > +# The bzr command to get the diff output.
>> > +EBZR_DIFF_CMD="bzr diff"
>>
>> > + ${EBZR_DIFF_CMD} | diffstat
>>
>> Why does this need to happen? Please add a comment.
> It produces Git-like output about how much has changed. I added a
> comment to the overlay.
So it is just informational output and the dependency on
dev-util/diffstat is not essential.
pva has suggested on IRC that diffstat should only be called if it is
present. I think this is a good idea.
-DEPEND=">=dev-util/bzr-1.5
- dev-util/diffstat"
+DEPEND=">=dev-util/bzr-1.5"
- ${EBZR_DIFF_CMD} | diffstat
+ [ -x /usr/bin/diffstat ] && ${EBZR_DIFF_CMD} | /usr/bin/diffstat
Ulrich
next prev parent reply other threads:[~2009-02-19 9:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 12:21 [gentoo-dev] bzr.eclass Christian Faulhammer
2009-02-14 15:37 ` Ulrich Mueller
2009-02-14 16:15 ` [gentoo-dev] bzr.eclass Christian Faulhammer
2009-02-14 18:19 ` [gentoo-dev] bzr.eclass Jorge Manuel B. S. Vicetto
2009-02-15 6:49 ` Donnie Berkholz
2009-02-19 8:59 ` [gentoo-dev] bzr.eclass Christian Faulhammer
2009-02-19 9:26 ` Ulrich Mueller [this message]
2009-02-19 9:42 ` Nirbheek Chauhan
2009-02-19 15:39 ` Petteri Räty
2009-02-19 15:39 ` Nirbheek Chauhan
2009-02-19 16:01 ` Petteri Räty
2009-02-19 23:11 ` Christian Faulhammer
2009-02-20 7:00 ` Ulrich Mueller
2009-02-23 19:40 ` Christian Faulhammer
2009-02-19 8:52 ` Christian Faulhammer
2009-02-20 12:30 ` [gentoo-dev] bzr.eclass René 'Necoro' Neumann
2009-02-23 19:45 ` [gentoo-dev] bzr.eclass Christian Faulhammer
2009-02-24 12:18 ` Brian Harring
2009-03-02 7:33 ` Christian Faulhammer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=18845.9642.146547.895690@a1ihome1.kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox