Re: [gentoo-dev] bzr.eclass

["René 'Necoro' Neumann" <lists@necoro.eu>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jorge Manuel B. S. Vicetto schrieb:
> Hi.
> 
> Christian Faulhammer wrote:
>> Hi,
>>
>> a user maintained a Bazaar overlay for some time now and introduced
>> some changes to bzr eclass, I would like to introduce into the tree.
>> Please review the attached patch.
>>
>> V-Li
> 
> I'm attaching a revised patch that tries to improve some issues in the
> current version in the tree, incorporates your changes and Peter
> Volkov's (pva) patch about sftp URIs.
> 
> 

if [[ ${EBZR_REPO_URI} == */* ]]; then
	repository="${EBZR_REPO_URI}/${EBZR_BRANCH}"
elif [[ -n ${EBZR_BRANCH} ]] ; then
	...
else
	...
fi

If I see this correctly, this appends EBZR_BRANCH if there is a slash in
the REPO_URI ... what kind of guess is this supposed to be? I think, the
second test (append iff EBZR_BRANCH is set) should be sufficient.

Regards,
Necoro
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkmeon0ACgkQ4UOg/zhYFuCf7gCfWSyBZrzct0jvUl9W+yml52+K
7ToAmwRry/H/3ZlH0bjNNg82f+gIIzBZ
=cqx5
-----END PGP SIGNATURE-----