[gentoo-dev] Re: bzr.eclass

[Christian Faulhammer <fauli@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

Hi,

Ulrich Mueller <ulm@gentoo.org>:

> >>>>> On Sat, 14 Feb 2009, Christian Faulhammer wrote:
> 
> > Please review the attached patch.
> 
> +		local repo_type=3D$(bzr info "${EBZR_BRANCH_DIR}" |
> head -n 1 | cut -d '= (' -f 1)
> +		if [[ "${repo_type}" !=3D "Lightweight checkout
> " ]]; then
> 
> This test looks very fragile to me. Could it be replaced by something
> else?

 The refetching of old full checkouts is not needed, just a neat
feature.  After looking at the repository structure a different test
could be the existence of .bzr/repository...lightweight checkouts don't
have it.

V-Li

-- 
Christian Faulhammer, Gentoo Lisp project
<URL:http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode

<URL:http://www.faulhammer.org/>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]