* [gentoo-dev] redundant code in toolchain.eclass?
@ 2011-10-26 14:20 "Paweł Hajdan, Jr."
2011-10-26 16:02 ` Ian Stakenvicius
2011-10-31 1:09 ` Mike Frysinger
0 siblings, 2 replies; 3+ messages in thread
From: "Paweł Hajdan, Jr." @ 2011-10-26 14:20 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
I was browsing toolchain.eclass and noticed this:
if [[ ${PN} != "kgcc64" && ${PN} != gcc-* ]] ; then
...
[[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
...
if tc_version_is_at_least 3 ; then
...
if tc_version_is_at_least "4.4" ; then
IUSE+=" graphite"
[[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
fi
...
fi
fi
The second IUSE+=" nossp" seems redundant and could be removed, right?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 203 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [gentoo-dev] redundant code in toolchain.eclass?
2011-10-26 14:20 [gentoo-dev] redundant code in toolchain.eclass? "Paweł Hajdan, Jr."
@ 2011-10-26 16:02 ` Ian Stakenvicius
2011-10-31 1:09 ` Mike Frysinger
1 sibling, 0 replies; 3+ messages in thread
From: Ian Stakenvicius @ 2011-10-26 16:02 UTC (permalink / raw
To: gentoo-dev
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 26/10/11 10:20 AM, "Paweł Hajdan, Jr." wrote:
> I was browsing toolchain.eclass and noticed this:
>
> if [[ ${PN} != "kgcc64" && ${PN} != gcc-* ]] ; then
> ...
> [[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
> ...
>
> if tc_version_is_at_least 3 ; then
> ...
> if tc_version_is_at_least "4.4" ; then
> IUSE+=" graphite"
> [[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
> fi
> ...
> fi
> fi
>
> The second IUSE+=" nossp" seems redundant and could be removed, right?
>
'nossp' is in IUSE twice within my copy of portage's metadata/cache file
for gcc, so it would seem there are at least some cases where it is
redundant.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
iF4EAREIAAYFAk6oLx0ACgkQAJxUfCtlWe2S9QD+K9nyvwsajNXvLRQnzFQJ+mVh
Gb16haS0Yy321JEusmsBANSBq6RrODFyGb9q5KIIxf5ZWfopWqAC/63Zwg5MRJU5
=jcLT
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [gentoo-dev] redundant code in toolchain.eclass?
2011-10-26 14:20 [gentoo-dev] redundant code in toolchain.eclass? "Paweł Hajdan, Jr."
2011-10-26 16:02 ` Ian Stakenvicius
@ 2011-10-31 1:09 ` Mike Frysinger
1 sibling, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2011-10-31 1:09 UTC (permalink / raw
To: gentoo-dev
[-- Attachment #1: Type: Text/Plain, Size: 251 bytes --]
On Wednesday 26 October 2011 10:20:54 Paweł Hajdan, Jr. wrote:
> The second IUSE+=" nossp" seems redundant and could be removed, right?
looks like a fix was committed:
http://sources.gentoo.org/eclass/toolchain.eclass?r1=1.473&r2=1.474
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-31 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-26 14:20 [gentoo-dev] redundant code in toolchain.eclass? "Paweł Hajdan, Jr."
2011-10-26 16:02 ` Ian Stakenvicius
2011-10-31 1:09 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox