From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([208.92.234.80] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1RJ5x5-0007PD-6F for garchives@archives.gentoo.org; Wed, 26 Oct 2011 16:03:39 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 8A22B21C065; Wed, 26 Oct 2011 16:03:30 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 8ECFE21C05F for ; Wed, 26 Oct 2011 16:02:56 +0000 (UTC) Received: from [192.168.1.131] (CPE002401f30b73-CM001cea3ddad8.cpe.net.cable.rogers.com [99.224.72.201]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: axs) by smtp.gentoo.org (Postfix) with ESMTPSA id B530A1B4014 for ; Wed, 26 Oct 2011 16:02:55 +0000 (UTC) Message-ID: <4EA82F1D.6010200@gentoo.org> Date: Wed, 26 Oct 2011 12:02:37 -0400 From: Ian Stakenvicius User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.20) Gecko/20110920 Lightning/1.0b3pre Mnenhy/0.8.2 Thunderbird/3.1.12 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] redundant code in toolchain.eclass? References: <4EA81746.4090701@gentoo.org> In-Reply-To: <4EA81746.4090701@gentoo.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: X-Archives-Hash: 06a3c95abef1a98cfa31b7dfdb3e972a -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 26/10/11 10:20 AM, "Pawe=C5=82 Hajdan, Jr." wrote: > I was browsing toolchain.eclass and noticed this: >=20 > if [[ ${PN} !=3D "kgcc64" && ${PN} !=3D gcc-* ]] ; then > ... > [[ -n ${SPECS_VER} ]] && IUSE+=3D" nossp" > ... >=20 > if tc_version_is_at_least 3 ; then > ... > if tc_version_is_at_least "4.4" ; then > IUSE+=3D" graphite" > [[ -n ${SPECS_VER} ]] && IUSE+=3D" nossp" > fi > ... > fi > fi >=20 > The second IUSE+=3D" nossp" seems redundant and could be removed, right= ? >=20 'nossp' is in IUSE twice within my copy of portage's metadata/cache file for gcc, so it would seem there are at least some cases where it is redundant. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iF4EAREIAAYFAk6oLx0ACgkQAJxUfCtlWe2S9QD+K9nyvwsajNXvLRQnzFQJ+mVh Gb16haS0Yy321JEusmsBANSBq6RrODFyGb9q5KIIxf5ZWfopWqAC/63Zwg5MRJU5 =3DjcLT -----END PGP SIGNATURE-----