public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ian Stakenvicius <axs@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] redundant code in toolchain.eclass?
Date: Wed, 26 Oct 2011 12:02:37 -0400	[thread overview]
Message-ID: <4EA82F1D.6010200@gentoo.org> (raw)
In-Reply-To: <4EA81746.4090701@gentoo.org>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 26/10/11 10:20 AM, "Paweł Hajdan, Jr." wrote:
> I was browsing toolchain.eclass and noticed this:
> 
> if [[ ${PN} != "kgcc64" && ${PN} != gcc-* ]] ; then
>     ...
>     [[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
>     ...
> 
>     if tc_version_is_at_least 3 ; then
>         ...
>         if tc_version_is_at_least "4.4" ; then
>             IUSE+=" graphite"
>             [[ -n ${SPECS_VER} ]] && IUSE+=" nossp"
>         fi
>         ...
>     fi
> fi
> 
> The second IUSE+=" nossp" seems redundant and could be removed, right?
> 

'nossp' is in IUSE twice within my copy of portage's metadata/cache file
for gcc, so it would seem there are at least some cases where it is
redundant.



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)

iF4EAREIAAYFAk6oLx0ACgkQAJxUfCtlWe2S9QD+K9nyvwsajNXvLRQnzFQJ+mVh
Gb16haS0Yy321JEusmsBANSBq6RrODFyGb9q5KIIxf5ZWfopWqAC/63Zwg5MRJU5
=jcLT
-----END PGP SIGNATURE-----



  reply	other threads:[~2011-10-26 16:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-26 14:20 [gentoo-dev] redundant code in toolchain.eclass? "Paweł Hajdan, Jr."
2011-10-26 16:02 ` Ian Stakenvicius [this message]
2011-10-31  1:09 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EA82F1D.6010200@gentoo.org \
    --to=axs@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox