From: Sergei Trofimovich <slyfox@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: use verbose cargo invocations
Date: Sat, 7 Dec 2019 08:59:06 +0000 [thread overview]
Message-ID: <20191207085906.6f5841c2@sf> (raw)
In-Reply-To: <4427138.OatnvYpNUp@ws>
On Fri, 06 Dec 2019 16:16:32 -0800
Georgy Yakovlev <gyakovlev@gentoo.org> wrote:
> On Friday, December 6, 2019 3:44:38 PM PST Sergei Trofimovich wrote:
> > On Fri, 6 Dec 2019 12:09:31 -0800
> >
> > Georgy Yakovlev <gyakovlev@gentoo.org> wrote:
> > > Default output just prints crate name.
> > > With -vv we can see all cargo options and rustc args.
> > >
> > > Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
> > > ---
> >
> > Looks good!
> >
> > I had to do an equivalent locally at least a few times.
> Pushed!
> >
> > While at it I also suggest adding equivalent of
> > econf's/emake's ${EXTRA_ECONF} and ${EXTRA_EMAKE}
> > to allow users to inject arbitrary stuff. For example
> > to sneak in '-Z' options globally.
> >
> > Say, ${CARGO_BUILD_EXTRA}, ${CARGO_INSTALL_EXTRA},
> > ${CARGO_TEST_EXTRA}.
> >
>
> Yeah, it's on my to-do list for this eclass.
> 1 question tho, should it come after "$@" or before? Do you use it?
> I know cargo can be picky about order and some ebuilds rely on passing params
> in phase funcs.
I don't use it frequently for carge.eclass but use it extensively for
./configure and haskell-cabal.eclass. I'd say variables are designed to
override everything else (eclass defaults and ebuild values) and thus
should come after "$@":
econf() { ... "$@" "${EXTRA_ECONF[@]}" }
${MAKE:-make} ${MAKEOPTS} "$@" ${EXTRA_EMAKE}
--
Sergei
next prev parent reply other threads:[~2019-12-07 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 20:09 [gentoo-dev] [PATCH] cargo.eclass: use verbose cargo invocations Georgy Yakovlev
2019-12-06 23:44 ` Sergei Trofimovich
2019-12-07 0:16 ` Georgy Yakovlev
2019-12-07 8:46 ` Haelwenn (lanodan) Monnier
2019-12-07 8:59 ` Sergei Trofimovich [this message]
2019-12-07 9:56 ` Kent Fredric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191207085906.6f5841c2@sf \
--to=slyfox@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox