From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 84A79138239 for ; Sat, 7 Dec 2019 08:59:15 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id AB11CE0869; Sat, 7 Dec 2019 08:59:11 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 2DE1AE082D for ; Sat, 7 Dec 2019 08:59:11 +0000 (UTC) Received: from sf (tunnel547699-pt.tunnel.tserv1.lon2.ipv6.he.net [IPv6:2001:470:1f1c:3e6::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: slyfox) by smtp.gentoo.org (Postfix) with ESMTPSA id E73AA34D835 for ; Sat, 7 Dec 2019 08:59:09 +0000 (UTC) Date: Sat, 7 Dec 2019 08:59:06 +0000 From: Sergei Trofimovich Cc: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] [PATCH] cargo.eclass: use verbose cargo invocations Message-ID: <20191207085906.6f5841c2@sf> In-Reply-To: <4427138.OatnvYpNUp@ws> References: <20191206200931.22347-1-gyakovlev@gentoo.org> <20191206234438.63218eb2@sf> <4427138.OatnvYpNUp@ws> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Archives-Salt: a9959e44-8975-40cb-96fb-7542fae85bd3 X-Archives-Hash: da5d899916d1331d0d3936db214b5ddf On Fri, 06 Dec 2019 16:16:32 -0800 Georgy Yakovlev wrote: > On Friday, December 6, 2019 3:44:38 PM PST Sergei Trofimovich wrote: > > On Fri, 6 Dec 2019 12:09:31 -0800 > > > > Georgy Yakovlev wrote: > > > Default output just prints crate name. > > > With -vv we can see all cargo options and rustc args. > > > > > > Signed-off-by: Georgy Yakovlev > > > --- > > > > Looks good! > > > > I had to do an equivalent locally at least a few times. > Pushed! > > > > While at it I also suggest adding equivalent of > > econf's/emake's ${EXTRA_ECONF} and ${EXTRA_EMAKE} > > to allow users to inject arbitrary stuff. For example > > to sneak in '-Z' options globally. > > > > Say, ${CARGO_BUILD_EXTRA}, ${CARGO_INSTALL_EXTRA}, > > ${CARGO_TEST_EXTRA}. > > > > Yeah, it's on my to-do list for this eclass. > 1 question tho, should it come after "$@" or before? Do you use it? > I know cargo can be picky about order and some ebuilds rely on passing params > in phase funcs. I don't use it frequently for carge.eclass but use it extensively for ./configure and haskell-cabal.eclass. I'd say variables are designed to override everything else (eclass defaults and ebuild values) and thus should come after "$@": econf() { ... "$@" "${EXTRA_ECONF[@]}" } ${MAKE:-make} ${MAKEOPTS} "$@" ${EXTRA_EMAKE} -- Sergei