Re: [gentoo-dev] [PATCH] cargo.eclass: use verbose cargo invocations

[Sergei Trofimovich <slyfox@gentoo.org>]

On Fri,  6 Dec 2019 12:09:31 -0800
Georgy Yakovlev <gyakovlev@gentoo.org> wrote:

> Default output just prints crate name.
> With -vv we can see all cargo options and rustc args.
> 
> Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
> ---

Looks good!

I had to do an equivalent locally at least a few times.

While at it I also suggest adding equivalent of
econf's/emake's ${EXTRA_ECONF} and ${EXTRA_EMAKE}
to allow users to inject arbitrary stuff. For example
to sneak in '-Z' options globally.

Say, ${CARGO_BUILD_EXTRA},  ${CARGO_INSTALL_EXTRA},
${CARGO_TEST_EXTRA}.

>  eclass/cargo.eclass | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/eclass/cargo.eclass b/eclass/cargo.eclass
> index 5b6d1f050f1..13dd5c355fb 100644
> --- a/eclass/cargo.eclass
> +++ b/eclass/cargo.eclass
> @@ -146,7 +146,7 @@ cargo_src_compile() {
>  
>  	export CARGO_HOME="${ECARGO_HOME}"
>  
> -	cargo build -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
> +	cargo build -vv -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
>  		|| die "cargo build failed"
>  }
>  
> @@ -156,7 +156,7 @@ cargo_src_compile() {
>  cargo_src_install() {
>  	debug-print-function ${FUNCNAME} "$@"
>  
> -	cargo install -j $(makeopts_jobs) --root="${ED}/usr" $(usex debug --debug "") "$@" \
> +	cargo install -vv -j $(makeopts_jobs) --root="${ED}/usr" $(usex debug --debug "") "$@" \
>  		|| die "cargo install failed"
>  	rm -f "${ED}/usr/.crates.toml"
>  
> @@ -169,7 +169,7 @@ cargo_src_install() {
>  cargo_src_test() {
>  	debug-print-function ${FUNCNAME} "$@"
>  
> -	cargo test -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
> +	cargo test -vv -j $(makeopts_jobs) $(usex debug "" --release) "$@" \
>  		|| die "cargo test failed"
>  }
>  
> -- 
> 2.23.0
> 
> 


-- 

  Sergei