From: Donnie Berkholz <dberkholz@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] Proposed change to base.eclass: EAPI-2 support
Date: Sun, 2 Nov 2008 20:51:42 -0800 [thread overview]
Message-ID: <20081103045142.GC3372@comet> (raw)
In-Reply-To: <20081103044957.GB3372@comet>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On 20:49 Sun 02 Nov , Donnie Berkholz wrote:
> On 00:08 Mon 03 Nov , Peter Alfredsen wrote:
> > +case "${EAPI}" in
> > + 2)
> > + EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile src_install
> > + ;;
> > + *)
> > + EXPORT_FUNCTIONS src_unpack src_compile src_install
> > + ;;
> > +esac
> > +
>
> This eclass needs to do the same thing as the other eclasses that got
> EAPI=2 patches and default EAPI to 0 when it's not defined, everywhere
> where it tests the value of EAPI.
Yeah, I realize it might technically work, but it's just asking for
breakage in my opinion. Better to be explicit and have the '*' case be
for something unexpected instead of an expected case.
--
Thanks,
Donnie
Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2008-11-03 4:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 22:08 [gentoo-dev] Proposed change to base.eclass: EAPI-2 support Peter Alfredsen
2008-11-02 22:23 ` Peter Alfredsen
2008-11-03 4:49 ` Donnie Berkholz
2008-11-03 4:51 ` Donnie Berkholz [this message]
2008-11-03 6:00 ` Peter Alfredsen
2008-11-03 8:29 ` [gentoo-dev] " Steve Long
2008-11-03 19:53 ` Peter Alfredsen
2008-11-05 18:26 ` Thomas Sachau
2008-11-05 18:45 ` Peter Alfredsen
2008-11-05 20:20 ` Thomas Sachau
2008-11-05 20:54 ` Ciaran McCreesh
2008-11-05 23:06 ` Thomas Anderson
2008-11-06 1:27 ` Thomas Rösner
2008-11-06 13:41 ` Duncan
2008-11-06 3:07 ` Javier Villavicencio
2008-11-09 15:47 ` [gentoo-dev] " Peter Alfredsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081103045142.GC3372@comet \
--to=dberkholz@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox