From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pigeon.gentoo.org ([69.77.167.62] helo=lists.gentoo.org) by finch.gentoo.org with esmtp (Exim 4.60) (envelope-from ) id 1KwrPk-0004Dq-8S for garchives@archives.gentoo.org; Mon, 03 Nov 2008 04:51:44 +0000 Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 5FC63E01AA; Mon, 3 Nov 2008 04:51:44 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by pigeon.gentoo.org (Postfix) with ESMTP id 3A397E01AA for ; Mon, 3 Nov 2008 04:51:44 +0000 (UTC) Received: from gentoo.org (c-71-193-142-160.hsd1.or.comcast.net [71.193.142.160]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.gentoo.org (Postfix) with ESMTP id 7015164696 for ; Mon, 3 Nov 2008 04:51:42 +0000 (UTC) Date: Sun, 2 Nov 2008 20:51:42 -0800 From: Donnie Berkholz To: gentoo-dev@lists.gentoo.org Subject: Re: [gentoo-dev] Proposed change to base.eclass: EAPI-2 support Message-ID: <20081103045142.GC3372@comet> References: <200811022308.49072.loki_val@gentoo.org> <20081103044957.GB3372@comet> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0vzXIDBeUiKkjNJl" Content-Disposition: inline In-Reply-To: <20081103044957.GB3372@comet> User-Agent: Mutt/1.5.18 (2008-05-17) X-Archives-Salt: 87bd0b37-882d-4d8a-9c45-be463c625cb7 X-Archives-Hash: 9399745c3ac10d28ca1b9c2f3e7f0ac9 --0vzXIDBeUiKkjNJl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20:49 Sun 02 Nov , Donnie Berkholz wrote: > On 00:08 Mon 03 Nov , Peter Alfredsen wrote: > > +case "${EAPI}" in > > + 2) > > + EXPORT_FUNCTIONS src_unpack src_prepare src_configure src_compile sr= c_install > > + ;; > > + *) > > + EXPORT_FUNCTIONS src_unpack src_compile src_install > > + ;; > > +esac > > + >=20 > This eclass needs to do the same thing as the other eclasses that got=20 > EAPI=3D2 patches and default EAPI to 0 when it's not defined, everywhere= =20 > where it tests the value of EAPI. Yeah, I realize it might technically work, but it's just asking for=20 breakage in my opinion. Better to be explicit and have the '*' case be=20 for something unexpected instead of an expected case. --=20 Thanks, Donnie Donnie Berkholz Developer, Gentoo Linux Blog: http://dberkholz.wordpress.com --0vzXIDBeUiKkjNJl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAkkOg14ACgkQXVaO67S1rtuT0gCfemO1fvnqRVedQshT72BLuhUO OgYAoOUERQ/NmATZO/xteeaNWfZves8X =csmK -----END PGP SIGNATURE----- --0vzXIDBeUiKkjNJl--