Re: [gentoo-dev] Re: Proposed change to base.eclass: EAPI-2 support

[Thomas Sachau <tommy@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

Peter Alfredsen schrieb:
> On Monday 03 November 2008, Steve Long wrote:
>> Peter Alfredsen wrote:
>>> debug-print-function $FUNCNAME $*
>> You should be using "$@" not unquoted $*.
> 
> Fixed. Also fixed base_src_unpack and base_src_compile calling their 
> grunt functions with $1, when clearly it should have been $@.
> 
>> Seems like the FUNCNAME bit should just be rolled into the function
>> with "${FUNCNAME[1]}" which could be done tree-wide quite easily.
> 
> I guess that function was written before bash-3 when FUNCNAME was turned 
> into an array.
> 
> 
> 

You should at least use emake instead of make in src_install. And i would suggest to use something
like this instead of the make install line (maybe add some other default docs, if they are common):

if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then
	emake DESTDIR="${D}" install || die "emake install failed"
fi
if [ -n "${DOCS}" ]; then
	dodoc ${DOCS} || die "dodoc failed"
else
	for x in AUTHORS ChangeLog NEWS README; do
		if [ -e ${x} ]; then
			dodoc ${x} || die "dodoc ${x} failed"
		fi
	done
fi

-- 
Thomas Sachau

Gentoo Linux Developer


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 315 bytes --]