[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-mathematics/mathomatic: ChangeLog mathomatic-12.7.9.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-mathematics/mathomatic: ChangeLog mathomatic-12.7.9.ebuild

[Donnie Berkholz]

On 02:37 Fri 02 Nov     , Marcus Hanwell (cryos) wrote:
> 1.1                  sci-mathematics/mathomatic/mathomatic-12.7.9.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-mathematics/mathomatic/mathomatic-12.7.9.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-mathematics/mathomatic/mathomatic-12.7.9.ebuild?rev=1.1&content-type=text/plain

> IUSE="doc icc"
> 
> DEPEND="sys-libs/readline
> 	sys-libs/ncurses
> 	icc? ( dev-lang/icc )"
> 
> src_compile() {
> 	if use icc; then
> 		CC="icc" CFLAGS="-O3 -axKWNBP -ipo" LDFLAGS="-O3 -axKWNBP -ipo -limf" emake READLINE=1 || die "emake failed"
> 	else
> 		emake READLINE=1 || die "emake failed"
> 	fi

Could you drop the icc USE flag? All you need to do is make sure this 
package respects CC, CFLAGS and LDFLAGS, and users can take care of the 
rest in make.conf.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-mathematics/mathomatic: ChangeLog mathomatic-12.7.9.ebuild

[Marcus D. Hanwell]

On Friday 02 November 2007 02:59:36 Donnie Berkholz wrote:
> Could you drop the icc USE flag? All you need to do is make sure this
> package respects CC, CFLAGS and LDFLAGS, and users can take care of the
> rest in make.conf.
>
I never put it in and just left it alone as I don't use ICC. I have dropped it 
in the testing version but would rather leave the stable version alone. So if 
nobody objects it will go from the tree once I stabilise this version.

Is this policy that we are getting rid of icc stuff now? I think kugelfang 
added it but didn't check to be honest. Just so I know when doing future 
bumps.

Thanks,

Marcus

-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-mathematics/mathomatic: ChangeLog mathomatic-12.7.9.ebuild

[Donnie Berkholz]

On 11:17 Mon 05 Nov     , Marcus D. Hanwell wrote:
> On Friday 02 November 2007 02:59:36 Donnie Berkholz wrote:
> > Could you drop the icc USE flag? All you need to do is make sure this
> > package respects CC, CFLAGS and LDFLAGS, and users can take care of the
> > rest in make.conf.
> >
> I never put it in and just left it alone as I don't use ICC. I have dropped it 
> in the testing version but would rather leave the stable version alone. So if 
> nobody objects it will go from the tree once I stabilise this version.
> 
> Is this policy that we are getting rid of icc stuff now? I think kugelfang 
> added it but didn't check to be honest. Just so I know when doing future 
> bumps.

icc should be treated as a compiler, not as a USE flag. So if all you 
need to do is set up CC, CFLAGS, CXX and the like, just make sure the 
package respects the environment. If there's something else you need to 
do, such as set up a special config file for icc, you can do it based on 
tc-getCC() or tc-getCXX() rather than USE=icc.

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list