From: Pacho Ramos <pacho@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] About validate_desktop_entries in eutils.eclass
Date: Mon, 30 Apr 2012 19:50:40 +0200 [thread overview]
Message-ID: <1335808240.443.4.camel@belkin4> (raw)
In-Reply-To: <4F9EC673.4090806@gentoo.org>
[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]
El lun, 30-04-2012 a las 10:05 -0700, Zac Medico escribió:
> On 04/29/2012 09:45 AM, Petteri Räty wrote:
> > On 15.04.2012 17:12, Pacho Ramos wrote:
> >> El dom, 15-04-2012 a las 16:02 +0200, Michał Górny escribió:
> >>> On Sun, 15 Apr 2012 11:59:50 +0200
> >>> Pacho Ramos <pacho@gentoo.org> wrote:
> >>>
> >>>> I am unsure about validate_desktop_entries() utility. It's currently
> >>>> provided by eutils.eclass and only called by net-firewall/fwbuilder.
> >>>> Shouldn't this be moved to a "qa" check? Current way is pretty useless
> >>>> as it's not used by most of packages, and calling it from a lot of
> >>>> eclasses/ebuilds doesn't sound me like a good idea.
> >>>>
> >>>> What do you think?
> >>>
> >>> Agreed. It should be in repoman.
> >>>
> >>
> >> The check needs to be run over desktop file going to be installed, not
> >> sure how repoman can handle it, it looked to me more like a emerge job
> >> (like is done with other qa checks run before installation)
> >
> > There's actually already code in repoman that runs
> > desktop-file-validate. It of course only works for installed packages.
> > Someone could make it run runtime too.
>
> The repoman code works on $FILESDIR. It looks like we also want to run
> it after src_install.
>
> Also, it looks like we might need to handle a special case for Konqueror
> Service Menus:
>
> https://bugs.gentoo.org/show_bug.cgi?id=414125
Yes, I would like to also check other desktop files than those coming
from FILESDIR
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2012-04-30 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 9:59 [gentoo-dev] About validate_desktop_entries in eutils.eclass Pacho Ramos
2012-04-15 10:20 ` Samuli Suominen
2012-04-15 14:02 ` Michał Górny
2012-04-15 14:12 ` Pacho Ramos
2012-04-15 14:23 ` Michał Górny
2012-04-29 16:45 ` Petteri Räty
2012-04-30 17:05 ` Zac Medico
2012-04-30 17:50 ` Pacho Ramos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335808240.443.4.camel@belkin4 \
--to=pacho@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox