public inbox for gentoo-portage-dev@lists.gentoo.org
 help / color / mirror / Atom feed
* [gentoo-portage-dev] [PATCH 2/2] runtests: fix output for skipped pythons
@ 2016-03-19 21:29 Sergei Trofimovich
  2016-03-20 13:53 ` Alexander Berntsen
  2016-03-29 10:12 ` Alexander Berntsen
  0 siblings, 2 replies; 4+ messages in thread
From: Sergei Trofimovich @ 2016-03-19 21:29 UTC (permalink / raw
  To: gentoo-portage-dev; +Cc: Sergei Trofimovich

From: Sergei Trofimovich <siarheit@google.com>

I have Pythons 2.7 and 3.4 installed.

Before the patch I had the following output:

    $ ./runtests pym/portage/tests/resolver/test_blocker.py
    Testing with Python 2.7...
    Testing with Python 3.4...

    Summary:
    | Version    | Status
    |--------------------
    | 2.7        | PASS
    | 3.3        | PASS

After the patch:

    $ ./runtests pym/portage/tests/resolver/test_blocker.py

    Testing with Python 2.7...
    Skip Python 3.3...
    Testing with Python 3.4...
    Skip Python pypy...
    Skip Python 3.5...

    Summary:
    | Version    | Status
    |--------------------
    | 2.7        | PASS
    | 3.4        | PASS

Signed-off-by: Sergei Trofimovich <siarheit@google.com>
---
 runtests | 16 +++++++++++-----
 1 file changed, 11 insertions(+), 5 deletions(-)

diff --git a/runtests b/runtests
index d492bc8..9135768 100755
--- a/runtests
+++ b/runtests
@@ -42,7 +42,7 @@ class Colors(object):
 	_COLORS_YES = ('y', 'yes', 'true')
 	_COLORS_NO = ('n', 'no', 'false')
 
-	GOOD = BAD = NORMAL = ''
+	WARN = GOOD = BAD = NORMAL = ''
 
 	def __init__(self, colorize=None):
 		if colorize is None:
@@ -63,6 +63,7 @@ class Colors(object):
 				raise ValueError('--colors is invalid: %s' % colorize)
 
 		if colorize:
+			self.WARN = '\033[1;33m'
 			self.GOOD = '\033[1;32m'
 			self.BAD = '\033[1;31m'
 			self.NORMAL = '\033[0m'
@@ -135,11 +136,14 @@ def main(argv):
 			if os.access(prog, os.X_OK):
 				print('%sTesting with Python %s...%s' %
 					(colors.GOOD, ver, colors.NORMAL))
-				statuses.append(subprocess.call(cmd))
+				statuses.append((ver, subprocess.call(cmd)))
 			elif not ignore_missing:
 				print('%sCould not find requested Python %s%s' %
 					(colors.BAD, ver, colors.NORMAL))
-				statuses.append(1)
+				statuses.append((ver, 1))
+			else:
+				print('%sSkip Python %s...%s' %
+					(colors.WARN, ver, colors.NORMAL))
 			print()
 	finally:
 		if tempdir is not None:
@@ -154,7 +158,9 @@ def main(argv):
 	width = 10
 	header = '| %-*s | %s' % (width, 'Version', 'Status')
 	print('%s\n|%s' % (header, '-' * (len(header) - 1)))
-	for ver, status in zip(pyversions, statuses):
+	exit_status = 0
+	for ver, status in statuses:
+		exit_status += status
 		if status:
 			color = colors.BAD
 			msg = 'FAIL'
@@ -163,7 +169,7 @@ def main(argv):
 			msg = 'PASS'
 		print('| %s%-*s%s | %s%s%s' %
 			(color, width, ver, colors.NORMAL, color, msg, colors.NORMAL))
-	exit(sum(statuses))
+	exit(exit_status)
 
 
 if __name__ == '__main__':
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-29 10:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-19 21:29 [gentoo-portage-dev] [PATCH 2/2] runtests: fix output for skipped pythons Sergei Trofimovich
2016-03-20 13:53 ` Alexander Berntsen
2016-03-24 22:33   ` Sergei Trofimovich
2016-03-29 10:12 ` Alexander Berntsen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox