From: Andreas Sturmlechner <asturm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: Enable BUILD_SHARED_LIBS by default in EAPI >= 7
Date: Thu, 13 Sep 2018 11:55:54 +0200 [thread overview]
Message-ID: <2549345.rO708uWdeg@tux200s> (raw)
In-Reply-To: <20180726063501.18702-2-soap@gentoo.org>
---Original Message---
On Thursday, 26 July 2018 at 08:35, soap@gentoo.org wrote:
> From: David Seifert <soap@gentoo.org>
>
> * Many upstreams build static libraries by default, as this is
> simpler for distribution. Developers can still override this
> variable if required.
>
> Examples:
> https://github.com/pezmaster31/bamtools/blob/master/CMakeLists.txt#L64
> ---
> eclass/cmake-utils.eclass | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
> index ed81426ddcc..f180c8c3d7d 100644
> --- a/eclass/cmake-utils.eclass
> +++ b/eclass/cmake-utils.eclass
> @@ -623,6 +623,7 @@ cmake-utils_src_configure() {
> if [[ ${EAPI} != [56] ]]; then
> cat >> "${common_config}" <<- _EOF_ || die
> SET (CMAKE_INSTALL_DOCDIR "${EPREFIX}/usr/share/doc/${PF}" CACHE PATH "")
> + SET (BUILD_SHARED_LIBS ON CACHE BOOLEAN "")
> _EOF_
> fi
>
> --
> 2.18.0
works for me.
next prev parent reply other threads:[~2018-09-13 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-26 6:35 [gentoo-dev] [PATCH 1/2] cmake-utils.eclass: Make ninja default backend in EAPI >= 7 soap
2018-07-26 6:35 ` [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: Enable BUILD_SHARED_LIBS by default " soap
2018-09-13 9:55 ` Andreas Sturmlechner [this message]
2018-07-26 7:21 ` [gentoo-dev] [PATCH 1/2] cmake-utils.eclass: Make ninja default backend " Michał Górny
2018-09-13 9:55 ` Andreas Sturmlechner
2018-09-13 14:25 ` Mike Gilbert
2018-09-13 18:55 ` Andreas Sturmlechner
2018-09-13 19:01 ` Michał Górny
2018-09-14 6:59 ` Francesco Riosa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2549345.rO708uWdeg@tux200s \
--to=asturm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox