From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gentoo-dev+bounces-85914-garchives=archives.gentoo.org@lists.gentoo.org>
Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by finch.gentoo.org (Postfix) with ESMTPS id 6AD9A138334
	for <garchives@archives.gentoo.org>; Thu, 13 Sep 2018 09:56:05 +0000 (UTC)
Received: from pigeon.gentoo.org (localhost [127.0.0.1])
	by pigeon.gentoo.org (Postfix) with SMTP id 333ADE0C4D;
	Thu, 13 Sep 2018 09:56:02 +0000 (UTC)
Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by pigeon.gentoo.org (Postfix) with ESMTPS id D5672E0BE1
	for <gentoo-dev@lists.gentoo.org>; Thu, 13 Sep 2018 09:56:01 +0000 (UTC)
Received: from tux200s.localnet (unknown [80.122.182.58])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	(Authenticated sender: asturm)
	by smtp.gentoo.org (Postfix) with ESMTPSA id E2665335D05
	for <gentoo-dev@lists.gentoo.org>; Thu, 13 Sep 2018 09:55:57 +0000 (UTC)
From: Andreas Sturmlechner <asturm@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/2] cmake-utils.eclass: Enable BUILD_SHARED_LIBS by default in EAPI >= 7
Date: Thu, 13 Sep 2018 11:55:54 +0200
Message-ID: <2549345.rO708uWdeg@tux200s>
Organization: Gentoo
In-Reply-To: <20180726063501.18702-2-soap@gentoo.org>
References: <20180726063501.18702-1-soap@gentoo.org> <20180726063501.18702-2-soap@gentoo.org>
Precedence: bulk
List-Post: <mailto:gentoo-dev@lists.gentoo.org>
List-Help: <mailto:gentoo-dev+help@lists.gentoo.org>
List-Unsubscribe: <mailto:gentoo-dev+unsubscribe@lists.gentoo.org>
List-Subscribe: <mailto:gentoo-dev+subscribe@lists.gentoo.org>
List-Id: Gentoo Linux mail <gentoo-dev.gentoo.org>
X-BeenThere: gentoo-dev@lists.gentoo.org
Reply-to: gentoo-dev@lists.gentoo.org
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Archives-Salt: 17892d87-db7e-42d5-857f-b42cdecfaa02
X-Archives-Hash: 5182ab089058c7f33709ddc5ee64790d

---Original Message---
On Thursday, 26 July 2018 at 08:35, soap@gentoo.org wrote:

> From: David Seifert <soap@gentoo.org>
> 
> * Many upstreams build static libraries by default, as this is
>   simpler for distribution. Developers can still override this
>   variable if required.
> 
>   Examples:
>   https://github.com/pezmaster31/bamtools/blob/master/CMakeLists.txt#L64
> ---
>  eclass/cmake-utils.eclass | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/eclass/cmake-utils.eclass b/eclass/cmake-utils.eclass
> index ed81426ddcc..f180c8c3d7d 100644
> --- a/eclass/cmake-utils.eclass
> +++ b/eclass/cmake-utils.eclass
> @@ -623,6 +623,7 @@ cmake-utils_src_configure() {
>  	if [[ ${EAPI} != [56] ]]; then
>  		cat >> "${common_config}" <<- _EOF_ || die
>  			SET (CMAKE_INSTALL_DOCDIR "${EPREFIX}/usr/share/doc/${PF}" CACHE PATH "")
> +			SET (BUILD_SHARED_LIBS ON CACHE BOOLEAN "")
>  		_EOF_
>  	fi
>  
> -- 
> 2.18.0

works for me.