From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: ulm@gentoo.org
Subject: Re: [gentoo-dev] [PATCH 1/2] Introduce multibuild_merge_root() to merge interim installs.
Date: Sun, 24 Mar 2013 11:09:31 +0100 [thread overview]
Message-ID: <20130324110931.3ef46f45@pomiocik.lan> (raw)
In-Reply-To: <20814.44957.706923.881677@a1i15.kph.uni-mainz.de>
[-- Attachment #1: Type: text/plain, Size: 914 bytes --]
On Sun, 24 Mar 2013 08:47:41 +0100
Ulrich Mueller <ulm@gentoo.org> wrote:
> >>>>> On Sat, 23 Mar 2013, Michał Górny wrote:
>
> >> > +multibuild_merge_root() {
> >> > + [...]
> >> > + if type -P lockf &>/dev/null; then
> >> > + # On BSD, we have 'lockf' wrapper.
> >> > + tar -C "${src}" -f - -c . \
> >> > + | lockf "${lockfile}" tar -x -f - -C "${dest}"
> >> > + else
> >> > + [...]
> >> > + cp -a -l -n "${src}"/. "${dest}"/
> >>
> >> You assume that cp is GNU, if there's no lockf. Is it guaranteed that
> >> this is true on all platforms?
>
> > They're all just assumptions. If it breaks somewhere, I'll improve
> > the function.
>
> Maybe explicitly testing for USERLAND would be less fragile? Or use
> tar everywhere?
I prefer something that can boom into face and let us know that it is
broken rather than silent, poor catch-all.
--
Best regards,
Michał Górny
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 966 bytes --]
next prev parent reply other threads:[~2013-03-24 10:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-23 16:25 [gentoo-dev] [PATCHES] Header wrapping support for multilib Michał Górny
2013-03-23 16:26 ` [gentoo-dev] [PATCH 1/2] Introduce multibuild_merge_root() to merge interim installs Michał Górny
2013-03-23 17:00 ` Ulrich Mueller
2013-03-23 17:28 ` Michał Górny
2013-03-24 7:47 ` Ulrich Mueller
2013-03-24 10:09 ` Michał Górny [this message]
2013-03-24 13:40 ` Ulrich Mueller
2013-03-24 14:13 ` Michał Górny
2013-03-24 20:18 ` Zac Medico
2013-03-25 22:42 ` [gentoo-dev] [PATCH] " Michał Górny
2013-03-23 17:44 ` [gentoo-dev] [PATCH 1/2] " Alec Warner
2013-03-23 18:57 ` Michał Górny
2013-03-23 18:57 ` [gentoo-dev] " Jonathan Callen
2013-03-23 19:02 ` Alec Warner
2013-03-23 16:26 ` [gentoo-dev] [PATCH 2/2] Support wrapping headers for multilib ABIs Michał Górny
2013-03-24 15:14 ` Alexis Ballier
2013-03-24 15:41 ` Michał Górny
2013-03-24 20:01 ` Alexis Ballier
2013-03-25 22:22 ` [gentoo-dev] [PATCH] " Michał Górny
2013-03-23 16:46 ` [gentoo-dev] [PATCHES] Header wrapping support for multilib Diego Elio Pettenò
2013-03-23 17:32 ` Michał Górny
2013-03-23 17:32 ` Diego Elio Pettenò
2013-03-23 19:56 ` [gentoo-dev] [PATCH] Support wrapping headers for multilib ABIs Michał Górny
2013-03-23 20:03 ` Michał Górny
2013-03-23 22:01 ` [gentoo-dev] " Jonathan Callen
2013-04-01 9:19 ` [gentoo-dev] [PATCHES] Header wrapping support for multilib Michał Górny
2013-04-02 10:59 ` Alexis Ballier
2013-04-02 11:47 ` Michał Górny
2013-04-04 8:07 ` Alexis Ballier
2013-04-04 17:53 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130324110931.3ef46f45@pomiocik.lan \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox