From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id BDD14138010 for ; Sun, 24 Mar 2013 10:08:53 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 4074FE07B6; Sun, 24 Mar 2013 10:08:51 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 5D8F8E07B2 for ; Sun, 24 Mar 2013 10:08:50 +0000 (UTC) Received: from pomiocik.lan (unknown [83.238.59.230]) (using SSLv3 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: mgorny) by smtp.gentoo.org (Postfix) with ESMTPSA id 406C233BF48; Sun, 24 Mar 2013 10:08:48 +0000 (UTC) Date: Sun, 24 Mar 2013 11:09:31 +0100 From: =?UTF-8?B?TWljaGHFgiBHw7Nybnk=?= To: gentoo-dev@lists.gentoo.org Cc: ulm@gentoo.org Subject: Re: [gentoo-dev] [PATCH 1/2] Introduce multibuild_merge_root() to merge interim installs. Message-ID: <20130324110931.3ef46f45@pomiocik.lan> In-Reply-To: <20814.44957.706923.881677@a1i15.kph.uni-mainz.de> References: <20130323172532.1b1100e2@pomiocik.lan> <1364055998-23674-1-git-send-email-mgorny@gentoo.org> <20813.57273.945749.854552@a1i15.kph.uni-mainz.de> <20130323182858.1846ba8d@pomiocik.lan> <20814.44957.706923.881677@a1i15.kph.uni-mainz.de> Organization: Gentoo X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.17; x86_64-pc-linux-gnu) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-dev@lists.gentoo.org Reply-to: gentoo-dev@lists.gentoo.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA512; boundary="Sig_/Ys70wYnpiSsjaDSdkTvC/Gj"; protocol="application/pgp-signature" X-Archives-Salt: a476c8e7-f964-4166-91fd-d563f1aa767c X-Archives-Hash: 8bcb4ebe21e79da0f9315ed750d92c3b --Sig_/Ys70wYnpiSsjaDSdkTvC/Gj Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Sun, 24 Mar 2013 08:47:41 +0100 Ulrich Mueller wrote: > >>>>> On Sat, 23 Mar 2013, Micha=C5=82 G=C3=B3rny wrote: >=20 > >> > +multibuild_merge_root() { > >> > + [...] > >> > + if type -P lockf &>/dev/null; then > >> > + # On BSD, we have 'lockf' wrapper. > >> > + tar -C "${src}" -f - -c . \ > >> > + | lockf "${lockfile}" tar -x -f - -C "${dest}" > >> > + else > >> > + [...] > >> > + cp -a -l -n "${src}"/. "${dest}"/ > >>=20 > >> You assume that cp is GNU, if there's no lockf. Is it guaranteed that > >> this is true on all platforms? >=20 > > They're all just assumptions. If it breaks somewhere, I'll improve > > the function. >=20 > Maybe explicitly testing for USERLAND would be less fragile? Or use > tar everywhere? I prefer something that can boom into face and let us know that it is broken rather than silent, poor catch-all. --=20 Best regards, Micha=C5=82 G=C3=B3rny --Sig_/Ys70wYnpiSsjaDSdkTvC/Gj Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQJ8BAEBCgBmBQJRTtDgXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ1RUJGMjBGOTk2RkIzQzIyQ0M2RkNBNDBC QUJGMUQ1RkY4QzgxMTBBAAoJELq/HV/4yBEKIvIP/0ddYsFBWCCMXgNYHufq+daQ hd8u4lqWdwO1B5n3AVK01xCdAdqtUJSSvODPdc0X7uf9Ou84TRvknNlgVByBBLnj 7m1HBnGnH7yVlVpXCPN11J9Ato8hvA/Fkq6Nzz6WVGZPORwHVW2/gVqZwgI6YDQZ XpyQHOMsoOf8nnuR1p8mSHBw4rloohWJzvpbzubyjuwltcucIsHwJ/65rjsoscUU olqg6rDIMhZ3dZmkLxEA3Mf9jDz2FZmCBDSZ674CahRw/HrZJOqL9aQjMQSzMr5x Z6RUCFaTd7XtzOYgiNNnUVN5ba1raQNGXQFnfu4Qnvy1BTEdeKO+Rs8QN5wd59nR 8vL7h+gNY4LTlbhVQa4kbLE/wMjjr7XR3acg/3TMrJ5CeNAeiqFlIfcT6+vN22Dk McgviRDaxDE1VYc1ibk67dFAol5kSEnOFzRBR+TPkWRvwj7DuqgC/zvg2HfYmT/N riIO1W+sxWwiJEfbppjPLhLjMd9Pjmpb8VFQM5OtIVk9+RQ1r9HHhFFLK34GaZ4J IMX2LFCcacPDL4rdHVPweUOBrJm5B5gxBIjFXOU8OsDJdfmDbUPt4jm/opVFd0hW RNif7h6Hw9Ig9z5gGgnCpg4iA0hRiNYlAACCwS7nRK7BKfYyhZZynPweIXvtFncj zUyqMWzm7FuEengFiO0D =fm2c -----END PGP SIGNATURE----- --Sig_/Ys70wYnpiSsjaDSdkTvC/Gj--