[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-wm/sawfish: ChangeLog sawfish-1.3.2.ebuild sawfish-1.3_p20050816-r1.ebuild sawfish-1.3_p20060816.ebuild sawfish-1.3.20040120.ebuild sawfish-1.3.20060816.ebuild sawfish-1.3.20050816.ebuild sawfish-1.3.20050816-r1.ebuild sawfish-1.3.20040120-r1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-wm/sawfish: ChangeLog sawfish-1.3.2.ebuild sawfish-1.3_p20050816-r1.ebuild sawfish-1.3_p20060816.ebuild sawfish-1.3.20040120.ebuild sawfish-1.3.20060816.ebuild sawfish-1.3.20050816.ebuild sawfish-1.3.20050816-r1.ebuild sawfish-1.3.20040120-r1.ebuild

[Donnie Berkholz]

On 20:58 Tue 22 Jan     , Harald van Dijk (truedfx) wrote:
> 1.1                  x11-wm/sawfish/sawfish-1.3.2.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-wm/sawfish/sawfish-1.3.2.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/x11-wm/sawfish/sawfish-1.3.2.ebuild?rev=1.1&content-type=text/plain

This ebuild has some interesting code that's worth taking a look at, 
both the snapshot stuff and how econf arguments are set up.

Thanks,
Donnie

> Index: sawfish-1.3.2.ebuild
> ===================================================================
> # Copyright 1999-2008 Gentoo Foundation
> # Distributed under the terms of the GNU General Public License v2
> # $Header: /var/cvsroot/gentoo-x86/x11-wm/sawfish/sawfish-1.3.2.ebuild,v 1.1 2008/01/22 20:58:35 truedfx Exp $
> 
> # detect cvs snapshots; fex. 1.3_p20040120
> [[ $PV == *_p[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9] ]]
> (( snapshot = !$? ))
> 
> if (( snapshot )); then
> 	WANT_AUTOCONF=latest
> 	WANT_AUTOMAKE=latest
> 	inherit eutils autotools
> else
> 	inherit eutils
> fi
> 
> DESCRIPTION="Extensible window manager using a Lisp-based scripting language"
> HOMEPAGE="http://sawmill.sourceforge.net/"
> if (( snapshot )); then
> 	SRC_URI="mirror://gentoo/${P}.tar.bz2"
> else
> 	SRC_URI="mirror://sourceforge/sawmill/${P}.tar.gz"
> fi
> 
> LICENSE="GPL-2"
> SLOT="0"
> # Will remain masked until a report of a segfault on the mailing list
> # is resolved
> KEYWORDS="" # ~alpha ~amd64 ~ia64 ~ppc ~ppc64 ~sparc ~x86
> IUSE="gnome esd nls audiofile pango"
> 
> DEPEND=">=dev-util/pkgconfig-0.12.0
> 	>=x11-libs/rep-gtk-0.17
> 	>=dev-libs/librep-0.16
> 	>=x11-libs/gtk+-2.0.8
> 	audiofile? ( >=media-libs/audiofile-0.2.3 )
> 	esd? ( >=media-sound/esound-0.2.23 )
> 	nls? ( sys-devel/gettext )"
> RDEPEND="${DEPEND}"
> 
> if (( snapshot )); then
> 	S="${WORKDIR}/${PN}"
> fi
> 
> src_unpack() {
> 	unpack ${A}
> 	cd "${S}"
> 	epatch "${FILESDIR}"/libtool.patch
> 	epatch "${FILESDIR}"/${PN}-wm_name.patch
> 
> 	if (( snapshot )); then
> 		eaclocal || die
> 		eautoconf || die
> 	fi
> }
> 
> src_compile() {
> 	# Make sure we include freetype2 headers before freetype1 headers,
> 	# else Xft2 borks, <azarah@gentoo.org> (13 Dec 2002)
> 	export C_INCLUDE_PATH="${C_INCLUDE_PATH}:/usr/include/freetype2"
> 	export CPLUS_INCLUDE_PATH="${CPLUS_INCLUDE_PATH}:/usr/include/freetype2"
> 
> 	set -- \
> 		--disable-themer \
> 		--with-gdk-pixbuf \
> 		$(use_with audiofile) \
> 		$(use_with esd) \
> 		$(use_with pango)
> 
> 	if use gnome; then
> 		set -- "$@" \
> 			--with-gnome-prefix=/usr \
> 			--enable-gnome-widgets \
> 			--enable-capplet
> 	else
> 		set -- "$@" \
> 			--disable-gnome-widgets \
> 			--disable-capplet
> 	fi
> 
> 	if ! use nls; then
> 		# Use a space because configure script reads --enable-linguas="" as
> 		# "install everything"
> 		# Don't use --disable-linguas, because that means --enable-linguas="no",
> 		# which means "install Norwegian translations"
> 		set -- "$@" --enable-linguas=" "
> 	elif [[ "${LINGUAS+set}" == "set" ]]; then
> 		strip-linguas -i po
> 		set -- "$@" --enable-linguas=" ${LINGUAS} "
> 	else
> 		set -- "$@" --enable-linguas=""
> 	fi
> 
> 	econf "$@" || die "configure failed"
> 
> 	# The following two lines allow sawfish to compile with gcc 2.95
> 	# (see bug 18294)
> 	sed -i -e 's:REP_CFLAGS=:REP_CFLAGS=-I/usr/include/freetype2 :' Makedefs
> 
> 	# Parallel build didn't work, but appears to work now. This needs
> 	# extra checking before this version is unmasked.
> 	emake || die "make failed"
> }
-- 
gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-wm/sawfish: ChangeLog sawfish-1.3.2.ebuild sawfish-1.3_p20050816-r1.ebuild sawfish-1.3_p20060816.ebuild sawfish-1.3.20040120.ebuild sawfish-1.3.20060816.ebuild sawfish-1.3.20050816.ebuild sawfish-1.3.20050816-r1.ebuild sawfish-1.3.20040120-r1.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 423 bytes --]

On Tuesday 22 January 2008, Donnie Berkholz wrote:
> On 20:58 Tue 22 Jan     , Harald van Dijk (truedfx) wrote:
> > 	WANT_AUTOCONF=latest
> > 	WANT_AUTOMAKE=latest

redundant, please drop

> > 		eaclocal || die
> > 		eautoconf || die

these things call die themselves ... an reason you're using these instead of 
eautoreconf ?  aclocal/autoconf changes often imply having to regenerate 
Makefile.in ...
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in x11-wm/sawfish: ChangeLog sawfish-1.3.2.ebuild sawfish-1.3_p20050816-r1.ebuild sawfish-1.3_p20060816.ebuild sawfish-1.3.20040120.ebuild sawfish-1.3.20060816.ebuild sawfish-1.3.20050816.ebuild sawfish-1.3.20050816-r1.ebuild sawfish-1.3.20040120-r1.ebuild

[Harald van Dijk]

On Tue, Jan 22, 2008 at 11:21:26PM -0500, Mike Frysinger wrote:
> On Tuesday 22 January 2008, Donnie Berkholz wrote:
> > On 20:58 Tue 22 Jan     , Harald van Dijk (truedfx) wrote:
> > > 	WANT_AUTOCONF=latest
> > > 	WANT_AUTOMAKE=latest
> 
> redundant, please drop

Done.

> > > 		eaclocal || die
> > > 		eautoconf || die
> 
> these things call die themselves ...
> an reason you're using these instead of 
> eautoreconf ?  aclocal/autoconf changes often imply having to regenerate 
> Makefile.in ...

sawfish doesn't use automake (except for aclocal), and eautoreconf used
to force automake. As it no longer has that problem, I've switched to
eautoreconf.

Thanks for the comments.
-- 
gentoo-dev@lists.gentoo.org mailing list