From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: x11@gentoo.org
Subject: [gentoo-dev] [RFC/PATCH] A cleaner API for virtualx.eclass
Date: Mon, 11 Feb 2013 23:14:38 +0100 [thread overview]
Message-ID: <1360620883-22562-1-git-send-email-mgorny@gentoo.org> (raw)
Hello, fellow developers,
The current virtualx.eclass API is a bit insane. It seems a bit like
stacking of a few next APIs, mostly designed to quickly run 'make
check', then extended to general functions.
For example running a function 'run_tests' with parameter '--foo' would
look like:
VIRTUALX_COMMAND=run_tests virtualmake --foo
which is really awful, considering that '--foo' is a parameter to
'run_tests' and not virtualmake.
My patches introduce a single wrapper with argv-as-parameter syntax.
That is, the fore-mentioned example would look like:
virtualx run_tests --foo
Depending on the maintainer decisions and your feedback, I believe that
even all the X* short-hand functions could be deprecated. They are a bit
shorter:
Xemake check
vs:
virtualx emake check
but I don't think that's much of a difference.
What are your thoughts?
next reply other threads:[~2013-02-11 22:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-11 22:14 Michał Górny [this message]
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 1/5] Introduce a cleaner alternative to VIRTUALX_COMMAND="" virtualmake Michał Górny
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 2/5] Use eqawarn from eutils.eclass Michał Górny
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 3/5] Convert X* functions to the new API Michał Górny
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 4/5] Deprecate virtualmake in favor of the new syntax Michał Górny
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 5/5] (Optionally) deprecate all X* wrappers Michał Górny
2013-02-11 22:48 ` [gentoo-dev] [RFC/PATCH] A cleaner API for virtualx.eclass Diego Elio Pettenò
2013-02-13 15:08 ` Gilles Dartiguelongue
2013-02-11 23:42 ` Andreas K. Huettel
2013-02-12 17:42 ` "Paweł Hajdan, Jr."
2013-02-26 14:40 ` Michał Górny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1360620883-22562-1-git-send-email-mgorny@gentoo.org \
--to=mgorny@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=x11@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox