public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Michał Górny" <mgorny@gentoo.org>
To: gentoo-dev@lists.gentoo.org
Cc: x11@gentoo.org, "Michał Górny" <mgorny@gentoo.org>
Subject: [gentoo-dev] [PATCH virtualx.eclass 5/5] (Optionally) deprecate all X* wrappers.
Date: Mon, 11 Feb 2013 23:14:43 +0100	[thread overview]
Message-ID: <1360620883-22562-6-git-send-email-mgorny@gentoo.org> (raw)
In-Reply-To: <1360620883-22562-1-git-send-email-mgorny@gentoo.org>

The new syntax seems simple enough that we can think of deprecating all
those short-hand forms.
---
 gx86/eclass/virtualx.eclass | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/gx86/eclass/virtualx.eclass b/gx86/eclass/virtualx.eclass
index f576335..9d5045d 100644
--- a/gx86/eclass/virtualx.eclass
+++ b/gx86/eclass/virtualx.eclass
@@ -189,8 +189,10 @@ virtualmake() {
 Xmake() {
 	debug-print-function ${FUNCNAME} "$@"
 
-	eqawarn "you should not execute make directly"
-	eqawarn "rather execute Xemake -j1 if you have issues with parallel make"
+	eqawarn "Using Xmake is considered deprecated."
+	eqawarn "Please use the new, cleaner API instead:"
+	eqawarn "	virtualx emake -j1 ..."
+
 	virtualx emake -j1 "$@"
 }
 
@@ -200,6 +202,10 @@ Xmake() {
 Xemake() {
 	debug-print-function ${FUNCNAME} "$@"
 
+	eqawarn "Using Xemake is considered deprecated."
+	eqawarn "Please use the new, cleaner API instead:"
+	eqawarn "	virtualx emake ..."
+
 	virtualx emake "$@"
 }
 
@@ -209,5 +215,9 @@ Xemake() {
 Xeconf() {
 	debug-print-function ${FUNCNAME} "$@"
 
+	eqawarn "Using Xeconf is considered deprecated."
+	eqawarn "Please use the new, cleaner API instead:"
+	eqawarn "	virtualx econf ..."
+
 	virtualx econf "$@"
 }
-- 
1.8.1.2



  parent reply	other threads:[~2013-02-11 22:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-11 22:14 [gentoo-dev] [RFC/PATCH] A cleaner API for virtualx.eclass Michał Górny
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 1/5] Introduce a cleaner alternative to VIRTUALX_COMMAND="" virtualmake Michał Górny
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 2/5] Use eqawarn from eutils.eclass Michał Górny
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 3/5] Convert X* functions to the new API Michał Górny
2013-02-11 22:14 ` [gentoo-dev] [PATCH virtualx.eclass 4/5] Deprecate virtualmake in favor of the new syntax Michał Górny
2013-02-11 22:14 ` Michał Górny [this message]
2013-02-11 22:48 ` [gentoo-dev] [RFC/PATCH] A cleaner API for virtualx.eclass Diego Elio Pettenò
2013-02-13 15:08   ` Gilles Dartiguelongue
2013-02-11 23:42 ` Andreas K. Huettel
2013-02-12 17:42 ` "Paweł Hajdan, Jr."
2013-02-26 14:40   ` Michał Górny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1360620883-22562-6-git-send-email-mgorny@gentoo.org \
    --to=mgorny@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=x11@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox