[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/tea: ChangeLog tea-17.4.1.ebuild

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/tea: ChangeLog tea-17.4.1.ebuild

[Donnie Berkholz]

On 17:30 Sat 17 Nov     , Peter Weller (welp) wrote:
> 1.1                  app-editors/tea/tea-17.4.1.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-editors/tea/tea-17.4.1.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-editors/tea/tea-17.4.1.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	local myconf
> 
> 	if use hacking; then
> 		myconf="${myconf} --enable-hacking"
> 	fi
> 	if ! use gnome; then
> 		myconf="${myconf} --enable-legacy"
> 	fi
> 	if use enchant; then
> 		myconf="${myconf} --enable-enchant"
> 	fi
> 
> 	econf \
> 	$(use_enable ipv6) \
> 	${myconf} || die "econf failed!"

Any reason the rest of the flags aren't using use_enable()?

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/tea: ChangeLog tea-17.4.1.ebuild

[Peter Weller]

[-- Attachment #1: Type: text/plain, Size: 1216 bytes --]

On Sat, 2007-11-17 at 12:53 -0800, Donnie Berkholz wrote:
> On 17:30 Sat 17 Nov     , Peter Weller (welp) wrote:
> > 1.1                  app-editors/tea/tea-17.4.1.ebuild
> > 
> > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-editors/tea/tea-17.4.1.ebuild?rev=1.1&view=markup
> > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-editors/tea/tea-17.4.1.ebuild?rev=1.1&content-type=text/plain
> 
> > src_compile() {
> > 	local myconf
> > 
> > 	if use hacking; then
> > 		myconf="${myconf} --enable-hacking"
> > 	fi
> > 	if ! use gnome; then
> > 		myconf="${myconf} --enable-legacy"
> > 	fi
> > 	if use enchant; then
> > 		myconf="${myconf} --enable-enchant"
> > 	fi
> > 
> > 	econf \
> > 	$(use_enable ipv6) \
> > 	${myconf} || die "econf failed!"
> 
> Any reason the rest of the flags aren't using use_enable()?
> 
> Thanks,
> Donnie

Yes. At least there used to be. I should check to see what the status is
at the moment. The configure script doesn't(/didn't) know about
--disable option(s) for at least some of the configuration flags, and
runtime problems were experienced in some cases. This may or may not be
fixed now, so I should check it out.

welp

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/tea: ChangeLog tea-17.4.1.ebuild

[Peter Weller]

[-- Attachment #1: Type: text/plain, Size: 1504 bytes --]

On Sat, 2007-11-17 at 21:43 +0000, Peter Weller wrote:
> On Sat, 2007-11-17 at 12:53 -0800, Donnie Berkholz wrote:
> > On 17:30 Sat 17 Nov     , Peter Weller (welp) wrote:
> > > 1.1                  app-editors/tea/tea-17.4.1.ebuild
> > > 
> > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-editors/tea/tea-17.4.1.ebuild?rev=1.1&view=markup
> > > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/app-editors/tea/tea-17.4.1.ebuild?rev=1.1&content-type=text/plain
> > 
> > > src_compile() {
> > > 	local myconf
> > > 
> > > 	if use hacking; then
> > > 		myconf="${myconf} --enable-hacking"
> > > 	fi
> > > 	if ! use gnome; then
> > > 		myconf="${myconf} --enable-legacy"
> > > 	fi
> > > 	if use enchant; then
> > > 		myconf="${myconf} --enable-enchant"
> > > 	fi
> > > 
> > > 	econf \
> > > 	$(use_enable ipv6) \
> > > 	${myconf} || die "econf failed!"
> > 
> > Any reason the rest of the flags aren't using use_enable()?
> > 
> > Thanks,
> > Donnie
> 
> Yes. At least there used to be. I should check to see what the status is
> at the moment. The configure script doesn't(/didn't) know about
> --disable option(s) for at least some of the configuration flags, and
> runtime problems were experienced in some cases. This may or may not be
> fixed now, so I should check it out.
> 
> welp

(To clarify: There was *something* wrong with use_enable(), I just can't
remember exactly *what* the problem was. Will look into it tomorrow
morning GMT.)

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-editors/tea: ChangeLog tea-17.4.1.ebuild

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

On Saturday 17 November 2007, Peter Weller wrote:
> Yes. At least there used to be. I should check to see what the status is
> at the moment. The configure script doesn't(/didn't) know about
> --disable option(s) for at least some of the configuration flags, and
> runtime problems were experienced in some cases. This may or may not be
> fixed now, so I should check it out.

any package that does not operate properly with --{enable,disable}-feature 
needs to get fixed.  it's usually quite trivial to resolve this in the 
configure script and get upstream to fix it.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 827 bytes --]