[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/mistbot: mistbot-0.9.ebuild metadata.xml Manifest ChangeLog

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/mistbot: mistbot-0.9.ebuild metadata.xml Manifest ChangeLog

[Donnie Berkholz]

On 22:45 Mon 29 Oct     , Dawid Weglinski (cla) wrote:
> Revision  Changes    Path
> 1.1                  net-irc/mistbot/mistbot-0.9.ebuild
> 
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-irc/mistbot/mistbot-0.9.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-irc/mistbot/mistbot-0.9.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
> 	ebegin "Change build.conf to fit needs"
> 
> 	if ! use xml; then
> 		sed -e '/^MODS\ +=\ rss$/d' -i build.conf || die "sed failed"
> 	fi
> 
> 	if ! use nls; then
> 		sed -e '/^NLS = nls$/d' -i build.conf || die "sed failed"
> 	fi
> 
> 	if ! use debug; then
> 		sed -e '/^DEBUG = debug$/d' -i build.conf || die "sed failed"
> 	fi
> 
> 	if ! use ssl; then
> 		sed -e '/^SSL = ssl$/d' -i build.conf || die "sed failed"
> 	fi
> 
> 	sed -e 's/^#ONCE\ =\ yes$/ONCE\ =\ yes/' -i build.conf || die "sed failed"

What's up with some of these escaping spaces, and others not?

> 	echo "CXXFLAGS=${CXXFLAGS}" >> build.conf
> 	echo "CXX=$(tc-getCXX)" >> build.conf
> 	echo "PREFIX=/usr" >> build.conf
> 
> 	ebegin "compiling source"
> 
> 	emake all-oneGo || die "emake failed"
> 
> 	if use doc; then
> 		ebegin "generate documentation"
> 		make doc || die "make doc failed"
> 	fi
> }
> 
> src_install() {
> 	make install DESTDIR="${D}" || die "make install failed"

Any particular reason 'emake' isn't used here or in the 'make doc' call?

Thanks,
Donnie
-- 
gentoo-dev@gentoo.org mailing list

Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-irc/mistbot: mistbot-0.9.ebuild metadata.xml Manifest ChangeLog

[Dawid Węgliński]

[-- Attachment #1: Type: text/plain, Size: 1906 bytes --]

Dnia 29-10-2007, Pn o godzinie 23:03 -0700, Donnie Berkholz napisał(a):
> On 22:45 Mon 29 Oct     , Dawid Weglinski (cla) wrote:
> > Revision  Changes    Path
> > 1.1                  net-irc/mistbot/mistbot-0.9.ebuild
> > 
> > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-irc/mistbot/mistbot-0.9.ebuild?rev=1.1&view=markup
> > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-irc/mistbot/mistbot-0.9.ebuild?rev=1.1&content-type=text/plain
> 
> > src_compile() {
> > 	ebegin "Change build.conf to fit needs"
> > 
> > 	if ! use xml; then
> > 		sed -e '/^MODS\ +=\ rss$/d' -i build.conf || die "sed failed"
> > 	fi
> > 
> > 	if ! use nls; then
> > 		sed -e '/^NLS = nls$/d' -i build.conf || die "sed failed"
> > 	fi
> > 
> > 	if ! use debug; then
> > 		sed -e '/^DEBUG = debug$/d' -i build.conf || die "sed failed"
> > 	fi
> > 
> > 	if ! use ssl; then
> > 		sed -e '/^SSL = ssl$/d' -i build.conf || die "sed failed"
> > 	fi
> > 
> > 	sed -e 's/^#ONCE\ =\ yes$/ONCE\ =\ yes/' -i build.conf || die "sed failed"
> 
> What's up with some of these escaping spaces, and others not?
> 
> > 	echo "CXXFLAGS=${CXXFLAGS}" >> build.conf
> > 	echo "CXX=$(tc-getCXX)" >> build.conf
> > 	echo "PREFIX=/usr" >> build.conf
> > 
> > 	ebegin "compiling source"
> > 
> > 	emake all-oneGo || die "emake failed"
> > 
> > 	if use doc; then
> > 		ebegin "generate documentation"
> > 		make doc || die "make doc failed"
> > 	fi
> > }
> > 
> > src_install() {
> > 	make install DESTDIR="${D}" || die "make install failed"
> 
> Any particular reason 'emake' isn't used here or in the 'make doc' call?
> 
> Thanks,
> Donnie

Fixed, thanks

Cheers
-- 
,-----------------------------.
| Dawid Węgliński             |
| cla@gentoo.org              |
| cla @ irc.freenode.net      |
| GPG: 295E72D9               |
`-----------------------------'


[-- Attachment #2: To jest część listu podpisana cyfrowo --]
[-- Type: application/pgp-signature, Size: 189 bytes --]