From: Ulrich Mueller <ulm@gentoo.org>
To: James Le Cuirot <chewi@gentoo.org>
Cc: gentoo-pms <gentoo-pms@lists.gentoo.org>
Subject: Re: [gentoo-pms] [PMS] [PATCH] Correct the definition of ESYSROOT as EPREFIX isn't always applicable
Date: Mon, 29 Jul 2019 13:39:19 +0200 [thread overview]
Message-ID: <w6ga7cxul20.fsf@kph.uni-mainz.de> (raw)
In-Reply-To: <20190728213734.20733-1-chewi@gentoo.org> (James Le Cuirot's message of "Sun, 28 Jul 2019 22:37:35 +0100")
[-- Attachment #1: Type: text/plain, Size: 1391 bytes --]
>>>>> On Sun, 28 Jul 2019, James Le Cuirot wrote:
> --- a/dependencies.tex
> +++ b/dependencies.tex
> @@ -32,13 +32,25 @@
> [...]
> + If \t{SYSROOT} is: & \t{\$\{ROOT\}} & \t{/} & Other \\
I wonder if the third column should't say "Empty" or "Blank"?
Path variables in EAPI 7 don't have a trailing slash.
> --- a/ebuild-env-vars.tex
> +++ b/ebuild-env-vars.tex
> @@ -141,9 +141,10 @@ variable.
> \t{ESYSROOT} &
> Ditto &
> No &
> - Contains the concatenation of the paths in the \t{SYSROOT} and \t{EPREFIX} variables,
> - for convenience. See also the \t{EPREFIX} variable. Only for EAPIs listed
> - in table~\ref{tab:offset-env-vars-table} as supporting \t{ESYSROOT}. \\
> + Contains the concatenation of the \t{SYSROOT} path and applicable prefix value. The prefix value
> + is \t{EPREFIX}, \t{BROOT}, or blank if \t{SYSROOT} is equal to \t{ROOT}, \t{/}, or something
> + else respectively. Only for EAPIs listed in table~\ref{tab:offset-env-vars-table} as supporting
> + \t{ESYSROOT}. \\
I'd says something like this, in order to avoid defining the same thing
in two places:
Contains the concatenation of the \t{SYSROOT} path and applicable prefix value, as determined
by table~\ref{tab:depend-prefix}. Only for EAPIs listed in table~\ref{tab:offset-env-vars-table}
as supporting \t{ESYSROOT}. \\
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-07-29 11:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-28 21:37 [gentoo-pms] [PMS] [PATCH] Correct the definition of ESYSROOT as EPREFIX isn't always applicable James Le Cuirot
2019-07-29 11:39 ` Ulrich Mueller [this message]
2020-06-21 13:01 ` [gentoo-pms] [PMS] [PATCH v2] " Ulrich Mueller
2020-06-28 10:49 ` Ulrich Mueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=w6ga7cxul20.fsf@kph.uni-mainz.de \
--to=ulm@gentoo.org \
--cc=chewi@gentoo.org \
--cc=gentoo-pms@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox