public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Mike Gilbert <floppym@gentoo.org>
Cc: Gentoo Dev <gentoo-dev@lists.gentoo.org>,
	 Pacho Ramos <pacho@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Use fixed location for README.gentoo
Date: Tue, 17 Aug 2021 06:53:26 +0200	[thread overview]
Message-ID: <upmuck6yh@gentoo.org> (raw)
In-Reply-To: <CAJ0EP423M9QxRyE-L6MCvmMjRvqdkkRyF8X=W99naG3-YFhVbg@mail.gmail.com> (Mike Gilbert's message of "Mon, 16 Aug 2021 16:13:54 -0400")

[-- Attachment #1: Type: text/plain, Size: 618 bytes --]

>>>>> On Mon, 16 Aug 2021, Mike Gilbert wrote:

> On Sun, Aug 15, 2021 at 6:55 AM Ulrich Müller <ulm@gentoo.org> wrote:
>> +       ( # subshell to avoid pollution of calling environment
>> +               docinto .
>> +               dodoc "${T}"/README.gentoo
>> +       )

> I believe the current handling "die" in subshells terminates execution
> at the end of the current phase.

> Maybe add "|| die" after the subshell so that execution stops
> immediately if dodoc fails.

Good catch. I think it's fine for current EAPIs, but for EAPI 6 we may
have a problem.

Patch v2 will follow.

Ulrich

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

  reply	other threads:[~2021-08-17  4:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-15 10:55 [gentoo-dev] [PATCH] readme.gentoo-r1.eclass: Use fixed location for README.gentoo Ulrich Müller
2021-08-16 20:13 ` Mike Gilbert
2021-08-17  4:53   ` Ulrich Mueller [this message]
2021-08-17  4:51 ` [gentoo-dev] [PATCH v2 1/2] " Ulrich Müller
2021-08-17  4:51 ` [gentoo-dev] [PATCH v2 2/2] readme.gentoo-r1.eclass: Standardize EAPI guard Ulrich Müller
2021-08-18  7:50   ` [gentoo-dev] " Pacho Ramos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=upmuck6yh@gentoo.org \
    --to=ulm@gentoo.org \
    --cc=floppym@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=pacho@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox