From: Ulrich Mueller <ulm@gentoo.org>
To: Andreas Sturmlechner <asturm@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org, Sergei Trofimovich <slyfox@gentoo.org>
Subject: Re: [gentoo-dev] [PATCH v2 3/5] flag-o-matic.eclass: get rid of eutils in <EAPI-8, fix eclassdoc, make some funcs internal
Date: Thu, 01 Apr 2021 23:42:10 +0200 [thread overview]
Message-ID: <uo8exznpp@gentoo.org> (raw)
In-Reply-To: <3350735.dWV9SEqChM@tuxbook> (Andreas Sturmlechner's message of "Thu, 01 Apr 2021 11:59:48 +0200")
[-- Attachment #1: Type: text/plain, Size: 546 bytes --]
>>>>> On Thu, 01 Apr 2021, Andreas Sturmlechner wrote:
> +# @FUNCTION: test-flag-PROG
> +# @USAGE: <compiler> <flag>
> +# @INTERNAL
> +# @DESCRIPTION:
> +# Returns shell true if <flag> is supported by given <compiler>,
> +# else returns shell false.
> test-flag-PROG() {
> + [[ ${EAPI} == [5-7] ]] ||
> + die "Internal function ${FUNCNAME} is not available in >=EAPI-8."
> + _test-flag-PROG
> +}
Any reason why this cannot say "... in EAPI ${EAPI}." as I had suggested
earlier?
(Same for the other patches in the series.)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2021-04-01 21:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 6:39 [gentoo-dev] [PATCH] flag-o-matic.eclass: get rid of eutils in <EAPI-8, fix eclassdoc, make some funcs internal Andreas Sturmlechner
2021-03-31 7:33 ` Sergei Trofimovich
2021-03-31 7:45 ` Andreas Sturmlechner
2021-03-31 9:13 ` Sergei Trofimovich
2021-03-31 10:03 ` Wolfgang E. Sanyer
2021-04-01 13:42 ` Andreas Sturmlechner
2021-04-01 9:57 ` [gentoo-dev] [PATCH v2 1/5] " Andreas Sturmlechner
2021-04-01 9:58 ` [gentoo-dev] [PATCH v2 2/5] " Andreas Sturmlechner
2021-04-01 9:59 ` [gentoo-dev] [PATCH v2 3/5] " Andreas Sturmlechner
2021-04-01 10:01 ` [gentoo-dev] [PATCH v2 4/5] " Andreas Sturmlechner
2021-04-01 10:02 ` [gentoo-dev] [PATCH v2 5/5] " Andreas Sturmlechner
2021-04-01 18:40 ` Sergei Trofimovich
2021-04-01 18:39 ` [gentoo-dev] [PATCH v2 4/5] " Sergei Trofimovich
2021-04-01 18:37 ` [gentoo-dev] [PATCH v2 3/5] " Sergei Trofimovich
2021-04-01 21:42 ` Ulrich Mueller [this message]
2021-04-02 9:49 ` Andreas Sturmlechner
2021-04-01 18:30 ` [gentoo-dev] [PATCH v2 2/5] " Sergei Trofimovich
2021-04-01 18:26 ` [gentoo-dev] [PATCH v2 1/5] " Sergei Trofimovich
2021-03-31 7:36 ` [gentoo-dev] [PATCH] " Sam James
2021-03-31 9:09 ` Ulrich Mueller
2021-04-01 21:57 ` Sam James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=uo8exznpp@gentoo.org \
--to=ulm@gentoo.org \
--cc=asturm@gentoo.org \
--cc=gentoo-dev@lists.gentoo.org \
--cc=slyfox@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox