public inbox for gentoo-dev@lists.gentoo.org
 help / color / mirror / Atom feed
From: Ulrich Mueller <ulm@gentoo.org>
To: Marek Szuba <marecki@gentoo.org>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH] cuda.eclass: EAPI support: add 8, drop 5 and 6
Date: Thu, 15 Jul 2021 07:58:51 +0200	[thread overview]
Message-ID: <ueec0ktic@gentoo.org> (raw)
In-Reply-To: <20210714224951.934977-2-marecki@gentoo.org> (Marek Szuba's message of "Wed, 14 Jul 2021 23:49:51 +0100")

[-- Attachment #1: Type: text/plain, Size: 542 bytes --]

>>>>> On Thu, 15 Jul 2021, Marek Szuba wrote:
 
>  case "${EAPI:-0}" in
> -	0|1|2|3|4)
> +	[0-6])
>  		die "Unsupported EAPI=${EAPI:-0} (too old) for ${ECLASS}"
>  		;;
> -	5|6|7)
> +	7|8)
>  		;;
>  	*)
>  		die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"

In the latest bunch of updates, we have changed many eclasses to have
only a single error case, and also standardized the die message.
Maybe simplify this eclass as well?

case ${EAPI} in
	7|8) ;;
	*) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;;
esac

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]

  reply	other threads:[~2021-07-15  5:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 22:49 [gentoo-dev] cuda.eclass EAPI-support shuffle Marek Szuba
2021-07-14 22:49 ` [gentoo-dev] [PATCH] cuda.eclass: EAPI support: add 8, drop 5 and 6 Marek Szuba
2021-07-15  5:58   ` Ulrich Mueller [this message]
2021-07-15 20:41     ` Marek Szuba
2021-07-16 21:41       ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ueec0ktic@gentoo.org \
    --to=ulm@gentoo.org \
    --cc=gentoo-dev@lists.gentoo.org \
    --cc=marecki@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox