From: Ulrich Mueller <ulm@gentoo.org>
To: Rolf Eike Beer <eike@sf-mail.de>
Cc: gentoo-dev@lists.gentoo.org
Subject: Re: [gentoo-dev] [PATCH 2/3 v3] qmail.eclass: remove magic to query root group
Date: Sat, 14 Aug 2021 12:52:15 +0200 [thread overview]
Message-ID: <ueeawl2n4@gentoo.org> (raw)
In-Reply-To: <2590214.mvXUDI8C0e@daneel.sf-tec.de> (Rolf Eike Beer's message of "Sat, 14 Aug 2021 11:36:34 +0200")
[-- Attachment #1: Type: text/plain, Size: 687 bytes --]
>>>>> On Sat, 14 Aug 2021, Rolf Eike Beer wrote:
> The default owner is root:root anyway, so just make sure other settings do not
> leak outside from the places where it is actually used. This also fixes
> qmail_supervise_install_one() when called from outside of qmail_src_install().
Looking at this patch again, I wonder about two points in general:
- diropts -m 0755 shouldn't be necessary. 0775 is dodir's default, and I
don't see any diropts with another -m option in the eclass.
- insinto ...; insopts -m 0755; doins ... presumably indicates that the
wrong tool is used, i.e. it should be exeinto ...; doexe ... instead.
doexe already defaults to file mode 0755.
Ulrich
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 507 bytes --]
next prev parent reply other threads:[~2021-08-14 10:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 9:54 [gentoo-dev] [PATCH 1/3] qmail.eclass: support EAPI 8 Rolf Eike Beer
2021-08-12 9:55 ` [gentoo-dev] [PATCH 2/3] qmail.eclass: hardcode root group Rolf Eike Beer
2021-08-12 11:13 ` Ulrich Mueller
2021-08-12 14:03 ` Rolf Eike Beer
2021-08-12 15:22 ` [gentoo-dev] [PATCH 2/3] qmail.eclass: remove magic to query " Rolf Eike Beer
2021-08-12 17:39 ` Michael Orlitzky
2021-08-13 7:17 ` Rolf Eike Beer
2021-08-13 9:06 ` Ulrich Mueller
2021-08-13 10:31 ` Rolf Eike Beer
2021-08-14 10:43 ` David Seifert
2021-08-14 9:36 ` [gentoo-dev] [PATCH 2/3 v3] " Rolf Eike Beer
2021-08-14 10:52 ` Ulrich Mueller [this message]
2021-08-14 11:11 ` Rolf Eike Beer
2021-08-14 11:54 ` Ulrich Mueller
2021-08-14 11:34 ` [gentoo-dev] [PATCH 2/3 v4] " Rolf Eike Beer
2021-08-12 9:55 ` [gentoo-dev] [PATCH 3/5] qmail.eclass: simplify is_prime() Rolf Eike Beer
2021-08-12 11:25 ` Ulrich Mueller
2021-08-12 15:25 ` Rolf Eike Beer
2021-08-12 15:25 ` [gentoo-dev] [PATCH 3/3] " Rolf Eike Beer
2021-08-13 7:47 ` [gentoo-dev] [PATCH 4/3] qmail.eclass: remove needless keepdirs Rolf Eike Beer
2021-08-14 11:47 ` [gentoo-dev] [PATCH 4/3 v2] " Rolf Eike Beer
2021-08-13 10:44 ` [gentoo-dev] [PATCH 5/3] qmail.eclass: retire qmail_tcprules_fixup() Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ueeawl2n4@gentoo.org \
--to=ulm@gentoo.org \
--cc=eike@sf-mail.de \
--cc=gentoo-dev@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox