public inbox for gentoo-pms@lists.gentoo.org
 help / color / mirror / Atom feed
From: "Ulrich Müller" <ulm@gentoo.org>
To: gentoo-pms@lists.gentoo.org
Subject: [gentoo-pms] [PATCH] profiles.tex: The parent file can contain comments
Date: Wed, 12 Apr 2023 21:23:39 +0200	[thread overview]
Message-ID: <u1qkohpl0@gentoo.org> (raw)

Closes: https://bugs.gentoo.org/470094
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
---

Since there haven't been any further comments in reply to [1], this
patch updates the spec to allow comments in the parent file.

AFAICS, Portage and Pkgcore have always supported this, because they use
the same function for reading of all line-based files in a profile.

[1] https://bugs.gentoo.org/470094#c11

 profiles.tex | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/profiles.tex b/profiles.tex
index 30da81b..856643b 100644
--- a/profiles.tex
+++ b/profiles.tex
@@ -25,7 +25,8 @@
 It is illegal for a profile's parent tree to contain cycles. Package manager behaviour upon
 encountering a cycle is undefined.
 
-This file must not contain comments, blank lines or make use of line continuations.
+This file must not make use of line continuations. Blank lines and those beginning with a \t{\#}
+are discarded.
 
 \subsection{The eapi file}
 \label{sec:profile-eapi}
-- 
2.40.0



                 reply	other threads:[~2023-04-12 19:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=u1qkohpl0@gentoo.org \
    --to=ulm@gentoo.org \
    --cc=gentoo-pms@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox