From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.67) (envelope-from ) id 1IGxpU-0003XZ-NG for garchives@archives.gentoo.org; Fri, 03 Aug 2007 14:08:37 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.0/8.14.0) with SMTP id l73E8Wu7001898; Fri, 3 Aug 2007 14:08:32 GMT Received: from mail.bawue.net (phoenix.bawue.net [193.7.176.60]) by robin.gentoo.org (8.14.0/8.14.0) with ESMTP id l73E8WwJ001893 for ; Fri, 3 Aug 2007 14:08:32 GMT Received: from [193.166.89.200] (b136a.mtalo.tontut.fi [193.166.89.200]) (using SSLv3 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mail.bawue.net (Postfix) with ESMTP id 350C7B86B7 for ; Fri, 3 Aug 2007 15:57:44 +0200 (CEST) Subject: Re: [gnap-dev] [PATCH 0/4] GNAP improvements, probably for 2.1 From: Philipp Riegger To: gnap-dev@lists.gentoo.org In-Reply-To: <1186146995.10651.18.camel@b136a> References: <1186146995.10651.18.camel@b136a> Content-Type: text/plain Date: Fri, 03 Aug 2007 16:57:42 +0300 Message-Id: <1186149463.10651.56.camel@b136a> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo GNAP development X-BeenThere: gnap-dev@gentoo.org Reply-to: gnap-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.10.2 Content-Transfer-Encoding: 7bit X-Archives-Salt: be2fd948-9f16-4e15-9add-c833565327e8 X-Archives-Hash: ee1af49ccb1b6658206f662f194ee734 On Fri, 2007-08-03 at 16:16 +0300, Philipp Riegger wrote: > Things that still need to be done: > - Make the portage tarball creation code of gnap_make nicer. Since > catalyst supports overlays, this is probably the way to go: Use the > unmodified potage snapshot and merge all given overlays into one > overlay > and give it to catalyst. Maybe catalyst can even handle more than one > overlay, but i do not know since i did not have a look at this. > - Lots of code is still duplicated in there and could be put to > functions. I espcially mean gnap_make and the stage-specific code. > - This patchset works on the scripts, mostly n gnap_make and only > does > minimal changes to the provided config files. Maybe the gnap-devver > convigfiles have to be changed accordingly, someone should have a look > at the patches and theese files. - I was planign to have a look at a test set for gnap_make this would do the following: - Create a test for every error patch (gtest $?, gdie) to look i they are triggered corrrectly and if the output is right. - Create a test case that builds every possible stage with an empty storedir (possibly 1 test per stage). - Weekly builds with the gnap tree/a tree snapshot from upstream. Philipp -- gnap-dev@gentoo.org mailing list