From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.62) (envelope-from <gnap-dev+bounces-40-garchives=archives.gentoo.org@gentoo.org>) id 1I7nR5-00043u-FM for garchives@archives.gentoo.org; Mon, 09 Jul 2007 07:13:31 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.14.0/8.14.0) with SMTP id l697DRxZ009477; Mon, 9 Jul 2007 07:13:27 GMT Received: from smtp-gw5.mailanyone.net (smtp-gw5.mailanyone.net [208.70.128.56]) by robin.gentoo.org (8.14.0/8.14.0) with ESMTP id l697DQ5e009472 for <gnap-dev@lists.gentoo.org>; Mon, 9 Jul 2007 07:13:26 GMT Received: from mailanyone.net by smtp-gw5.mailanyone.net with esmtpsa (TLSv1:RC4-MD5:128) (MailAnyone extSMTP jalbertosl) id 1I7nQx-0003j7-A7 for gnap-dev@lists.gentoo.org; Mon, 09 Jul 2007 02:13:23 -0500 Subject: Re: [gnap-dev] Some patches for gnap From: =?ISO-8859-1?Q?jos=E9?= Alberto =?ISO-8859-1?Q?Su=E1rez_L=F3pez?= <bass@gentoo.org> To: gnap-dev@lists.gentoo.org In-Reply-To: <45178.130.230.11.107.1183734500.squirrel@my.bawue.net> References: <59506.130.230.11.107.1183640031.squirrel@my.bawue.net> <1183707646.27777.15.camel@supercoco> <45178.130.230.11.107.1183734500.squirrel@my.bawue.net> Content-Type: text/plain; charset=utf-8 Date: Mon, 09 Jul 2007 09:13:20 +0200 Message-Id: <1183965200.16340.8.camel@supercoco> Precedence: bulk List-Post: <mailto:gnap-dev@lists.gentoo.org> List-Help: <mailto:gnap-dev+help@gentoo.org> List-Unsubscribe: <mailto:gnap-dev+unsubscribe@gentoo.org> List-Subscribe: <mailto:gnap-dev+subscribe@gentoo.org> List-Id: Gentoo GNAP development <gnap-dev.gentoo.org> X-BeenThere: gnap-dev@gentoo.org Reply-to: gnap-dev@lists.gentoo.org Mime-Version: 1.0 X-Mailer: Evolution 2.8.3 Content-Transfer-Encoding: quoted-printable X-Archives-Salt: e637ae9c-1c06-4e1c-9c46-c0067e0321ee X-Archives-Hash: 5a9cfaf1369d14c7ba34d5757ceda1a9 El vie, 06-07-2007 a las 18:08 +0300, Philipp Riegger escribi=C3=B3: > jos=C3=A9 Alberto Su=C3=A1rez L=C3=B3pez wrote: >=20 > > kingtaco told me infra have the new machine, so i hope to have our new > > home soon, so all of us can use the repo to work together and fast. >=20 > Nice. With this change, are you also switching to svn or soemthing like > that or changing the gnap repository layout? Making a difference between > gnap_make and the other scripts seems rather artificial, since they are > sharing code now. we will change to svn, the layout is not determined yet, Who want to be the first to propose the layout? :) > >> Note: > >> 1) There are 2 gnap_shared.sh so far, one in the src and one in the to= os > >> directory of the gnap svn tree. This should maybe be changed... > > > > shoudl be >=20 > Where do you want to have it? as you own :) [...] > > i like the idea, work on it and tell me. I prefer as less config files > > to edit better. >=20 > The easiest way to implement this would be: >=20 > We use ${:-} or ${:=3D} (i have to understand the difference between them= ) > for default parameters, parse the command line for the first time only > extracting parameters concerning external config files or -h, parse thees= e > config files (we have them or default config files), order will be > common.conf and then catalyst.conf (so common.conf can overwrite the > variable saying where to find catalyst.conf), we parse the command line > options again and use all the info given there to set/overwrite variables= . >=20 > Advantages: > - No additional variables needed > - Quite easy change > - Should give us what we want > - No need for a config file parser >=20 > Disadvantages: > - Well... common.conf and catalyst.conf can overwrite lots of things, we > never check which config file is allowed to overwrite what. But if > somebody does strange things there, it's not our fault, i think seem well to me, who thinks the other zombies in the list? [...] > >> 3) gnap_make feature: improved overlay handling >=20 > [...] >=20 > > To improve is ever good :) >=20 > An alternative would be to introduce overlay handling to catalyst, but i > think, we don't want that. :-) sure :P > >> 4) some small stuff > >> > >> At the moment, if there is a choice (Overwrite/Append, Yes/No) only on= e > >> possibility is checked and the other is assumed, if the one is not > >> given. > >> I'd like to change this to something like "It is asked in a loop until= a > >> valid option is given." ok, is not a major change > >> There is a function gwarn, writes to stderr. It is used in some places > >> where ginfo would make more sence, if it would exist. I'd like to > >> implement and use this. > > > > for example? >=20 > gwarn 'The following targets will be called:' > gwarn "${TARGETLIST}" ok implement ginfo. > >> That's all i wanted to say about the gnap_scripts at the moment. > > > > you say a lot :) >=20 > Hmm... is that good or bad? :) good :P >=20 > > nice job >=20 > Thanks, unfortunately not what i applied for. :-( >=20 > See you, > Philipp -- gnap-dev@gentoo.org mailing list