* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-20 13:40 [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules walt
@ 2013-02-20 14:04 ` Michael Hampicke
2013-02-20 20:23 ` Markos Chandras
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: Michael Hampicke @ 2013-02-20 14:04 UTC (permalink / raw
To: gentoo-user
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
2013/2/20 walt <w41ter@gmail.com>
> Now that kernel 3.8.0 is officially released, 'tis the season for Linus to
> start breaking all of the third-party kernel modules he can, and
> virtualbox-
> modules is the first (nvidia.ko and other kernel modules to follow,
> probably ;)
>
> Virtualbox-modules fails to build against today's kernel.git update from
> Linus,
> with an error message that "MAX_PRIO is undefined" in
> thread2-r0drv-linux.c.
>
> The fix is happily very simple because he moved the definition of MAX_PRIO
> into <linux/init_task.h>, so all you need to do is to add that include near
> the top of thread2-r0drv-linux.c.
>
>
r8168 breaks too, but I haven't looked into it yet.
[-- Attachment #2: Type: text/html, Size: 1006 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-20 13:40 [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules walt
2013-02-20 14:04 ` Michael Hampicke
@ 2013-02-20 20:23 ` Markos Chandras
2013-02-20 20:57 ` Mike Gilbert
2013-02-21 8:30 ` Helmut Jarausch
3 siblings, 0 replies; 14+ messages in thread
From: Markos Chandras @ 2013-02-20 20:23 UTC (permalink / raw
To: gentoo-user
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
On 02/20/2013 01:40 PM, walt wrote:
> Now that kernel 3.8.0 is officially released, 'tis the season for
> Linus to start breaking all of the third-party kernel modules he
> can, and virtualbox- modules is the first (nvidia.ko and other
> kernel modules to follow, probably ;)
>
> Virtualbox-modules fails to build against today's kernel.git update
> from Linus, with an error message that "MAX_PRIO is undefined" in
> thread2-r0drv-linux.c.
>
> The fix is happily very simple because he moved the definition of
> MAX_PRIO into <linux/init_task.h>, so all you need to do is to add
> that include near the top of thread2-r0drv-linux.c.
>
>
Thanks for the heads-up but did you actually report that to our
bugzilla so we can include proper fixes in the external modules? did
you try to contact the authors of the virtualbox-modules package to
let them know as well? Reporting this problem in this mailing list has
little value as every user needs to hack the packages on his own to
make them work which is not an easy task for people who have not
fiddled with ebuilds before
- --
Regards,
Markos Chandras - Gentoo Linux Developer
http://dev.gentoo.org/~hwoarang
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
iQJ8BAEBCgBmBQJRJTC2XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzNTVDNDczOUYzRjJEMTRGNDRGMzU2RkMw
OUJGNEY1NEMyQkE3RjNDAAoJEAm/T1TCun88PNwP/jNIL5EzWQmJhU/2VZ1wucr6
yg9ARpfu6pDWNja3TYWo8Q0KM49Qnfw9trpWuAi+IvRWhJAtJEl+BKMX2SO6ZSsy
MrjCHPvt3+AjSdqBNHSjFuCkrtqyZ3QqnlolCtz+rLeurw4T6nQySyecHlsOzp1f
cG75d3oZdvbV9UFaWo+f6weSQ92DWm94CFTygKRzrTLo0Iw+TerEW/WCilcDJ3tI
hYXb939FbsP3fuYbMxh4Nxuuyr/QEZAycyqD2518tBYlK/RY7pis/GMhI/IMmcFQ
dlwYX9BSSrYr0h27hqn/gmVCcwerb6a8o5/s046C1dt/sTSewjs6OKOgfzS9TD2C
vwRP7WWbL6RpQHqeqd1UroVXd5ldIc0gDk/hGZVkmEcg/50LtQiNM8ZrG0OctcBG
KCavV7SIE1nxodC0HW43o5IHIkL6qTicZqmMm685fIH0kHNLZ51IxgSxo1fP8NtM
ib0wX01twEoadiODp+smC2jRBqC58D5ReeXHM4ezIAYaRuVq+X0IjdftFNqJ2eOl
/SKdNfVi+Srm5FT8xtQhPa/WOaZRRGZ0nbTzql+VZeyWz2lfDA2H3O2SqEF+mfn5
ktjnc5YiQFCuiHIcEljsv5hkYQjr9GSOQdpuL0ZciX4Qp3cmF754uJybKe1wDnf3
gKMz7NH1V5h1fIjJN7QC
=SbXr
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-20 13:40 [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules walt
2013-02-20 14:04 ` Michael Hampicke
2013-02-20 20:23 ` Markos Chandras
@ 2013-02-20 20:57 ` Mike Gilbert
2013-02-21 1:15 ` [gentoo-user] " walt
2013-02-21 10:00 ` [gentoo-user] " Joerg Schilling
2013-02-21 8:30 ` Helmut Jarausch
3 siblings, 2 replies; 14+ messages in thread
From: Mike Gilbert @ 2013-02-20 20:57 UTC (permalink / raw
To: gentoo-user
On Wed, Feb 20, 2013 at 8:40 AM, walt <w41ter@gmail.com> wrote:
> Now that kernel 3.8.0 is officially released, 'tis the season for Linus to
> start breaking all of the third-party kernel modules he can, and virtualbox-
> modules is the first (nvidia.ko and other kernel modules to follow, probably ;)
>
Linus just merges the stuff. No need to make it sound like a personal vendetta.
> Virtualbox-modules fails to build against today's kernel.git update from Linus,
> with an error message that "MAX_PRIO is undefined" in thread2-r0drv-linux.c.
>
> The fix is happily very simple because he moved the definition of MAX_PRIO
> into <linux/init_task.h>, so all you need to do is to add that include near
> the top of thread2-r0drv-linux.c.
>
MAX_PRIO actually moved to linux/sched/rt.h, which linux/init_task.h #includes.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [gentoo-user] Re: ["PATCH"] Linus breaks virtualbox-modules
2013-02-20 20:57 ` Mike Gilbert
@ 2013-02-21 1:15 ` walt
2013-02-21 1:53 ` Mike Gilbert
2013-02-21 10:00 ` [gentoo-user] " Joerg Schilling
1 sibling, 1 reply; 14+ messages in thread
From: walt @ 2013-02-21 1:15 UTC (permalink / raw
To: gentoo-user
On 02/20/2013 12:57 PM, Mike Gilbert wrote:
> On Wed, Feb 20, 2013 at 8:40 AM, walt <w41ter@gmail.com> wrote:
>> Now that kernel 3.8.0 is officially released, 'tis the season for Linus to
>> start breaking all of the third-party kernel modules he can, and virtualbox-
>> modules is the first (nvidia.ko and other kernel modules to follow, probably ;)
>>
>
> Linus just merges the stuff. No need to make it sound like a personal vendetta.
Hey Mike and Markos, I see you guys are both gentoo devs, so I (and all of us
nerds who hang out here) owe you both a huge thank-you for all your good work:
Thank you! (If this post were in html, that thank-you would be in huge type :)
My comment about Linus was an example of (what I call) my dry sense of humor.
(OTOH my wife would call me a sarcastic asshole, but she's wrong, of course.)
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [gentoo-user] Re: ["PATCH"] Linus breaks virtualbox-modules
2013-02-21 1:15 ` [gentoo-user] " walt
@ 2013-02-21 1:53 ` Mike Gilbert
2013-02-21 2:33 ` Pandu Poluan
0 siblings, 1 reply; 14+ messages in thread
From: Mike Gilbert @ 2013-02-21 1:53 UTC (permalink / raw
To: gentoo-user
On Wed, Feb 20, 2013 at 8:15 PM, walt <w41ter@gmail.com> wrote:
> On 02/20/2013 12:57 PM, Mike Gilbert wrote:
>> On Wed, Feb 20, 2013 at 8:40 AM, walt <w41ter@gmail.com> wrote:
>>> Now that kernel 3.8.0 is officially released, 'tis the season for Linus to
>>> start breaking all of the third-party kernel modules he can, and virtualbox-
>>> modules is the first (nvidia.ko and other kernel modules to follow, probably ;)
>>>
>>
>> Linus just merges the stuff. No need to make it sound like a personal vendetta.
>
> Hey Mike and Markos, I see you guys are both gentoo devs, so I (and all of us
> nerds who hang out here) owe you both a huge thank-you for all your good work:
> Thank you! (If this post were in html, that thank-you would be in huge type :)
>
> My comment about Linus was an example of (what I call) my dry sense of humor.
> (OTOH my wife would call me a sarcastic asshole, but she's wrong, of course.)
>
>
Somehow I missed the joke in my rush to prove someone wrong on the internet. :P
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [gentoo-user] Re: ["PATCH"] Linus breaks virtualbox-modules
2013-02-21 1:53 ` Mike Gilbert
@ 2013-02-21 2:33 ` Pandu Poluan
0 siblings, 0 replies; 14+ messages in thread
From: Pandu Poluan @ 2013-02-21 2:33 UTC (permalink / raw
To: gentoo-user
[-- Attachment #1: Type: text/plain, Size: 1173 bytes --]
On Feb 21, 2013 8:54 AM, "Mike Gilbert" <floppym@gentoo.org> wrote:
>
> On Wed, Feb 20, 2013 at 8:15 PM, walt <w41ter@gmail.com> wrote:
> > On 02/20/2013 12:57 PM, Mike Gilbert wrote:
> >> On Wed, Feb 20, 2013 at 8:40 AM, walt <w41ter@gmail.com> wrote:
> >>> Now that kernel 3.8.0 is officially released, 'tis the season for
Linus to
> >>> start breaking all of the third-party kernel modules he can, and
virtualbox-
> >>> modules is the first (nvidia.ko and other kernel modules to follow,
probably ;)
> >>>
> >>
> >> Linus just merges the stuff. No need to make it sound like a personal
vendetta.
> >
> > Hey Mike and Markos, I see you guys are both gentoo devs, so I (and all
of us
> > nerds who hang out here) owe you both a huge thank-you for all your
good work:
> > Thank you! (If this post were in html, that thank-you would be in huge
type :)
> >
> > My comment about Linus was an example of (what I call) my dry sense of
humor.
> > (OTOH my wife would call me a sarcastic asshole, but she's wrong, of
course.)
> >
> >
>
> Somehow I missed the joke in my rush to prove someone wrong on the
internet. :P
>
Obligatory xkcd reference:
http://xkcd.com/386/
Rgds,
--
[-- Attachment #2: Type: text/html, Size: 1632 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-20 20:57 ` Mike Gilbert
2013-02-21 1:15 ` [gentoo-user] " walt
@ 2013-02-21 10:00 ` Joerg Schilling
2013-02-21 20:15 ` Bruce Hill
2013-02-22 5:30 ` Alon Bar-Lev
1 sibling, 2 replies; 14+ messages in thread
From: Joerg Schilling @ 2013-02-21 10:00 UTC (permalink / raw
To: gentoo-user
Mike Gilbert <floppym@gentoo.org> wrote:
> On Wed, Feb 20, 2013 at 8:40 AM, walt <w41ter@gmail.com> wrote:
> > Now that kernel 3.8.0 is officially released, 'tis the season for Linus to
> > start breaking all of the third-party kernel modules he can, and virtualbox-
> > modules is the first (nvidia.ko and other kernel modules to follow, probably ;)
> >
>
> Linus just merges the stuff. No need to make it sound like a personal vendetta.
I cannot speak for your specific case, but I know that Linus definitely did
break the SCSI generic pass through interface in Linux several times and one
time this was done while integrating his personal code.
At that time it turned out, that Linus does not seem to be able to understand
what changes may break an interface. The real problem however was that he was
not willing to fix his fault, so we can definitely call this case (from Spring
2004) a break by intention.
Jörg
--
EMail:joerg@schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
js@cs.tu-berlin.de (uni)
joerg.schilling@fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
URL: http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-21 10:00 ` [gentoo-user] " Joerg Schilling
@ 2013-02-21 20:15 ` Bruce Hill
2013-02-22 5:30 ` Alon Bar-Lev
1 sibling, 0 replies; 14+ messages in thread
From: Bruce Hill @ 2013-02-21 20:15 UTC (permalink / raw
To: gentoo-user
On Thu, Feb 21, 2013 at 11:00:52AM +0100, Joerg Schilling wrote:
>
> I cannot speak for your specific case, but I know that Linus definitely did
> break the SCSI generic pass through interface in Linux several times and one
> time this was done while integrating his personal code.
>
> At that time it turned out, that Linus does not seem to be able to understand
> what changes may break an interface. The real problem however was that he was
> not willing to fix his fault, so we can definitely call this case (from Spring
> 2004) a break by intention.
>
>
> Jörg
>
> --
> EMail:joerg@schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
> js@cs.tu-berlin.de (uni)
> joerg.schilling@fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
> URL: http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily
Wow! You never know what lurks on these lists...
--
Happy Penguin Computers >')
126 Fenco Drive ( \
Tupelo, MS 38801 ^^
support@happypenguincomputers.com
662-269-2706 662-205-6424
http://happypenguincomputers.com/
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
Don't top-post: http://en.wikipedia.org/wiki/Top_post#Top-posting
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-21 10:00 ` [gentoo-user] " Joerg Schilling
2013-02-21 20:15 ` Bruce Hill
@ 2013-02-22 5:30 ` Alon Bar-Lev
2013-02-22 10:27 ` Joerg Schilling
1 sibling, 1 reply; 14+ messages in thread
From: Alon Bar-Lev @ 2013-02-22 5:30 UTC (permalink / raw
To: gentoo-user
On Thu, Feb 21, 2013 at 12:00 PM, Joerg Schilling
<Joerg.Schilling@fokus.fraunhofer.de> wrote:
> Mike Gilbert <floppym@gentoo.org> wrote:
> At that time it turned out, that Linus does not seem to be able to understand
> what changes may break an interface. The real problem however was that he was
> not willing to fix his fault, so we can definitely call this case (from Spring
> 2004) a break by intention.
You are totally confusing between stable user space interfaces and
unstable kernel interfaces.
Kernel is allowed to evolve without legacy and breaking whatever
needed in order to be in better shape. Whoever writes external module
should merge it into mainline or rebase every release.
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-22 5:30 ` Alon Bar-Lev
@ 2013-02-22 10:27 ` Joerg Schilling
2013-02-22 21:44 ` Bruce Hill
2013-02-22 21:45 ` Bruce Hill
0 siblings, 2 replies; 14+ messages in thread
From: Joerg Schilling @ 2013-02-22 10:27 UTC (permalink / raw
To: gentoo-user
Alon Bar-Lev <alonbl@gentoo.org> wrote:
> On Thu, Feb 21, 2013 at 12:00 PM, Joerg Schilling
> <Joerg.Schilling@fokus.fraunhofer.de> wrote:
> > Mike Gilbert <floppym@gentoo.org> wrote:
> > At that time it turned out, that Linus does not seem to be able to understand
> > what changes may break an interface. The real problem however was that he was
> > not willing to fix his fault, so we can definitely call this case (from Spring
> > 2004) a break by intention.
>
> You are totally confusing between stable user space interfaces and
> unstable kernel interfaces.
> Kernel is allowed to evolve without legacy and breaking whatever
> needed in order to be in better shape. Whoever writes external module
> should merge it into mainline or rebase every release.
Well, it seemt that you are confusing user-interfaces with kernel-internal-interfaces :-(
I was of course writing about a kernel <-> user interface that need to stay
stable as the problem has been identified with cdrtools and cdrtools are known to run
in user space.
It seems however, that you have similar problems as Linus. Linus believes that
user level code is not allowed to include include files from the kernel that
describe kernel <-> user interfaces. With this rule, he disallows kernel <-> user
interfaces to be used at all - which looks really strange.
Jörg
--
EMail:joerg@schily.isdn.cs.tu-berlin.de (home) Jörg Schilling D-13353 Berlin
js@cs.tu-berlin.de (uni)
joerg.schilling@fokus.fraunhofer.de (work) Blog: http://schily.blogspot.com/
URL: http://cdrecord.berlios.de/private/ ftp://ftp.berlios.de/pub/schily
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-22 10:27 ` Joerg Schilling
@ 2013-02-22 21:44 ` Bruce Hill
2013-02-22 21:45 ` Bruce Hill
1 sibling, 0 replies; 14+ messages in thread
From: Bruce Hill @ 2013-02-22 21:44 UTC (permalink / raw
To: gentoo-user
On Fri, Feb 22, 2013 at 11:27:45AM +0100, Joerg Schilling wrote:
>
> Well, it seemt that you are confusing user-interfaces with kernel-internal-interfaces :-(
>
> I was of course writing about a kernel <-> user interface that need to stay
> stable as the problem has been identified with cdrtools and cdrtools are known to run
> in user space.
>
> It seems however, that you have similar problems as Linus. Linus believes that
> user level code is not allowed to include include files from the kernel that
> describe kernel <-> user interfaces. With this rule, he disallows kernel <-> user
> interfaces to be used at all - which looks really strange.
>
> Jörg
Really, Jörgy, you should just forgive Linus and move on. He forked you out of
the kernel equation almost a decade ago. ;)
--
Happy Penguin Computers >')
126 Fenco Drive ( \
Tupelo, MS 38801 ^^
support@happypenguincomputers.com
662-269-2706 662-205-6424
http://happypenguincomputers.com/
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
Don't top-post: http://en.wikipedia.org/wiki/Top_post#Top-posting
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-22 10:27 ` Joerg Schilling
2013-02-22 21:44 ` Bruce Hill
@ 2013-02-22 21:45 ` Bruce Hill
1 sibling, 0 replies; 14+ messages in thread
From: Bruce Hill @ 2013-02-22 21:45 UTC (permalink / raw
To: gentoo-user
On Fri, Feb 22, 2013 at 11:27:45AM +0100, Joerg Schilling wrote:
>
> Well, it seemt that you are confusing user-interfaces with kernel-internal-interfaces :-(
>
> I was of course writing about a kernel <-> user interface that need to stay
> stable as the problem has been identified with cdrtools and cdrtools are known to run
> in user space.
>
> It seems however, that you have similar problems as Linus. Linus believes that
> user level code is not allowed to include include files from the kernel that
> describe kernel <-> user interfaces. With this rule, he disallows kernel <-> user
> interfaces to be used at all - which looks really strange.
>
> Jörg
P.S. Credit to Jens Axbode for taking care when Jörg wouldn't play by the
Linux kernel rules, also.
Now move along, Slowaris fanboi. ;)
--
Happy Penguin Computers >')
126 Fenco Drive ( \
Tupelo, MS 38801 ^^
support@happypenguincomputers.com
662-269-2706 662-205-6424
http://happypenguincomputers.com/
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?
Don't top-post: http://en.wikipedia.org/wiki/Top_post#Top-posting
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules
2013-02-20 13:40 [gentoo-user] ["PATCH"] Linus breaks virtualbox-modules walt
` (2 preceding siblings ...)
2013-02-20 20:57 ` Mike Gilbert
@ 2013-02-21 8:30 ` Helmut Jarausch
3 siblings, 0 replies; 14+ messages in thread
From: Helmut Jarausch @ 2013-02-21 8:30 UTC (permalink / raw
To: gentoo-user
On 02/20/2013 02:40:16 PM, walt wrote:
> Now that kernel 3.8.0 is officially released, 'tis the season for
> Linus to
> start breaking all of the third-party kernel modules he can, and
> virtualbox-
> modules is the first (nvidia.ko and other kernel modules to follow,
> probably ;)
>
> Virtualbox-modules fails to build against today's kernel.git update
> from Linus,
> with an error message that "MAX_PRIO is undefined" in
> thread2-r0drv-linux.c.
>
> The fix is happily very simple because he moved the definition of
> MAX_PRIO
> into <linux/init_task.h>, so all you need to do is to add that
> include near
> the top of thread2-r0drv-linux.c.
>
Strange, but that doesn't happen for me.
I have vanilla 3.8.0 here and virtualbox-modules-4.2.6 builds just fine.
Am I special?
Helmut.
^ permalink raw reply [flat|nested] 14+ messages in thread