From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 9ED51138BD3 for ; Tue, 4 Nov 2014 13:39:33 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 14F5EE0897; Tue, 4 Nov 2014 13:39:26 +0000 (UTC) Received: from mail-yh0-f52.google.com (mail-yh0-f52.google.com [209.85.213.52]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id A8A28E086E for ; Tue, 4 Nov 2014 13:39:24 +0000 (UTC) Received: by mail-yh0-f52.google.com with SMTP id v1so2440842yhn.11 for ; Tue, 04 Nov 2014 05:39:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=nKRJg94RPzpNWgeZalo0PYt96aO4BkfVg3D5R88uRxg=; b=aOSHMvqCIuq7pMaB6oXcON8F8LBQoEn9XdcZHOkdO4tPEofJmploIpSfB217RyTdIT hdUcOehWQcJQTCiTmPodmoO84yS8vxNQyvT7Hed8SpYwEvYh9LF8w9/MdghEpn0eCaMr HmU+I4TU6HVMr1ehIp+5ahsxw0aVBsidvp8W/YoFu8s4Z7X+xpJEU+ScsrO+6FAdBzS5 Ea6cUBA4bOomxD26MvXXNPbFKNIPck9aPIIpcfdPmtVZ1sYhggNCyAgBb0gI6s0ogdxT eqMa3nceHX/p/4ZJLcDmB33jKWcuwO1gxyQYhwLU8g/tMipt1V0OyNW7VS6/axCQka9C 9rRw== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-user@lists.gentoo.org Reply-to: gentoo-user@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.236.1.228 with SMTP id 64mr34536646yhd.51.1415108363577; Tue, 04 Nov 2014 05:39:23 -0800 (PST) Received: by 10.170.37.130 with HTTP; Tue, 4 Nov 2014 05:39:23 -0800 (PST) In-Reply-To: <5458D341.8050206@alectenharmsel.com> References: <5458D341.8050206@alectenharmsel.com> Date: Tue, 4 Nov 2014 10:39:23 -0300 Message-ID: Subject: Re: [gentoo-user] terminal spreadsheet - sc fork From: =?UTF-8?Q?Andr=C3=A9s_Martinelli?= To: gentoo-user@lists.gentoo.org Content-Type: multipart/alternative; boundary=089e0112cec2547843050708979a X-Archives-Salt: 1f25f42b-db28-4ed7-a963-0065f5888955 X-Archives-Hash: b6f5e355f1b5d2a1b12a6834053c906f --089e0112cec2547843050708979a Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hello! Please feel free to modify the Makefile and open a pull request! What you mention about return values not checked, I believe they are part of sc, but please specify them if you can, since there's still a lot of sc for modify. Thanks! Andr=C3=A9s M. 2014-11-04 10:23 GMT-03:00 Alec Ten Harmsel : > > On 11/02/2014 06:16 PM, Andr=C3=A9s Martinelli wrote: > > Hello there!! > > I am working on a terminal spreadsheet based on "sc", but with some > > adds like undo/redo.. > > you can find it here: > > > > https://github.com/andmarti1424/scim > > > > Any new ideas and/or contribution is always welcome! > > Thanks! > > > > -- > > Andr=C3=A9s M. > > If I can offer some constructive criticism based on my short experience > helping Walter: > > * Your build process could use some work; you shouldn't be hard-coding > variable values like LN and CC in a Makefile, these are handled by make. > Your Makefile could be shortened by ~150 lines by relying on built-in > rules and using some built-in make expressions to list your source files > as well. > * A bunch of your .c or .h files are marked as executable... why? > * No install command. Not really a huge deal as only one important file > is produced (src/scim), but would be nice to have > > If you're unfamiliar with make and have no immediate plans to switch to > either the autotools or cmake, I would be more than willing to make some > changes to your Makefile and open a pull request. If you would like to > email me personally with questions about make, feel free to do that as > well. > > There are a couple things I saw in the code as well: > > * system("echo -n 'Press enter to return.'") > * Lot of ignored return values on functions that you should check, like > write() and fgets() > > If these were in the sc code and you know about them but just haven't > gotten to fixing them yet, no worries. > > Alec > > --=20 Andr=C3=A9s Martinelli --089e0112cec2547843050708979a Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hello! Please feel free to modify the Makefile and open a = pull request!
What you mention about return values not checked, I believ= e they are part of sc, but
please specify them if you can, since there&#= 39;s still a lot of sc for modify.
Thanks!

Andr=C3=A9s M.

2014-11-04 10:2= 3 GMT-03:00 Alec Ten Harmsel <alec@alectenharmsel.com>= :

On 11/02/2014 06:16 PM, Andr=C3=A9s Martinelli wrote:
> Hello there!!
> I am working on a terminal spreadsheet based on "sc", but wi= th some
> adds like undo/redo..
> you can find it here:
>
> htt= ps://github.com/andmarti1424/scim
>
> Any new ideas and/or contribution is always welcome!
> Thanks!
>
> --
> Andr=C3=A9s M.

If I can offer some constructive criticism based on my short experience
helping Walter:

* Your build process could use some work; you shouldn't be hard-coding<= br> variable values like LN and CC in a Makefile, these are handled by make. Your Makefile could be shortened by ~150 lines by relying on built-in
rules and using some built-in make expressions to list your source files as well.
* A bunch of your .c or .h files are marked as executable... why?
* No install command. Not really a huge deal as only one important file
is produced (src/scim), but would be nice to have

If you're unfamiliar with make and have no immediate plans to switch to=
either the autotools or cmake, I would be more than willing to make some changes to your Makefile and open a pull request. If you would like to
email me personally with questions about make, feel free to do that as well= .

There are a couple things I saw in the code as well:

* system("echo -n 'Press enter to return.'")
* Lot of ignored return values on functions that you should check, like
write() and fgets()

If these were in the sc code and you know about them but just haven't gotten to fixing them yet, no worries.

Alec




--
Andr=C3=A9s Martinelli
--089e0112cec2547843050708979a--