From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id D56A8138330 for ; Sat, 27 Aug 2016 00:25:32 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 10EE6E0B57; Sat, 27 Aug 2016 00:25:26 +0000 (UTC) Received: from limerock04.mail.cornell.edu (limerock04.mail.cornell.edu [128.84.13.244]) by pigeon.gentoo.org (Postfix) with ESMTP id AF32EE0B2A for ; Sat, 27 Aug 2016 00:25:24 +0000 (UTC) X-CornellRouted: This message has been Routed already. Received: from exchange.cornell.edu (sf-e2013-10.exchange.cornell.edu [10.22.40.57]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id u7R0PMAT021320 for ; Fri, 26 Aug 2016 20:25:23 -0400 Received: from sf-e2013-06.exchange.cornell.edu (10.22.40.53) by sf-e2013-10.exchange.cornell.edu (10.22.40.57) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Fri, 26 Aug 2016 20:25:22 -0400 Received: from mail-ua0-f198.google.com (209.85.217.198) by exchange.cornell.edu (10.22.40.53) with Microsoft SMTP Server (TLS) id 15.0.1130.7 via Frontend Transport; Fri, 26 Aug 2016 20:25:22 -0400 Received: by mail-ua0-f198.google.com with SMTP id 65so185317727uay.1 for ; Fri, 26 Aug 2016 17:25:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=moiWr8nn41u0WMSpVVZk5alQqugu0cOxgVizQVBiEBk=; b=SC42KGpXnkLpBhH3M1jZiRQXHgJgrHnKJdUPp8XFHtrNdERcrUGHSA55i/Zh3o/1Ra mbs6xWScT61YfzeD/1jaqN0xugOGCJBvdagXHYUf2FmLGldRABTKIZfVJtowQKbB6x/p zYLQuc/lOH+ZFkgzhRuuRG0vMIueIbHgj7KvV5YFa1CKooBwN4Q38+hT/PZ0nNE6gtWC oQsKTatNxzkS0KwXGzeN39x/XUrr71xjgMgupGwck8W5MeTRKNxnvti+ToWaVQQ15dI/ uPCIHBj9hCPxDAq7Cc4lzOELc6Kz1nTVhT1tD370rxRgHsIz8GxSQ/aCG6wCPYE1QGcx bWZQ== X-Gm-Message-State: AE9vXwNpG2voSpiIHrZHtsrAd7kem505Is6op4La4HVq4ayc4uUoFttgyUclmnSgw4GEKwg0ncU+CT7S0JekLdAxEIxOe4OajvJn0tkdaJwFa8ltrOG20pBfS09DfsKHg2wllq/Sg2Np4ip98OLL48jwl3/C5km+qHYL0Y3KNdVH87A= X-Received: by 10.55.10.6 with SMTP id 6mr6267095qkk.164.1472257521972; Fri, 26 Aug 2016 17:25:21 -0700 (PDT) X-Received: by 10.55.10.6 with SMTP id 6mr6267049qkk.164.1472257520819; Fri, 26 Aug 2016 17:25:20 -0700 (PDT) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-user@lists.gentoo.org Reply-to: gentoo-user@lists.gentoo.org MIME-Version: 1.0 Received: by 10.237.57.201 with HTTP; Fri, 26 Aug 2016 17:25:20 -0700 (PDT) From: Devrin Talen Date: Fri, 26 Aug 2016 20:25:20 -0400 Message-ID: Subject: [gentoo-user] Tablet rotation button broken in <=sys-apps/systemd-226-r2 To: Content-Type: multipart/mixed; boundary="001a114d873e8c331f053b02aaba" Received-SPF: Neutral (sf-e2013-10.exchange.cornell.edu: 209.85.217.198 is neither permitted nor denied by domain of dct23@cornell.edu) X-ORG-HybridRouting: d3ae28e4a0c76efde78d5ce1b0111f83 X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-Archives-Salt: 57cee377-fbce-44c8-9143-6cd66fd0068b X-Archives-Hash: 675ff6046c829c830e8af8228780670e --001a114d873e8c331f053b02aaba Content-Type: multipart/alternative; boundary="001a114d873e8c331a053b02aab8" --001a114d873e8c331a053b02aab8 Content-Type: text/plain; charset="UTF-8" Hey all, I noticed recently that the screen rotation button on my Lenovo X201T tablet was no longer working, whereas it had been working some time ago. Long story short, there was a change around version 226 of systemd that broke this. I wanted to document how I got it working again and send it out in case it helps anyone else. This issue on Github [1] explains the problem and the patch that fixes it: [1]: https://github.com/systemd/systemd/issues/1151 Rather than unmask a newer version of systemd I decided to try applying the pull request to the current stable version in gentoo, which is systemd-226-r2. I created /etc/portage/patches/sys-apps/systemd and saved the patch from the PR (cleaned up for 226-r2 and attached) there. I then rebuilt systemd, rebooted, and - voila - the rotate button is working again. So (as root): # mkdir -p /etc/portage/patches/sys-apps/systemd # then copy the patch here # emerge --oneshot sys-apps/systemd That took a fair amount of googling around to root cause since I had no idea where to begin, but ended up being a pretty simple fix. When a newer version of systemd gets stabilized I'll probably be able to drop that patch. I do have a question though for anyone that can explain it: in the patchfile I ended up putting in /etc/portage/patches I had to delete the first slash in the filenames. So for instance lines 27-31 of the patchfile that works are this: diff --git a/Makefile.am b/Makefile.am index 8646e55..e3e07b8 100644 --- Makefile.am +++ Makefile.am But in the raw git diff they were: diff --git a/Makefile.am b/Makefile.am index 8646e55..e3e07b8 100644 --- a/Makefile.am +++ b/Makefile.am If I don't delete those prefixes then portage complains when applying the patch: ERROR: prepare Failed Patch: fix-keymap-aliases.patch ! ( /etc/portage/patches//sys-apps/systemd/fix-keymap-aliases.patch ) But existing patches in the /usr/portage/sys-apps/systemd/files directory have the a/ and b/ prefixes. So what gives? Thanks, Devrin --001a114d873e8c331a053b02aab8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hey all,=

I noticed recently that the screen rotation button on my Lenovo X20= 1T tablet was no longer working, whereas it had been working some time ago.= =C2=A0 Long story short, there was a change around version 226 of systemd t= hat broke this.=C2=A0 I wanted to document how I got it working again and s= end it out in case it helps anyone else.

This issue on Github [1] ex= plains the problem and the patch that fixes it:

[1]: https://github.com/systemd/syst= emd/issues/1151

Rather than unmask a newer version of systemd I = decided to try applying the pull request to the current stable version in g= entoo, which is systemd-226-r2.=C2=A0 I created /etc/portage/patches/sys-ap= ps/systemd and saved the patch from the PR (cleaned up for 226-r2 and attac= hed) there.=C2=A0 I then rebuilt systemd, rebooted, and - voila - the rotat= e button is working again.

So (as root):

=C2=A0= =C2=A0=C2=A0 # mkdir -p /etc/portage/patches/sys-apps/systemd # then copy t= he patch here
=C2=A0=C2=A0=C2=A0 # emerge --oneshot sys-apps/syste= md

That took a fair amount of googling around to root cause si= nce I had no idea where to begin, but ended up being a pretty simple fix.= =C2=A0 When a newer version of systemd gets stabilized I'll probably be= able to drop that patch.

I do have a question though for anyo= ne that can explain it: in the patchfile I ended up putting in /etc/portage= /patches I had to delete the first slash in the filenames.=C2=A0 So for ins= tance lines 27-31 of the patchfile that works are this:

=C2=A0=C2=A0= =C2=A0 diff --git a/Makefile.am b/Makefile.am
=C2=A0=C2=A0=C2=A0 index 8= 646e55..e3e07b8 100644
=C2=A0=C2=A0=C2=A0 --- Makefile.am
=C2=A0=C2= =A0=C2=A0 +++ Makefile.am

But in the raw git diff they were:
=C2=A0=C2=A0=C2=A0 diff --git a/Makefile.am b/Makefile.am
=C2=A0= =C2=A0=C2=A0 index 8646e55..e3e07b8 100644
=C2=A0=C2=A0=C2=A0 --- a/Make= file.am
=C2=A0=C2=A0=C2=A0 +++ b/Makefile.am

If I don't= delete those prefixes then portage complains when applying the patch:
<= br>=C2=A0=C2=A0=C2=A0 ERROR: prepare
=C2=A0=C2=A0=C2=A0 Failed Patch: fi= x-keymap-aliases.patch !
=C2=A0 =C2=A0=C2=A0 ( /etc/portage/patches//sys= -apps/systemd/fix-keymap-aliases.patch )

But existing patches = in the /usr/portage/sys-apps/systemd/files directory have the a/ and b/ pre= fixes.=C2=A0 So what gives?

Thanks,
Devrin
--001a114d873e8c331a053b02aab8-- --001a114d873e8c331f053b02aaba Content-Type: text/x-patch; charset="UTF-8"; name="fix-keymap-aliases.patch" Content-Disposition: attachment; filename="fix-keymap-aliases.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_iscg3y8l0 RnJvbSA0YzE0ODIyMDI5NTc4MjhhMzdlODhlNDJjNDllOWFjOGVmMTJjOTYwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUGl0dCA8bWFydGluLnBpdHRAdWJ1bnR1LmNvbT4K RGF0ZTogVHVlLCAxMyBPY3QgMjAxNSAxODoyMDozNCArMDIwMApTdWJqZWN0OiBbUEFUQ0ggMS8z XSBrZXltYXA6IFJlY29nbml6ZSBLRVlfKiBhbGlhc2VzCk1JTUUtVmVyc2lvbjogMS4wCkNvbnRl bnQtVHlwZTogdGV4dC9wbGFpbjsgY2hhcnNldD1VVEYtOApDb250ZW50LVRyYW5zZmVyLUVuY29k aW5nOiA4Yml0CgpsaW51eC9pbnB1dC5oIGNvbnRhaW5zIGFsaWFzIGRlZmluaXRpb25zIGxpa2UK CiAgI2RlZmluZSBLRVlfQ09GRkVFICAgICAgICAgICAgICAxNTIKICAjZGVmaW5lIEtFWV9TQ1JF RU5MT0NLICAgICAgICAgIEtFWV9DT0ZGRUUKICAjZGVmaW5lIEtFWV9ST1RBVEVfRElTUExBWSAg ICAgIDE1MwogICNkZWZpbmUgS0VZX0RJUkVDVElPTiAgICAgICAgICAgS0VZX1JPVEFURV9ESVNQ TEFZCgpCdXQgd2UgaWdub3JlZCB0aGVzZSB3aGVuIGJ1aWxkaW5nIGtleWJvYXJkLWtleXMtbGlz dC50eHQuIEFsc28gYWxsb3cgdGhlIHZhbHVlCnRvIHN0YXJ0IHdpdGggIksiIG5vdyAoZm9yIEtF WV8qKSwgYW5kIGRyb3AgdGhlIGhhcmRjb2RlZCBDT0ZGRUUg4oaSICBTQ1JFRU5MT0NLCmFsaWFz aW5nLgoKVGhpcyBmaXhlcyBhc3NpZ25tZW50cyB0byBrZXkgImRpcmVjdGlvbiIuCgpGaXhlcyAj MTE1MQotLS0KIE1ha2VmaWxlLmFtIHwgMiArLQogMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvTWFrZWZpbGUuYW0gYi9NYWtlZmlsZS5h bQppbmRleCA4NjQ2ZTU1Li5lM2UwN2I4IDEwMDY0NAotLS0gTWFrZWZpbGUuYW0KKysrIE1ha2Vm aWxlLmFtCkBAIC0zNDgzLDcgKzM0ODMsNyBAQCBub2luc3RfTFRMSUJSQVJJRVMgKz0gXAogCiBz cmMvdWRldi9rZXlib2FyZC1rZXlzLWxpc3QudHh0OgogCSQoQU1fVl9hdCkkKE1LRElSX1ApICQo ZGlyICRAKQotCSQoQU1fVl9HRU4pJChDUFApICQoQ0ZMQUdTKSAkKEFNX0NQUEZMQUdTKSAkKENQ UEZMQUdTKSAtZE0gLWluY2x1ZGUgbGludXgvaW5wdXQuaCAtIDwgL2Rldi9udWxsIHwgJChBV0sp ICcvXiNkZWZpbmVbIFx0XStLRVlfW14gXStbIFx0XStbMC05XS8geyBpZiAoJCQyICE9ICJLRVlf TUFYIikgeyBwcmludCAkJDIgfSB9JyB8IHNlZCAncy9eS0VZX0NPRkZFRSQkL0tFWV9TQ1JFRU5M T0NLLycgPiAkQAorCSQoQU1fVl9HRU4pJChDUFApICQoQ0ZMQUdTKSAkKEFNX0NQUEZMQUdTKSAk KENQUEZMQUdTKSAtZE0gLWluY2x1ZGUgbGludXgvaW5wdXQuaCAtIDwgL2Rldi9udWxsIHwgJChB V0spICcvXiNkZWZpbmVbIFx0XStLRVlfW14gXStbIFx0XStbMC05S10vIHsgaWYgKCQkMiAhPSAi S0VZX01BWCIpIHsgcHJpbnQgJCQyIH0gfScgPiAkQAogCiBzcmMvdWRldi9rZXlib2FyZC1rZXlz LWZyb20tbmFtZS5ncGVyZjogc3JjL3VkZXYva2V5Ym9hcmQta2V5cy1saXN0LnR4dAogCSQoQU1f Vl9HRU4pJChBV0spICdCRUdJTnsgcHJpbnQgInN0cnVjdCBrZXkgeyBjb25zdCBjaGFyKiBuYW1l OyB1bnNpZ25lZCBzaG9ydCBpZDsgfTsiOyBwcmludCAiJW51bGwtc3RyaW5ncyI7IHByaW50ICIl JSI7fSB7IHByaW50IHRvbG93ZXIoc3Vic3RyKCQkMSAsNSkpICIsICIgJCQxIH0nIDwgJDwgPiAk QAoKRnJvbSAxZDNmOGZhNzQ3YjcxZGI2MDg3MmJjMjFkZjViNjQ4OWI3M2I3NDBkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gUGl0dCA8bWFydGluLnBpdHRAdWJ1bnR1LmNv bT4KRGF0ZTogV2VkLCAxNCBPY3QgMjAxNSAwNjo1Mjo0MSArMDIwMApTdWJqZWN0OiBbUEFUQ0gg My8zXSBrZXltYXA6IERyb3Aga2V5Ym9hcmQta2V5cy10by1uYW1lLmgKCldlIGRvbid0IHVzZSB0 aGF0IGFueXdoZXJlIGFueSBtb3JlLiBXaXRoIHRoZSBpbnRyb2R1Y3Rpb24gb2YgYWxpYXMgbmFt ZXMgaXQKYWxzbyBpcyBub3QgYSBwcm9wZXIgbWFwcGluZyBhbnkgbW9yZSBhcyBzZXZlcmFsIGtl eXMgKGUuIGcuIEtFWV9DT0ZGRUUgYW5kCktFWV9TQ1JFRU5MT0NLKSBoYXZlIHRoZSBzYW1lIG51 bWVyaWNhbCBtYXBwaW5nLgotLS0KIE1ha2VmaWxlLmFtICAgICAgICAgfCA2ICstLS0tLQogc3Jj L3VkZXYvLmdpdGlnbm9yZSB8IDEgLQogMiBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwg NiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9NYWtlZmlsZS5hbSBiL01ha2VmaWxlLmFtCmlu ZGV4IGUzZTA3YjguLjMzNmJhMGEgMTAwNjQ0Ci0tLSBNYWtlZmlsZS5hbQorKysgTWFrZWZpbGUu YW0KQEAgLTEyMjksNyArMTIyOSw3IEBAIEJVSUxUX1NPVVJDRVMgKz0gXAogCSQoZ3BlcmZfZ3Bl cmZfbTRfc291cmNlczotZ3BlcmYuZ3BlcmYubTQ9LWdwZXJmLW51bHN0ci5jKSBcCiAJJChncGVy Zl9ncGVyZl9zb3VyY2VzOi1ncGVyZi5ncGVyZj0tZ3BlcmYuYykgXAogCSQoZ3BlcmZfdHh0X3Nv dXJjZXM6LWxpc3QudHh0PS1mcm9tLW5hbWUuaCkgXAotCSQoZ3BlcmZfdHh0X3NvdXJjZXM6LWxp c3QudHh0PS10by1uYW1lLmgpCisJJChmaWx0ZXItb3V0ICVrZXlib2FyZC1rZXlzLXRvLW5hbWUu aCwkKGdwZXJmX3R4dF9zb3VyY2VzOi1saXN0LnR4dD0tdG8tbmFtZS5oKSkKIAogQ0xFQU5GSUxF UyArPSBcCiAJJChncGVyZl90eHRfc291cmNlczotbGlzdC50eHQ9LWZyb20tbmFtZS5ncGVyZikK QEAgLTM0OTEsOSArMzQ5MSw2IEBAIHNyYy91ZGV2L2tleWJvYXJkLWtleXMtZnJvbS1uYW1lLmdw ZXJmOiBzcmMvdWRldi9rZXlib2FyZC1rZXlzLWxpc3QudHh0CiBzcmMvdWRldi9rZXlib2FyZC1r ZXlzLWZyb20tbmFtZS5oOiBzcmMvdWRldi9rZXlib2FyZC1rZXlzLWZyb20tbmFtZS5ncGVyZgog CSQoQU1fVl9HUEVSRikkKEdQRVJGKSAtTCBBTlNJLUMgLXQgLU4ga2V5Ym9hcmRfbG9va3VwX2tl eSAtSCBoYXNoX2tleV9uYW1lIC1wIC1DIDwgJDwgPiAkQAogCi1zcmMvdWRldi9rZXlib2FyZC1r ZXlzLXRvLW5hbWUuaDogc3JjL3VkZXYva2V5Ym9hcmQta2V5cy1saXN0LnR4dAotCSQoQU1fVl9H RU4pJChBV0spICdCRUdJTnsgcHJpbnQgImNvbnN0IGNoYXIqIGNvbnN0IGtleV9uYW1lc1tLRVlf Q05UXSA9IHsgIn0geyBwcmludCAiWyIgJCQxICJdID0gXCIiICQkMSAiXCIsIiB9IEVORHtwcmlu dCAifTsifScgPCAkPCA+ICRACi0KIGdwZXJmX3R4dF9zb3VyY2VzICs9IFwKIAlzcmMvdWRldi9r ZXlib2FyZC1rZXlzLWxpc3QudHh0CiAKQEAgLTM1MjAsNyArMzUxNyw2IEBAIGxpYnVkZXZfY29y ZV9sYV9TT1VSQ0VTID0gXAogCiBub2Rpc3RfbGlidWRldl9jb3JlX2xhX1NPVVJDRVMgPSBcCiAJ c3JjL3VkZXYva2V5Ym9hcmQta2V5cy1mcm9tLW5hbWUuaCBcCi0Jc3JjL3VkZXYva2V5Ym9hcmQt a2V5cy10by1uYW1lLmggXAogCXNyYy91ZGV2L25ldC9saW5rLWNvbmZpZy1ncGVyZi5jCiAKIGdw ZXJmX2dwZXJmX3NvdXJjZXMgKz0gXApkaWZmIC0tZ2l0IGEvc3JjL3VkZXYvLmdpdGlnbm9yZSBi L3NyYy91ZGV2Ly5naXRpZ25vcmUKaW5kZXggYmExMTJjZS4uZjVkOGJlMyAxMDA2NDQKLS0tIHNy Yy91ZGV2Ly5naXRpZ25vcmUKKysrIHNyYy91ZGV2Ly5naXRpZ25vcmUKQEAgLTEsNSArMSw0IEBA CiAvdWRldi5wYwogL2tleWJvYXJkLWtleXMtZnJvbS1uYW1lLmdwZXJmCiAva2V5Ym9hcmQta2V5 cy1mcm9tLW5hbWUuaAotL2tleWJvYXJkLWtleXMtdG8tbmFtZS5oCiAva2V5Ym9hcmQta2V5cy1s aXN0LnR4dAo= --001a114d873e8c331f053b02aaba--