public inbox for gentoo-user@lists.gentoo.org
 help / color / mirror / Atom feed
From: Grant <emailgrant@gmail.com>
To: gentoo-user@lists.gentoo.org
Subject: Re: [gentoo-user] Re: Patch via perl script in an ebuild?
Date: Thu, 1 Jul 2010 20:43:29 -0700	[thread overview]
Message-ID: <AANLkTil5awkMGhbVylRwCzsNs3V1fOlYXNupocOGV-fQ@mail.gmail.com> (raw)
In-Reply-To: <AANLkTilAXpQFbAXsl_cgvSC_Br73nuvBiswpCI1hiFph@mail.gmail.com>

[snip]

> Am I making any sense?

I think all of that is right on.  I need to find out why the patch
isn't working though.

> Theoretically (if you insist), you could still use the perl's
> Text::Patch route as well, but (if I'm not entirely wrong, see the
> excerpted attempted patch run above) the patch would still need to be
> touched up to match properly with the _3 dev release code. And it
> would add a dependency to Text::Patch, and make an odd call to perl in
> the middle of the ebuild. (I assume it must be made explicitly as I
> don't know if perl-module.eclass has any automation for this. Probably
> not since AFAICT Text::Patch isn't even installed by default).

Do you think it would be better to create a real patch than to use the
perl patch (after we figure out why it isn't working)?  I would think
it would be easier to use the perl patch in case a different version
is released so we don't have to re-create the patch each time.  A
Text::Patch dep wouldn't be so bad.  What do you think?

- Grant



      parent reply	other threads:[~2010-07-02  3:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-30  2:53 [gentoo-user] Patch via perl script in an ebuild? Grant
2010-06-30 18:49 ` [gentoo-user] " Grant
2010-07-01  0:12   ` Arttu V.
2010-07-01 15:36     ` Grant
2010-07-01 18:40       ` Arttu V.
2010-07-01 19:29         ` David Abbott
2010-07-02  3:45           ` Grant
2010-07-02  9:04             ` David Abbott
2010-07-03  0:33               ` Grant
2010-07-03  1:25                 ` David Abbott
2010-07-24 19:33                   ` Grant
2010-07-02 12:15             ` Arttu V.
2010-07-02 14:51               ` David Abbott
2010-07-03  2:15                 ` Grant
2010-07-03  0:37               ` Grant
2010-07-02  3:43         ` Grant [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTil5awkMGhbVylRwCzsNs3V1fOlYXNupocOGV-fQ@mail.gmail.com \
    --to=emailgrant@gmail.com \
    --cc=gentoo-user@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox