From: "Fatih Tümen" <fthtmn+gentoo@gmail.com>
To: gentoo-user@lists.gentoo.org
Subject: Re: [gentoo-user] emerge/python failure
Date: Fri, 15 Oct 2010 19:55:01 +0300 [thread overview]
Message-ID: <AANLkTi=fg=KF9OHKHLebMuEECsLkzSVKPacqFk_61HwU@mail.gmail.com> (raw)
In-Reply-To: <1287160075.21472.3.camel@paska>
On Fri, Oct 15, 2010 at 7:27 PM, Albert Hopkins <marduk@letterboxes.org> wrote:
> On Fri, 2010-10-15 at 07:35 -0700, Mark Knecht wrote:
>> File "/usr/lib64/portage/pym/_emerge/actions.py", line 2134, in
>> action_sync
>> "//" + user_name + ip + port + "/", 1))
>> TypeError: cannot concatenate 'str' and 'int' objects
>
> This is a bug... shuld be more something like:
>
> uris.append(syncuri.replace(
> "//%s%s%s/" % (user_name, hostname, port),
> "//%s%s%s/" % (user_name, ip, port), 1))
>
> Probably needs to be reported.
>
>
>
>
Coding against PEP8 is not a bug. I guess devs find string
concatenation more handy and maintainable.
The bug was about the addrinfos data gotten from the server. I thought
the response of possibly down rsync server was not handled well, which
is why I offered to change rsync server, but the actual problem was
caused by assuming that IPv6 is supported on the machine.
--
Fatih
next prev parent reply other threads:[~2010-10-15 16:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 14:35 [gentoo-user] emerge/python failure Mark Knecht
2010-10-15 15:02 ` Fatih Tümen
2010-10-15 15:52 ` Fatih Tümen
2010-10-15 15:58 ` Mark Knecht
2010-10-15 16:19 ` Fatih Tümen
2010-10-15 17:29 ` Mark Knecht
2010-10-15 17:41 ` Fatih Tümen
2010-10-15 17:45 ` Mark Knecht
2010-10-15 16:27 ` Albert Hopkins
2010-10-15 16:55 ` Fatih Tümen [this message]
2010-10-15 18:19 ` Albert Hopkins
2010-10-15 18:38 ` Fatih Tümen
2010-10-15 16:34 ` Peter Ruskin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=fg=KF9OHKHLebMuEECsLkzSVKPacqFk_61HwU@mail.gmail.com' \
--to=fthtmn+gentoo@gmail.com \
--cc=gentoo-user@lists.gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox