From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id 9C5E915813A for ; Mon, 20 Jan 2025 23:41:21 +0000 (UTC) Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: relay-lists.gentoo.org@gentoo.org) by smtp.gentoo.org (Postfix) with ESMTPSA id 5CA0A342FB5 for ; Mon, 20 Jan 2025 23:41:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 00DBEE0391; Mon, 20 Jan 2025 23:40:27 +0000 (UTC) Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 7BB19E01B5 for ; Mon, 20 Jan 2025 23:40:26 +0000 (UTC) Received: by mail-pj1-x1031.google.com with SMTP id 98e67ed59e1d1-2ee46851b5eso6711918a91.1 for ; Mon, 20 Jan 2025 15:40:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1737416425; x=1738021225; darn=lists.gentoo.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:to:from:from:to:cc:subject:date:message-id:reply-to; bh=WS5BGBaIngm9Xqrx3MuWwjB7Zs5Ntb/DxSFANqpft5I=; b=N+W/Ae/b4IEGnYM8ENgRYWE8S35yIzDWIjp16ZW71UXxC+yio/RWr3Xat0W4S48R8x jrchg9luI77MbHAcO8GvLDzU6H4KwtVXnqMIgYuI/37RaMmfyPbO2Gt6vEj5LmDwqkLK QmiBhCjn2cSdQ0a+/nB9wpKq0U51+SzsqkJHElgiTM4htRtd+Rr+R7XM9Bx79fW+XRxy EJuaA/EqgIq3CIe7tmNx+p8T/wueJDRdhO5CMm/RYHcEte+yxmBZSvIJ4V8GFRdPHx4q quTsz1jyjp/WpY2TLNEUBiFRdvOqZjZQpV96Xtnh+4tgk7dweq7Xb/+uiYiNFflYHdew Zl9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737416425; x=1738021225; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WS5BGBaIngm9Xqrx3MuWwjB7Zs5Ntb/DxSFANqpft5I=; b=jGlHZxx1P45y9bafAmBkB7znu/1LiMDgVZGMQXDFzc93zrH7pP71HVRN5SG1CWGYWb fum6vqUJZZe0ffl9RXhHAgBZpYp2WH8QhiXa0VJD1KGh2jDNtuIk1RT097OHXLMUE8P+ fOPx7QIBe41Rzl9MMvxC6CjYZuCkLfS2mqF+PCHyiONOzIggW7WJVvFdLylPeIeeFyfX ImtR/JPEs5Fvaxbg9iMglbyvEmd1X/9NRjd0N319b0bdmDiQ58HndGjCFYsm7HFpfWnI lAX4NY3ElTa3q8qsLd/qP4Fc74Ml622arv6CL+YSBhO9iThN7FxbAqQfWsb7H27SzP51 wHEg== X-Gm-Message-State: AOJu0Yxhe+pA/OEB5zScUdQrOYnFXDJmV37tSbweikXmjBZ20Ib6CC9I o6gw5WqYYea7BnPVBOC68NmVlkcHfzy1NkDfpdMnbEVZz8L4AoZ6B1KgXw== X-Gm-Gg: ASbGncvo0g4W3ikMs0LsbtMOurlz+o3pkAMkeWh70idWnU0l5H/DrANRt037Xob8hS0 louPAHeeiLCoW4Rk/5bKEbIMLnzdMd+0K2qC10rGk6C8I5Du+O9qGGlGUmcQ5HlBhsOLlDxYvd8 pArUV/kFr1jAE4AcNgFsp2YWNbgSFKXVQgmInmmdH3pZ/QZgjQRKut4Nk2iQqQmiyFA0Z7CoKV4 TFKUQp2c50S0M4J5NDjPHLRzB+il6h8Z3LFaCFsu+pkhfGeEhvlsw6VhW/C/MHP+waL0DFqN+SC i9YY4iTaryhe+5hdOlyGGNLXfVHNh1LKYg== X-Google-Smtp-Source: AGHT+IFboxpKS7Nhpserq67N1SFRhaNaRb/ZC8CrpeoFnzH8+MjF74sjFFaz8Xeifu+UDzIjjKSNMQ== X-Received: by 2002:a17:90b:2b87:b0:2ee:a127:ba96 with SMTP id 98e67ed59e1d1-2f782d36030mr18606768a91.23.1737416425291; Mon, 20 Jan 2025 15:40:25 -0800 (PST) Received: from localhost (pa49-183-157-97.pa.vic.optusnet.com.au. [49.183.157.97]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2f7b011a0casm4994392a91.23.2025.01.20.15.40.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 15:40:24 -0800 (PST) From: Alexis To: gentoo-user@lists.gentoo.org Subject: Re: [gentoo-user] Protecting init.d files from auto-update In-Reply-To: <5874190.DvuYhMxLoT@cube> (Peter Humphrey's message of "Mon, 20 Jan 2025 13:24:20 +0000") References: <2207251.irdbgypaU6@cube> <4cfd0465dba6e50fe3afc3f3aa92fbfc25a31e94.camel@gentoo.org> <2792044.mvXUDI8C0e@cube> <5874190.DvuYhMxLoT@cube> User-Agent: mu4e 1.12.7; emacs 29.4 Date: Tue, 21 Jan 2025 10:40:22 +1100 Message-ID: <87frld2gwp.fsf@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-user@lists.gentoo.org Reply-to: gentoo-user@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Archives-Salt: d07755b0-8201-4346-925c-8d6a93dd1fcb X-Archives-Hash: 64a85fcb0808a18ee2a6128e4462cb7c Peter Humphrey writes: > On Wednesday 15 January 2025 11:50:02 Greenwich Mean Time I > wrote: > >> https://bugs.gentoo.org/948143 > > That bug now has a patch, which proposes to move from > sci-misc/boinc-7.24.1-r1 > to -r2. The scale of the changes proposed seems to me too big > for such > a minor > revision bump, but more than that, it has several diffs against > separate files, > and I'm not /au-fait/ enough with patching to know what to do > with > them all. > > Would anyone here like to have a go at it? Well, as the person who submitted that patch, i'd like to comment on this. As some background: * i've contributed a number of patches, such as to gentoo-pipewire-launcher: https://bugs.gentoo.org/907891 * i currently have a new ebuild for the main repo awaiting additional review from Sam, who hasn't been able to get to it because he's constantly snowed under: https://bugs.gentoo.org/908431 * i maintain a few ebuilds in my overlay: https://sr.ht/~flexibeast/gentoo-overlay/ More generally, i'm a regular contributor to the Gentoo wiki; cf. https://wiki.gentoo.org/wiki/User:Flexibeast#Gentoo_wiki . So: * The move from -r1 to -r2 is required because a revision change is required when there any changes to an ebuild, including to Gentoo-provided files, that don't come from upstream. This in turn requires a new ebuild file, which makes up a significant amount of the patch. * There are small changes to the boinc.conf and boinc.init files, which i consider to be the minimum required to address the suggestions that were made. Specifically: * The changes to boinc.conf remove the custom PID file variable, replacing it with the standard $pidfile variable, and adds the standard $retry variable. * The changes to boinc.init add default values for $pidvalue and $retry in env_check(); change start() to use $pidfile instead of the custom variable; move the call to env_check() into stop_pre(); and change the stop() function to use the $pidfile and $retry variables. (Further to Michael Orlitzky's comment on the bug, it looks to me that the default stop() function doesn't use the $retry variable, so we need to provide a stop() function that does. i'll note this on the bug report shortly.) i find your post here quite odd, discouraging, and an example of why i'm increasingly disinclined to devote so much time to volunteer ICT work, - that i would instead be better served by increasing my other volunteer work in other areas, where my experience is of people's gratitude rather than of entitlement. Rather than being appreciative of someone volunteering to take on the work, and rather than asking clarifying questions on the bug itself about what you don't understand, you've written a post on a public list effectively dismissing my work, assuming that it's fundamentally wrong. Okay then. Alexis.