From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id DFE75138BD3 for ; Tue, 4 Nov 2014 13:23:21 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 26C13E088A; Tue, 4 Nov 2014 13:23:16 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 0F144E085D for ; Tue, 4 Nov 2014 13:23:14 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 64685207AF for ; Tue, 4 Nov 2014 08:23:14 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Tue, 04 Nov 2014 08:23:14 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=x-sasl-enc:message-id:date:from :mime-version:to:subject:references:in-reply-to:content-type :content-transfer-encoding; s=smtpout; bh=n/Rgo0HiuNHUIRZ/Udfn9Z E8fDY=; b=d9RSpUt7x2/CRpqTzjxG5CYDwo2LFUBOAKXnF/0zM86t3EdPrgFqfQ 2lk+VLygMJVKt9/g/8q8p1UnWxJCRGOw9Zw4Uwnh1R/JXpLMAQyIYAqh7YGPLiO5 +yYNTxlkOoMMpJ3CtEpzKB8nJl4QSk1FlHEIEny84a8dOvPyoRuY0= X-Sasl-enc: 7VyBdlHi+PtyjT/Gi4e/7F59I0tf3WyQfKTTswG21tsL 1415107394 Received: from [192.168.1.15] (unknown [73.2.142.203]) by mail.messagingengine.com (Postfix) with ESMTPA id 244C56801BD for ; Tue, 4 Nov 2014 08:23:14 -0500 (EST) Message-ID: <5458D341.8050206@alectenharmsel.com> Date: Tue, 04 Nov 2014 08:23:13 -0500 From: Alec Ten Harmsel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-user@lists.gentoo.org Reply-to: gentoo-user@lists.gentoo.org MIME-Version: 1.0 To: gentoo-user@lists.gentoo.org Subject: Re: [gentoo-user] terminal spreadsheet - sc fork References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Archives-Salt: d5f48ec9-7dc7-4462-b784-9dec8e891a8f X-Archives-Hash: 7f314a81d817984f9b424a5731b24ddb On 11/02/2014 06:16 PM, Andrés Martinelli wrote: > Hello there!! > I am working on a terminal spreadsheet based on "sc", but with some > adds like undo/redo.. > you can find it here: > > https://github.com/andmarti1424/scim > > Any new ideas and/or contribution is always welcome! > Thanks! > > -- > Andrés M. If I can offer some constructive criticism based on my short experience helping Walter: * Your build process could use some work; you shouldn't be hard-coding variable values like LN and CC in a Makefile, these are handled by make. Your Makefile could be shortened by ~150 lines by relying on built-in rules and using some built-in make expressions to list your source files as well. * A bunch of your .c or .h files are marked as executable... why? * No install command. Not really a huge deal as only one important file is produced (src/scim), but would be nice to have If you're unfamiliar with make and have no immediate plans to switch to either the autotools or cmake, I would be more than willing to make some changes to your Makefile and open a pull request. If you would like to email me personally with questions about make, feel free to do that as well. There are a couple things I saw in the code as well: * system("echo -n 'Press enter to return.'") * Lot of ignored return values on functions that you should check, like write() and fgets() If these were in the sc code and you know about them but just haven't gotten to fixing them yet, no worries. Alec