public inbox for gentoo-user@lists.gentoo.org
 help / color / mirror / Atom feed
From: Florian Philipp <lists@binarywings.net>
To: gentoo-user@lists.gentoo.org
Subject: Re: [gentoo-user] Another Install Issue
Date: Mon, 17 Oct 2011 14:39:40 +0200	[thread overview]
Message-ID: <4E9C220C.7090101@binarywings.net> (raw)
In-Reply-To: <20111017123015.6feec5cc@zaphod.digimed.co.uk>

[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]

Am 17.10.2011 13:30, schrieb Neil Bothwick:
> On Mon, 17 Oct 2011 12:19:16 +0100, Mick wrote:
> 
>>> This seems more elegant than a separate init script, but do you want
>>> it to return 0 unconditionally? If the modules fail to load, surely
>>> you want the attempt to bring the interface up to abort?  
>>
>> In my head I find it less elegant to be honest.  Is it up to a network
>> configuration script to load the *kernel* module for the hardware?
> 
> Is it up to an init script to do that either? I'd say no. either way
> seems wrong, but having the network config check that the interface is
> available before trying to bring it up seems somewhat less wrong.
> 
> 

Yes, I intended it to return 0 unconditionally. My reasoning was that
a) trying anyway doesn't hurt.
b) when you change your kernel config or hardware and don't need that
workaround anymore, it is better to have a working network and a warning
rather than no network and an error.
c) for something that is potentially important for the user to get
access to the system, you should try as hard as possible to get it
running before giving up. Of course, this is more important for a
headless server than a desktop but scripts tend to get copied around.

Concerning what is more elegant: no clue. I guess you could even use
udev for this stuff but I don't know the syntax.

One thing that I worry more about is that there might be a race
condition. Maybe after loading the module, some time is necessary for
the interface to appear. I ran into an issue like that while playing
around with the zram module. In such a case, the separate init script
has a higher chance to succeed than a bash function called some
milliseconds before the interface initialization.

Regards,
Florian Philipp


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

  reply	other threads:[~2011-10-17 12:41 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-15 23:05 [gentoo-user] Another Install Issue CJoeB
2011-10-16  9:59 ` Stroller
2011-10-16 13:27   ` CJoeB
2011-10-16 10:05 ` Florian Philipp
2011-10-16 10:18   ` Mick
2011-10-16 22:35     ` Florian Philipp
2011-10-16 22:46       ` Alex Schuster
2011-10-17  6:03         ` Florian Philipp
2011-10-17  8:15       ` Neil Bothwick
2011-10-17 11:19         ` Mick
2011-10-17 11:30           ` Neil Bothwick
2011-10-17 12:39             ` Florian Philipp [this message]
2011-10-17 12:48               ` Neil Bothwick
2011-10-17 12:40       ` J. Roeleveld
2011-10-17 13:09         ` Florian Philipp
2011-10-16 10:43 ` Mick
2011-10-16 12:59   ` Florian Philipp
2011-10-16 15:05     ` CJoeB
2011-10-16 15:29       ` Matthew Finkel
2011-10-16 16:08         ` CJoeB
2011-10-16 17:37           ` Mick
2011-10-16 19:19             ` CJoeB
2011-10-16 20:43               ` Florian Philipp
2011-10-16 14:52   ` CJoeB
2011-10-16 16:02     ` Mick
2011-10-16 21:24       ` Neil Bothwick
2011-10-16 22:03         ` Mick
2011-10-16 22:04         ` CJoeB
2011-10-16 22:23           ` Mick
2011-10-17  0:24             ` CJoeB
2011-10-18 18:31             ` Colleen Beamer
2011-10-18 18:50               ` Mick
2011-10-16 21:23     ` Neil Bothwick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E9C220C.7090101@binarywings.net \
    --to=lists@binarywings.net \
    --cc=gentoo-user@lists.gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox