Re: [gentoo-user] android-notifier

["Stefan G. Weichinger" <lists@xunil.at>]

Am 18.10.2010 19:31, schrieb Justin:
> RDEPEND=""
> DEPEND="${RDEPEND}"
> 
> You can leave this away when empty.

yes, sure, but I want to point out that it should not be empty ...

> get_home() {
> 	echo "/usr/share/android-notifier-desktop"
> }
> 
> Unnecessary.
> 
> src_install() {
> 	dodir "$(get_home)" || die "mkdir failed"
> Not needed, it is included in insinto()
> 	insinto "$(get_home)"
> 	cp -R ${WORKDIR}/android-notifier-desktop/* "$D/$(get_home)" || die
> use doins() instead
> 
> make_wrapper android-notifier ./run.sh "$(get_home)"
> 
> doicon "$D/$(get_home)"/icons/$PN-desktop.png \
> 			|| die "newicon failed"
> 
> make_desktop_entry android-notifier "AndroidNotifier" \
> 	/usr/share/pixmaps/${PN}-desktop.png "Utility" || die
> "make_desktop_entry failed"
> }
> 
> Indent your code.


Thanks for your help, see my current draft at bugzilla.
They point me at sunrise-overlay, will see how to do that ...

Stefan