[gentoo-user] Kino Crashes Opening Files

[gentoo-user] Kino Crashes Opening Files

[dhk]

I originally posted this question to the kino group.  The chain of 
emails is below.

The problem is that kino crashes when opening a file, clicking on a 
folder that has a video file in it, or when passing it in on the command 
line.  I removed and reinstalled kino, but the same thing happens.  I 
compiled the source manually and the problem wasn't there.  Now I think 
it has something to do with the Gentoo environment or the ebuild.

One thing I noticed on my system is that in 
/usr/portage/media-video/kino there are two ebuilds a 1.3.1 and a 1.3.3 
I have 1.3.1 installed. The diffs to these files are as follows.

$ diff kino-1.3.1.ebuild kino-1.3.3.ebuild
1c1
< # Copyright 1999-2008 Gentoo Foundation
---
 > # Copyright 1999-2009 Gentoo Foundation
3c3
< # $Header: 
/var/cvsroot/gentoo-x86/media-video/kino/kino-1.3.1.ebuild,v 1.7 
2008/12/21 14:44:31 nixnut Exp $
---
 > # $Header: 
/var/cvsroot/gentoo-x86/media-video/kino/kino-1.3.3.ebuild,v 1.1 
2009/03/29 13:39:42 patrick Exp $
11c11
< KEYWORDS="amd64 ppc ppc64 sparc x86"
---
 > KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
29a30
 > 	dev-util/intltool

I'm not sure if the 1.3.3 file is causing a problem somehow.

Any ideas?

Thanks,
dhk

Dan Dennedy wrote:
> On Wed, May 13, 2009 at 4:54 AM, dhk <dhkuhl@optonline.net> wrote:
>> Dan Dennedy wrote:
>>> On Tue, May 12, 2009 at 3:08 AM, dhk <dhkuhl@optonline.net> wrote:
>>>> dhk wrote:
>>>>> Carl Karsten wrote:
>>>>>> On Sat, May 9, 2009 at 5:27 AM, dhk <dhkuhl@optonline.net> wrote:
>>>>>>> I don't edit video very often so I don't know exactly when this
>>>>>>> problem
>>>>>>> started.
>>>>>>>
>>>>>>> Whenever I try to open a file kino crashes.  It starts fine, but as
>>>>>>> soon
>>>>>>> as I try to open a .kino, .dv and other type files it crashes.  When
>>>>>>> I'm
>>>>>>> in the kino gui the crash occurs when I click on the folder that has
>>>>>>> the
>>>>>>> .kino file.  On the command line it crashes when I pass the file in as
>>>>>>> a
>>>>>>> parameter.
>>> More than likely the libdv or libavcodec libraries changed somehow and
>>> Kino needs to be rebuilt. If you are going to rebuild it, see if there
>>> is a v1.3.3, the latest release, available - it will clear up many of
>>> those GTK+ warnings.
>>>
>>>>>> post the command line and resulting output.
>>>>>>
>>> [...]
>>>>> /Video/Capture/MomAndDad50thAnniversary $ kino take1.kino
>>> [...]
>>>>> Kino experienced a segmentation fault.
>>> $ gdb kino
>>> (gdb) run take1.kino
>>> ...segfault
>>> (gdb) where
>>>
>>> send the output.
>>>
>> I think the problem is in the environment or setup somewhere.  I don't have
>> the answer, but I think I'm getting closer.  So please bear with me as I
>> explain.
>>
>> First)  This is kino version 1.3.1 I'm working with.  There isn't any
>> libavcodec package in the portage tree as far as I've seen, but there is a
>> libavc1394 version 0.5.3. The highest version of lbdv is 1.0.0-r2.
> 
> I do not know the gentoo package names; libavcodec is a part of FFmeg.
> 
> $ ldd $(which kino)
> and see if it is linked to a libavcodec
> 
>> Second)  I tried compiling the source so I could run the program through the
>> gdb debugger.  When I ran the program without gdb it runs fine, but the same
>> problem exists with the crashing.  However, when running the program through
>> gdb it SIGSEGV because it can't find the magick.glade and kino.glade file.
>>  The program was looking for them in /usr/local/share/kino/ and that path
>> and the file don't exist.
> 
> You have to install it to put resources in the expected location.
> 
>> Third) Then I did a make clean and ran configure with my own --prefix and
>> copied the two .glade file to that location.  I redid the steps above
>> running kino with and without gdb and to my surprise everything worked.
>>  Except for some missing icons , which is understandable since I change the
>> --prefix, everything I tested was functional.  I could open files and play
>> them.
> 
> Like I said, Kino needed to be rebuilt for some reason or another. Or,
> something special about the gentoo build is triggering a bug.
> 
>> So now is the problem with the way kino is getting installed on Gentoo amd64
>> or am I picking up older files from previous versions that don't work?  Any
>> ideas?  I think we're getting closer?
> 
> Remove it entirely, re-emerge it. If the problem remains, file a bug
> with gentoo. If there is a patch that belongs upstream, someone should
> attach it to the Kino SourceForge tracker. Kino is no longer actively
> maintained, so someone needs to step up if they need it to work for
> them because no one else is going out of there way to resolve issues
> for various environments.
> 

Re: [gentoo-user] Kino Crashes Opening Files

[Saphirus Sage]

dhk wrote:
> I originally posted this question to the kino group.  The chain of
> emails is below.
>
> The problem is that kino crashes when opening a file, clicking on a
> folder that has a video file in it, or when passing it in on the
> command line.  I removed and reinstalled kino, but the same thing
> happens.  I compiled the source manually and the problem wasn't
> there.  Now I think it has something to do with the Gentoo environment
> or the ebuild.
>
> One thing I noticed on my system is that in
> /usr/portage/media-video/kino there are two ebuilds a 1.3.1 and a
> 1.3.3 I have 1.3.1 installed. The diffs to these files are as follows.
>
> $ diff kino-1.3.1.ebuild kino-1.3.3.ebuild
> 1c1
> < # Copyright 1999-2008 Gentoo Foundation
> ---
> > # Copyright 1999-2009 Gentoo Foundation
> 3c3
> < # $Header:
> /var/cvsroot/gentoo-x86/media-video/kino/kino-1.3.1.ebuild,v 1.7
> 2008/12/21 14:44:31 nixnut Exp $
> ---
> > # $Header:
> /var/cvsroot/gentoo-x86/media-video/kino/kino-1.3.3.ebuild,v 1.1
> 2009/03/29 13:39:42 patrick Exp $
> 11c11
> < KEYWORDS="amd64 ppc ppc64 sparc x86"
> ---
> > KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
> 29a30
> >     dev-util/intltool
>
> I'm not sure if the 1.3.3 file is causing a problem somehow.
>
> Any ideas?
>
> Thanks,
> dhk
>
> Dan Dennedy wrote:
>> On Wed, May 13, 2009 at 4:54 AM, dhk <dhkuhl@optonline.net> wrote:
>>> Dan Dennedy wrote:
>>>> On Tue, May 12, 2009 at 3:08 AM, dhk <dhkuhl@optonline.net> wrote:
>>>>> dhk wrote:
>>>>>> Carl Karsten wrote:
>>>>>>> On Sat, May 9, 2009 at 5:27 AM, dhk <dhkuhl@optonline.net> wrote:
>>>>>>>> I don't edit video very often so I don't know exactly when this
>>>>>>>> problem
>>>>>>>> started.
>>>>>>>>
>>>>>>>> Whenever I try to open a file kino crashes.  It starts fine,
>>>>>>>> but as
>>>>>>>> soon
>>>>>>>> as I try to open a .kino, .dv and other type files it crashes. 
>>>>>>>> When
>>>>>>>> I'm
>>>>>>>> in the kino gui the crash occurs when I click on the folder
>>>>>>>> that has
>>>>>>>> the
>>>>>>>> .kino file.  On the command line it crashes when I pass the
>>>>>>>> file in as
>>>>>>>> a
>>>>>>>> parameter.
>>>> More than likely the libdv or libavcodec libraries changed somehow and
>>>> Kino needs to be rebuilt. If you are going to rebuild it, see if there
>>>> is a v1.3.3, the latest release, available - it will clear up many of
>>>> those GTK+ warnings.
>>>>
>>>>>>> post the command line and resulting output.
>>>>>>>
>>>> [...]
>>>>>> /Video/Capture/MomAndDad50thAnniversary $ kino take1.kino
>>>> [...]
>>>>>> Kino experienced a segmentation fault.
>>>> $ gdb kino
>>>> (gdb) run take1.kino
>>>> ...segfault
>>>> (gdb) where
>>>>
>>>> send the output.
>>>>
>>> I think the problem is in the environment or setup somewhere.  I
>>> don't have
>>> the answer, but I think I'm getting closer.  So please bear with me
>>> as I
>>> explain.
>>>
>>> First)  This is kino version 1.3.1 I'm working with.  There isn't any
>>> libavcodec package in the portage tree as far as I've seen, but
>>> there is a
>>> libavc1394 version 0.5.3. The highest version of lbdv is 1.0.0-r2.
>>
>> I do not know the gentoo package names; libavcodec is a part of FFmeg.
>>
>> $ ldd $(which kino)
>> and see if it is linked to a libavcodec
>>
>>> Second)  I tried compiling the source so I could run the program
>>> through the
>>> gdb debugger.  When I ran the program without gdb it runs fine, but
>>> the same
>>> problem exists with the crashing.  However, when running the program
>>> through
>>> gdb it SIGSEGV because it can't find the magick.glade and kino.glade
>>> file.
>>>  The program was looking for them in /usr/local/share/kino/ and that
>>> path
>>> and the file don't exist.
>>
>> You have to install it to put resources in the expected location.
>>
>>> Third) Then I did a make clean and ran configure with my own
>>> --prefix and
>>> copied the two .glade file to that location.  I redid the steps above
>>> running kino with and without gdb and to my surprise everything worked.
>>>  Except for some missing icons , which is understandable since I
>>> change the
>>> --prefix, everything I tested was functional.  I could open files
>>> and play
>>> them.
>>
>> Like I said, Kino needed to be rebuilt for some reason or another. Or,
>> something special about the gentoo build is triggering a bug.
>>
>>> So now is the problem with the way kino is getting installed on
>>> Gentoo amd64
>>> or am I picking up older files from previous versions that don't
>>> work?  Any
>>> ideas?  I think we're getting closer?
>>
>> Remove it entirely, re-emerge it. If the problem remains, file a bug
>> with gentoo. If there is a patch that belongs upstream, someone should
>> attach it to the Kino SourceForge tracker. Kino is no longer actively
>> maintained, so someone needs to step up if they need it to work for
>> them because no one else is going out of there way to resolve issues
>> for various environments.
>>
>
>
I've only been using Kino for a short time, but 1.3.3 has been perfectly
find on my amd64 system. Consider unmasking it and installing that
version, see if that gets around whatever the problem is.

Re: [gentoo-user] Kino Crashes Opening Files

[dhk]

Saphirus Sage wrote:
> dhk wrote:
>> I originally posted this question to the kino group.  The chain of
>> emails is below.
>>
>> The problem is that kino crashes when opening a file, clicking on a
>> folder that has a video file in it, or when passing it in on the
>> command line.  I removed and reinstalled kino, but the same thing
>> happens.  I compiled the source manually and the problem wasn't
>> there.  Now I think it has something to do with the Gentoo environment
>> or the ebuild.
>>
>> One thing I noticed on my system is that in
>> /usr/portage/media-video/kino there are two ebuilds a 1.3.1 and a
>> 1.3.3 I have 1.3.1 installed. The diffs to these files are as follows.
>>
>> $ diff kino-1.3.1.ebuild kino-1.3.3.ebuild
>> 1c1
>> < # Copyright 1999-2008 Gentoo Foundation
>> ---
>>> # Copyright 1999-2009 Gentoo Foundation
>> 3c3
>> < # $Header:
>> /var/cvsroot/gentoo-x86/media-video/kino/kino-1.3.1.ebuild,v 1.7
>> 2008/12/21 14:44:31 nixnut Exp $
>> ---
>>> # $Header:
>> /var/cvsroot/gentoo-x86/media-video/kino/kino-1.3.3.ebuild,v 1.1
>> 2009/03/29 13:39:42 patrick Exp $
>> 11c11
>> < KEYWORDS="amd64 ppc ppc64 sparc x86"
>> ---
>>> KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
>> 29a30
>>>     dev-util/intltool
>> I'm not sure if the 1.3.3 file is causing a problem somehow.
>>
>> Any ideas?
>>
>> Thanks,
>> dhk
>>
>> Dan Dennedy wrote:
>>> On Wed, May 13, 2009 at 4:54 AM, dhk <dhkuhl@optonline.net> wrote:
>>>> Dan Dennedy wrote:
>>>>> On Tue, May 12, 2009 at 3:08 AM, dhk <dhkuhl@optonline.net> wrote:
>>>>>> dhk wrote:
>>>>>>> Carl Karsten wrote:
>>>>>>>> On Sat, May 9, 2009 at 5:27 AM, dhk <dhkuhl@optonline.net> wrote:
>>>>>>>>> I don't edit video very often so I don't know exactly when this
>>>>>>>>> problem
>>>>>>>>> started.
>>>>>>>>>
>>>>>>>>> Whenever I try to open a file kino crashes.  It starts fine,
>>>>>>>>> but as
>>>>>>>>> soon
>>>>>>>>> as I try to open a .kino, .dv and other type files it crashes. 
>>>>>>>>> When
>>>>>>>>> I'm
>>>>>>>>> in the kino gui the crash occurs when I click on the folder
>>>>>>>>> that has
>>>>>>>>> the
>>>>>>>>> .kino file.  On the command line it crashes when I pass the
>>>>>>>>> file in as
>>>>>>>>> a
>>>>>>>>> parameter.
>>>>> More than likely the libdv or libavcodec libraries changed somehow and
>>>>> Kino needs to be rebuilt. If you are going to rebuild it, see if there
>>>>> is a v1.3.3, the latest release, available - it will clear up many of
>>>>> those GTK+ warnings.
>>>>>
>>>>>>>> post the command line and resulting output.
>>>>>>>>
>>>>> [...]
>>>>>>> /Video/Capture/MomAndDad50thAnniversary $ kino take1.kino
>>>>> [...]
>>>>>>> Kino experienced a segmentation fault.
>>>>> $ gdb kino
>>>>> (gdb) run take1.kino
>>>>> ...segfault
>>>>> (gdb) where
>>>>>
>>>>> send the output.
>>>>>
>>>> I think the problem is in the environment or setup somewhere.  I
>>>> don't have
>>>> the answer, but I think I'm getting closer.  So please bear with me
>>>> as I
>>>> explain.
>>>>
>>>> First)  This is kino version 1.3.1 I'm working with.  There isn't any
>>>> libavcodec package in the portage tree as far as I've seen, but
>>>> there is a
>>>> libavc1394 version 0.5.3. The highest version of lbdv is 1.0.0-r2.
>>> I do not know the gentoo package names; libavcodec is a part of FFmeg.
>>>
>>> $ ldd $(which kino)
>>> and see if it is linked to a libavcodec
>>>
>>>> Second)  I tried compiling the source so I could run the program
>>>> through the
>>>> gdb debugger.  When I ran the program without gdb it runs fine, but
>>>> the same
>>>> problem exists with the crashing.  However, when running the program
>>>> through
>>>> gdb it SIGSEGV because it can't find the magick.glade and kino.glade
>>>> file.
>>>>  The program was looking for them in /usr/local/share/kino/ and that
>>>> path
>>>> and the file don't exist.
>>> You have to install it to put resources in the expected location.
>>>
>>>> Third) Then I did a make clean and ran configure with my own
>>>> --prefix and
>>>> copied the two .glade file to that location.  I redid the steps above
>>>> running kino with and without gdb and to my surprise everything worked.
>>>>  Except for some missing icons , which is understandable since I
>>>> change the
>>>> --prefix, everything I tested was functional.  I could open files
>>>> and play
>>>> them.
>>> Like I said, Kino needed to be rebuilt for some reason or another. Or,
>>> something special about the gentoo build is triggering a bug.
>>>
>>>> So now is the problem with the way kino is getting installed on
>>>> Gentoo amd64
>>>> or am I picking up older files from previous versions that don't
>>>> work?  Any
>>>> ideas?  I think we're getting closer?
>>> Remove it entirely, re-emerge it. If the problem remains, file a bug
>>> with gentoo. If there is a patch that belongs upstream, someone should
>>> attach it to the Kino SourceForge tracker. Kino is no longer actively
>>> maintained, so someone needs to step up if they need it to work for
>>> them because no one else is going out of there way to resolve issues
>>> for various environments.
>>>
>>
> I've only been using Kino for a short time, but 1.3.3 has been perfectly
> find on my amd64 system. Consider unmasking it and installing that
> version, see if that gets around whatever the problem is.
> 
> 

I don't see a version 1.3.3 on my amd64, but I seem to have an ebuild 
for it.  I don't think I have it masked either.  All I see is 
media-video/kino gstreamer dvdr sox in the package.use file.

# emerge --search kino
!!! CONFIG_PROTECT is emptySearching...
[ Results for search key : kino ]
[ Applications found : 1 ]

*  media-video/kino
       Latest version available: 1.3.1
       Latest version installed: 1.3.1
       Size of files: 10,804 kB
       Homepage:      http://www.kinodv.org/
       Description:   Kino is a non-linear DV editor for GNU/Linux
       License:       GPL-2

Re: [gentoo-user] Kino Crashes Opening Files

[dhk]

dhk wrote:
> Saphirus Sage wrote:
>> dhk wrote:
>>> I originally posted this question to the kino group.  The chain of
>>> emails is below.
>>>
>>> The problem is that kino crashes when opening a file, clicking on a
>>> folder that has a video file in it, or when passing it in on the
>>> command line.  I removed and reinstalled kino, but the same thing
>>> happens.  I compiled the source manually and the problem wasn't
>>> there.  Now I think it has something to do with the Gentoo environment
>>> or the ebuild.
>>>
>>> One thing I noticed on my system is that in
>>> /usr/portage/media-video/kino there are two ebuilds a 1.3.1 and a
>>> 1.3.3 I have 1.3.1 installed. The diffs to these files are as follows.
>>>
>>> $ diff kino-1.3.1.ebuild kino-1.3.3.ebuild
>>> 1c1
>>> < # Copyright 1999-2008 Gentoo Foundation
>>> ---
>>>> # Copyright 1999-2009 Gentoo Foundation
>>> 3c3
>>> < # $Header:
>>> /var/cvsroot/gentoo-x86/media-video/kino/kino-1.3.1.ebuild,v 1.7
>>> 2008/12/21 14:44:31 nixnut Exp $
>>> ---
>>>> # $Header:
>>> /var/cvsroot/gentoo-x86/media-video/kino/kino-1.3.3.ebuild,v 1.1
>>> 2009/03/29 13:39:42 patrick Exp $
>>> 11c11
>>> < KEYWORDS="amd64 ppc ppc64 sparc x86"
>>> ---
>>>> KEYWORDS="~amd64 ~ppc ~ppc64 ~sparc ~x86"
>>> 29a30
>>>>     dev-util/intltool
>>> I'm not sure if the 1.3.3 file is causing a problem somehow.
>>>
>>> Any ideas?
>>>
>>> Thanks,
>>> dhk
>>>
>>> Dan Dennedy wrote:
>>>> On Wed, May 13, 2009 at 4:54 AM, dhk <dhkuhl@optonline.net> wrote:
>>>>> Dan Dennedy wrote:
>>>>>> On Tue, May 12, 2009 at 3:08 AM, dhk <dhkuhl@optonline.net> wrote:
>>>>>>> dhk wrote:
>>>>>>>> Carl Karsten wrote:
>>>>>>>>> On Sat, May 9, 2009 at 5:27 AM, dhk <dhkuhl@optonline.net> wrote:
>>>>>>>>>> I don't edit video very often so I don't know exactly when this
>>>>>>>>>> problem
>>>>>>>>>> started.
>>>>>>>>>>
>>>>>>>>>> Whenever I try to open a file kino crashes.  It starts fine,
>>>>>>>>>> but as
>>>>>>>>>> soon
>>>>>>>>>> as I try to open a .kino, .dv and other type files it crashes. 
>>>>>>>>>> When
>>>>>>>>>> I'm
>>>>>>>>>> in the kino gui the crash occurs when I click on the folder
>>>>>>>>>> that has
>>>>>>>>>> the
>>>>>>>>>> .kino file.  On the command line it crashes when I pass the
>>>>>>>>>> file in as
>>>>>>>>>> a
>>>>>>>>>> parameter.
>>>>>> More than likely the libdv or libavcodec libraries changed somehow 
>>>>>> and
>>>>>> Kino needs to be rebuilt. If you are going to rebuild it, see if 
>>>>>> there
>>>>>> is a v1.3.3, the latest release, available - it will clear up many of
>>>>>> those GTK+ warnings.
>>>>>>
>>>>>>>>> post the command line and resulting output.
>>>>>>>>>
>>>>>> [...]
>>>>>>>> /Video/Capture/MomAndDad50thAnniversary $ kino take1.kino
>>>>>> [...]
>>>>>>>> Kino experienced a segmentation fault.
>>>>>> $ gdb kino
>>>>>> (gdb) run take1.kino
>>>>>> ...segfault
>>>>>> (gdb) where
>>>>>>
>>>>>> send the output.
>>>>>>
>>>>> I think the problem is in the environment or setup somewhere.  I
>>>>> don't have
>>>>> the answer, but I think I'm getting closer.  So please bear with me
>>>>> as I
>>>>> explain.
>>>>>
>>>>> First)  This is kino version 1.3.1 I'm working with.  There isn't any
>>>>> libavcodec package in the portage tree as far as I've seen, but
>>>>> there is a
>>>>> libavc1394 version 0.5.3. The highest version of lbdv is 1.0.0-r2.
>>>> I do not know the gentoo package names; libavcodec is a part of FFmeg.
>>>>
>>>> $ ldd $(which kino)
>>>> and see if it is linked to a libavcodec
>>>>
>>>>> Second)  I tried compiling the source so I could run the program
>>>>> through the
>>>>> gdb debugger.  When I ran the program without gdb it runs fine, but
>>>>> the same
>>>>> problem exists with the crashing.  However, when running the program
>>>>> through
>>>>> gdb it SIGSEGV because it can't find the magick.glade and kino.glade
>>>>> file.
>>>>>  The program was looking for them in /usr/local/share/kino/ and that
>>>>> path
>>>>> and the file don't exist.
>>>> You have to install it to put resources in the expected location.
>>>>
>>>>> Third) Then I did a make clean and ran configure with my own
>>>>> --prefix and
>>>>> copied the two .glade file to that location.  I redid the steps above
>>>>> running kino with and without gdb and to my surprise everything 
>>>>> worked.
>>>>>  Except for some missing icons , which is understandable since I
>>>>> change the
>>>>> --prefix, everything I tested was functional.  I could open files
>>>>> and play
>>>>> them.
>>>> Like I said, Kino needed to be rebuilt for some reason or another. Or,
>>>> something special about the gentoo build is triggering a bug.
>>>>
>>>>> So now is the problem with the way kino is getting installed on
>>>>> Gentoo amd64
>>>>> or am I picking up older files from previous versions that don't
>>>>> work?  Any
>>>>> ideas?  I think we're getting closer?
>>>> Remove it entirely, re-emerge it. If the problem remains, file a bug
>>>> with gentoo. If there is a patch that belongs upstream, someone should
>>>> attach it to the Kino SourceForge tracker. Kino is no longer actively
>>>> maintained, so someone needs to step up if they need it to work for
>>>> them because no one else is going out of there way to resolve issues
>>>> for various environments.
>>>>
>>>
>> I've only been using Kino for a short time, but 1.3.3 has been perfectly
>> find on my amd64 system. Consider unmasking it and installing that
>> version, see if that gets around whatever the problem is.
>>
>>
> 
> I don't see a version 1.3.3 on my amd64, but I seem to have an ebuild 
> for it.  I don't think I have it masked either.  All I see is 
> media-video/kino gstreamer dvdr sox in the package.use file.
> 
> # emerge --search kino
> !!! CONFIG_PROTECT is emptySearching...
> [ Results for search key : kino ]
> [ Applications found : 1 ]
> 
> *  media-video/kino
>       Latest version available: 1.3.1
>       Latest version installed: 1.3.1
>       Size of files: 10,804 kB
>       Homepage:      http://www.kinodv.org/
>       Description:   Kino is a non-linear DV editor for GNU/Linux
>       License:       GPL-2
> 
> 
> 
Never mind I found it.  Version 1.3.3 was masked.  I had to add 
media-video/kino ~amd64 to the package.keywords file.  Now the problem 
is gone.  Thanks all.