[gentoo-user] udevil question for Helmut Jarausch

[gentoo-user] udevil question for Helmut Jarausch

[walt]

Hi Helmut.  sys-apps/udevil failed to compile this morning and I noticed you
had already submitted a proposed fix for it (your patch worked, thank you).

The failing code was already in the udevil package when I emerged it on Jan
21 with no problems, so some other package must have changed since Jan 21,
but which one(s)?

I ask the question because I want to learn to think like a developer (hold
all snarky comments until the professionals get here) so could you describe
how you arrived at your fix so quickly?

Have you used the "stat" function so often that you didn't even need to think
about how to fix it, or was it more complicated?

Thanks for any wisdom you care to share with us.

Re: [gentoo-user] udevil question for Helmut Jarausch

[Helmut Jarausch]

On 06/15/2015 11:56:41 PM, walt wrote:
> Hi Helmut.  sys-apps/udevil failed to compile this morning and I
> noticed you
> had already submitted a proposed fix for it (your patch worked, thank
> you).
> 
> The failing code was already in the udevil package when I emerged it
> on Jan
> 21 with no problems, so some other package must have changed since Jan
> 21,
> but which one(s)?
> 
> I ask the question because I want to learn to think like a developer
> (hold
> all snarky comments until the professionals get here) so could you
> describe
> how you arrived at your fix so quickly?
> 
> Have you used the "stat" function so often that you didn't even need
> to think
> about how to fix it, or was it more complicated?
> 
> Thanks for any wisdom you care to share with us.
> 

The build log says

 device-info.c:943:33: error: implicit declaration of function 'stat' [-Werror=implicit-function-declaration]
                                 stat( mount_source, &statbuf ) == 0 &&
                                 ^
device-info.c:944:33: error: implicit declaration of function 'S_ISBLK' [-Werror=implicit-function-declaration]
                                 S_ISBLK( statbuf.st_mode ) )

which means the function stat isn't declared. Together with S_ISBLK it is clear that the C-function stat (to determine
file status) is meant. 

man lstat    (man stat doesn't work here)
shows which header files have to be included.

Furthermore

grep -rF /usr/include  S_ISBLK
shows
/usr/include/sys/stat.h:#define S_ISBLK(mode)    ....

Therefore <sys/stat.h> has to be included somewhere
.
No wisdom at all,
Helmut

[gentoo-user] Re: udevil question for Helmut Jarausch

[walt]

On 06/16/2015 02:32 AM, Helmut Jarausch wrote:
> On 06/15/2015 11:56:41 PM, walt wrote:
>> Hi Helmut.  sys-apps/udevil failed to compile this morning and I
>> noticed you
>> had already submitted a proposed fix for it (your patch worked, thank
>> you).
>>
>> The failing code was already in the udevil package when I emerged it
>> on Jan
>> 21 with no problems, so some other package must have changed since Jan
>> 21,
>> but which one(s)?
>>
>> I ask the question because I want to learn to think like a developer
>> (hold
>> all snarky comments until the professionals get here) so could you
>> describe
>> how you arrived at your fix so quickly?
>>
>> Have you used the "stat" function so often that you didn't even need
>> to think
>> about how to fix it, or was it more complicated?
>>
>> Thanks for any wisdom you care to share with us.
>>
> 
> The build log says
> 
>  device-info.c:943:33: error: implicit declaration of function 'stat' [-Werror=implicit-function-declaration]
>                                  stat( mount_source, &statbuf ) == 0 &&
>                                  ^
> device-info.c:944:33: error: implicit declaration of function 'S_ISBLK' [-Werror=implicit-function-declaration]
>                                  S_ISBLK( statbuf.st_mode ) )
> 
> which means the function stat isn't declared. Together with S_ISBLK it is clear that the C-function stat (to determine
> file status) is meant. 
> 
> man lstat    (man stat doesn't work here)

Strange, it works here.  I wonder if the difference is caused by your l10n, or
maybe a bug.  Are man pages always in English?  I've been pondering the switch
to man-db but I'm not motivated to deal with any fallout and disk space is cheap.

> shows which header files have to be included.
> 
> Furthermore
> 
> grep -rF /usr/include  S_ISBLK
> shows
> /usr/include/sys/stat.h:#define S_ISBLK(mode)    ....
> 
> Therefore <sys/stat.h> has to be included somewhere

Thanks, good hints.

> No wisdom at all,

Hm.

Re: [gentoo-user] Re: udevil question for Helmut Jarausch

[Marc Joliet]

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

Am Wed, 17 Jun 2015 16:04:17 -0700
schrieb walt <w41ter@gmail.com>:

> Strange, it works here.  I wonder if the difference is caused by your l10n, or
> maybe a bug.  Are man pages always in English?  I've been pondering the switch
> to man-db but I'm not motivated to deal with any fallout and disk space is cheap.

Helmut might have meant that "man stat" show the wrong man page, namely that of
the stat(1) shell command.  "man 3 stat" works, but refers to the more complete
man page fstatat(3p), which is still a different man page than stat(2) (which
is what "man lstat" will give you).

Besides which, I switched to man-db a while ago, in February 2013, with zero
problems.  My main motivation was that sys-apps/man had some minor formatting
bugs that have been unresolved for years, and I also wanted to switch to
something that was maintained.  And no, man pages are not always in English
(although personally I tend to prefer the original English man pages to the
German translations).

-- 
Marc Joliet
--
"People who think they know everything really annoy those of us who know we
don't" - Bjarne Stroustrup

[-- Attachment #2: Digitale Signatur von OpenPGP --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [gentoo-user] Re: udevil question for Helmut Jarausch

[Helmut Jarausch]

On 06/18/2015 09:13:09 AM, Marc Joliet wrote:
> Besides which, I switched to man-db a while ago, in February 2013,
> with zero  problems. 

Does anybody know about a GUI for man-db (perhaps similar to tkman) ?

Thanks,
Helmut

Re: [gentoo-user] Re: udevil question for Helmut Jarausch

[Peter Humphrey]

On Thursday 18 Jun 2015 16:19:04 Helmut Jarausch wrote:
> On 06/18/2015 09:13:09 AM, Marc Joliet wrote:
> > Besides which, I switched to man-db a while ago, in February 2013,
> > with zero  problems.
> 
> Does anybody know about a GUI for man-db (perhaps similar to tkman) ?

Have you tried kde-apps/konqueror? You type man:<page> in the location bar and 
it formats it nicely for you.

-- 
Rgds
Peter

Re: [gentoo-user] Re: udevil question for Helmut Jarausch

[Helmut Jarausch]

On 06/18/2015 04:27:25 PM, Peter Humphrey wrote:
> On Thursday 18 Jun 2015 16:19:04 Helmut Jarausch wrote:
> > On 06/18/2015 09:13:09 AM, Marc Joliet wrote:
> > > Besides which, I switched to man-db a while ago, in February 2013,
> > > with zero  problems.
> >
> > Does anybody know about a GUI for man-db (perhaps similar to tkman)
> ?
> 
> Have you tried kde-apps/konqueror? You type man:<page> in the location
> bar and
> it formats it nicely for you.
> 

Sorry, I'm a dino. I don't like either KDE nor GNOME.
Helmut.

Re: [gentoo-user] Re: udevil question for Helmut Jarausch

[Peter Humphrey]

On Thursday 18 Jun 2015 17:16:54 Helmut Jarausch wrote:
> On 06/18/2015 04:27:25 PM, Peter Humphrey wrote:
> > On Thursday 18 Jun 2015 16:19:04 Helmut Jarausch wrote:
> > > Does anybody know about a GUI for man-db (perhaps similar to tkman)
> > ?
> > 
> > Have you tried kde-apps/konqueror? You type man:<page> in the location
> > bar and
> > it formats it nicely for you.
> 
> Sorry, I'm a dino. I don't like either KDE nor GNOME.

Oh well; it takes all sorts  :-)

-- 
Rgds
Peter

Re: [gentoo-user] Re: udevil question for Helmut Jarausch

[Neil Bothwick]

[-- Attachment #1: Type: text/plain, Size: 465 bytes --]

On Thu, 18 Jun 2015 17:16:54 +0200, Helmut Jarausch wrote:

> > > Does anybody know about a GUI for man-db (perhaps similar to
> > > tkman)  
> > ?
> > 
> > Have you tried kde-apps/konqueror? You type man:<page> in the location
> > bar and
> > it formats it nicely for you.
> >   
> 
> Sorry, I'm a dino. I don't like either KDE nor GNOME.

A true dino wouldn't ask for a GUI :)


-- 
Neil Bothwick

Always be sincere even if you don't mean it.

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]