From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lists.gentoo.org ([140.105.134.102] helo=robin.gentoo.org) by nuthatch.gentoo.org with esmtp (Exim 4.54) id 1FXGa6-0000PR-JP for garchives@archives.gentoo.org; Sat, 22 Apr 2006 11:47:19 +0000 Received: from robin.gentoo.org (localhost [127.0.0.1]) by robin.gentoo.org (8.13.6/8.13.6) with SMTP id k3MBkFpL026846; Sat, 22 Apr 2006 11:46:15 GMT Received: from smtp13.wxs.nl (smtp13.wxs.nl [195.121.247.4]) by robin.gentoo.org (8.13.6/8.13.6) with ESMTP id k3MBg2FJ005388 for ; Sat, 22 Apr 2006 11:42:02 GMT Received: from graskamp (ip51cfa1ef.direct-adsl.nl [81.207.161.239]) by smtp13.wxs.nl (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0IY400JHVGI2G7@smtp13.wxs.nl> for gentoo-user@lists.gentoo.org; Sat, 22 Apr 2006 13:42:02 +0200 (CEST) Date: Sat, 22 Apr 2006 13:41:44 +0200 From: Benno Schulenberg Subject: Re: [gentoo-user] netfilter: -P INPUT DROP in kernel In-reply-to: <44495173.6070307@web.de> To: gentoo-user@lists.gentoo.org Message-id: <200604221341.44827.benno.schulenberg@gmail.com> Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-user@gentoo.org Reply-to: gentoo-user@lists.gentoo.org MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 7BIT Content-disposition: inline User-Agent: KMail/1.9.1 References: <44495173.6070307@web.de> X-Archives-Salt: e3dbe752-471a-4f81-88c0-0ab9bf27ec5f X-Archives-Hash: bd5cda0d92e334ecc6f18d0d145e704e Daniel Waeber wrote: > Because I'm new to Linux, this is my first patch, so i don't know > if everything is done right. Perhaps someone can examine it > before I send it to kernel.org. Give your patch a descriptive name (when attaching it). Don't add unneeded blank lines. And there's a spello in policys, should be policies. Also, make the same changes to ip6table_filter.c. > I don't now if how/if this parameter can be passed, if netfilter > is build inside the kernel, so perhaps this is not the perfect > solution. Try it out for yourself. :) Before sending something to the kernel mailing list, you'd better have tested your patch in several ways. And read SubmittingPatches in the Documentation dir of the kernel source and some of the references mentioned at the end. Benno -- gentoo-user@gentoo.org mailing list