From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by finch.gentoo.org (Postfix) with ESMTPS id E42AA138359 for ; Mon, 6 Jul 2020 10:26:57 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id F2531E08D4; Mon, 6 Jul 2020 10:26:56 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id D0B38E08D4 for ; Mon, 6 Jul 2020 10:26:56 +0000 (UTC) Received: from [2001:470:4c22:ae86:babe:71:0:1b9] (port=52260 helo=robot) by muon with esmtp (Exim 4.92) (envelope-from ) id 1jsOKn-0005XV-AY for gentoo-soc@lists.gentoo.org; Mon, 06 Jul 2020 10:26:49 +0000 From: Benda Xu To: gentoo-soc@lists.gentoo.org Subject: Re: [gentoo-soc] Weekly Report: Big Data Infrastructure and Maven Overlay in Week 5 References: <87v9j1sb3b.fsf@robot.e.airelinux.org> Date: Mon, 06 Jul 2020 18:26:46 +0800 In-Reply-To: (Zhang Zongyu's message of "Mon, 6 Jul 2020 17:58:00 +0800") Message-ID: <87k0zhlz15.fsf@robot.e.airelinux.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-soc@lists.gentoo.org Reply-to: gentoo-soc@lists.gentoo.org X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply MIME-Version: 1.0 Content-Type: text/plain X-Archives-Salt: 0d89359a-2425-444f-81c4-48e45a94c595 X-Archives-Hash: a9ddbb76b6cfa87ab19dac3af6766cc4 Zhang Zongyu writes: >> do these work with java-pkg-simple.eclass as is in the tree or it needs >> your updated eclass? > > The class is modified by me. It can be found here[1]. The major > differences are the way to process JAVA_*_CLASSPATH variables and a > new variable called "JAVA_NEEDS_TOOLS". > >> getting the changes in the eclass into the main tree requires review and approval by devs. > > Is it correct that I should trigger the review via bugs.gentoo.org? Initiate the eclass patch review by starting a thread in gentoo-dev@l.g.o. `git format-patch` and `git send-email` are good tools for this purpose. >> also, before getting the ebuilds into the tree, i would really like to >> see an automated test to verify that the content of our jar files >> matches the content of the maven repo jar files. without this, we might >> get issues because of missing resources and maybe even other causes. > Currently, I do not have a clear way of reaching the goal... > A preliminary thought is to maintain a modified version of java-pkg-simple. > The modified eclass will automatically compare the files in postinst phase. > I will try to work out it this week. I think src_test() is better than pkg_postinst(). Benda