Re: [gentoo-soc] Weekly Report: Big Data Infrastructure and Maven Overlay in Week 5

[Benda Xu <heroxbd@gentoo.org>]

Zhang Zongyu <zzy2529420793@gmail.com> writes:

>> do these work with java-pkg-simple.eclass as is in the tree or it needs
>> your updated eclass?
>
> The class is modified by me. It can be found here[1]. The major
> differences are the way to process JAVA_*_CLASSPATH variables and a
> new variable called "JAVA_NEEDS_TOOLS".
>
>> getting the changes in the eclass into the main tree requires review and approval by devs.
>
> Is it correct that I should trigger the review via bugs.gentoo.org?

Initiate the eclass patch review by starting a thread in
gentoo-dev@l.g.o.   `git format-patch` and `git send-email` are good
tools for this purpose.

>> also, before getting the ebuilds into the tree, i would really like to
>> see an automated test to verify that the content of our jar files
>> matches the content of the maven repo jar files. without this, we might
>> get issues because of missing resources and maybe even other causes.

> Currently, I do not have a clear way of reaching the goal...
> A preliminary thought is to maintain a modified version of java-pkg-simple.
> The modified eclass will automatically compare the files in postinst phase.
> I will try to work out it this week.

I think src_test() is better than pkg_postinst().

Benda