[gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Mu Qiao]

[-- Attachment #1.1: Type: text/plain, Size: 266 bytes --]

I'm following the instructions given by Gentoo Soc. This mail is used to
make sure I can use SCM tools.

I've used git clone git://anongit.gentoo.org/packages.git, made some
changes, generated the patch and checked it. See the attachment.


-- 
Best wishes,
Mu Qiao

[-- Attachment #1.2: Type: text/html, Size: 366 bytes --]

[-- Attachment #2: mychanges.diff --]
[-- Type: text/plain, Size: 1264 bytes --]

Only in mypackages: Added
diff -cr mypackages/FRONTEND_FEATURES packages/FRONTEND_FEATURES
*** mypackages/FRONTEND_FEATURES	2010-03-30 18:35:51.000000000 +0800
--- packages/FRONTEND_FEATURES	2010-03-30 18:23:47.000000000 +0800
***************
*** 63,66 ****
  	Query arguments are marked with HTML/RSS to note which variants they
  	affect.
  
! I removed several lines and added this line
--- 63,82 ----
  	Query arguments are marked with HTML/RSS to note which variants they
  	affect.
  
! Global optional parameters:
!   ?count=x
!     x: integer between 1 and 25
!     Allowing to modify count of packages shown in center
! 	[HTML+RSS]
!   ?left_daycount=x
!     x: integer between 1 and 5
!     When above parameter is set and this parameter too,
!     daycount on the left can be lowered or raised
!     (default if unset: 2)
! 	[HTML]
!   ?arches=x
!     x: one of 'common' [default], 'exotic', 'all'
! 	See etc/const_data.py for which arches are exotic.
! 	All includes both common and exotic.
! 	[HTML]
! 
diff -cr mypackages/README packages/README
*** mypackages/README	2010-03-30 18:35:21.000000000 +0800
--- packages/README	2010-03-30 18:23:47.000000000 +0800
***************
*** 120,123 ****
  TESTING
  BITE
  X
- I added this line
--- 120,122 ----

Re: [gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Auke Booij]

It's usually a good idea to test if your patch actually applies...
Also, why didn't you use the tools built into git to generate the
patch?

On Tue, Mar 30, 2010 at 1:28 PM, Mu Qiao <qiaomuf@gmail.com> wrote:
> I'm following the instructions given by Gentoo Soc. This mail is used to
> make sure I can use SCM tools.
>
> I've used git clone git://anongit.gentoo.org/packages.git, made some
> changes, generated the patch and checked it. See the attachment.
>
>
> --
> Best wishes,
> Mu Qiao
>

Re: [gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Alex Legler]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

On Tue, 30 Mar 2010 19:28:46 +0800, Mu Qiao <qiaomuf@gmail.com> wrote:
> I've used git clone git://anongit.gentoo.org/packages.git, made some
> changes, generated the patch and checked it. See the attachment.

You should use unified diffs when working with Gentoo. They are much
easier to read and sort-of a standard around here.

-- 
Alex Legler | Gentoo Security / Ruby
a3li@gentoo.org | a3li@jabber.ccc.de

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

Re: [gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Mu Qiao]

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

Thanks. Seems I have some misunderstandings of the instruction. I will work
on it.

On Tue, Mar 30, 2010 at 7:49 PM, Alex Legler <a3li@gentoo.org> wrote:

> On Tue, 30 Mar 2010 19:28:46 +0800, Mu Qiao <qiaomuf@gmail.com> wrote:
> > I've used git clone git://anongit.gentoo.org/packages.git, made some
> > changes, generated the patch and checked it. See the attachment.
>
> You should use unified diffs when working with Gentoo. They are much
> easier to read and sort-of a standard around here.
>
> --
> Alex Legler | Gentoo Security / Ruby
> a3li@gentoo.org | a3li@jabber.ccc.de
>



-- 
Best wishes,
Mu Qiao

[-- Attachment #2: Type: text/html, Size: 1181 bytes --]

Re: [gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 580 bytes --]

On 03/30/2010 02:47 PM, Auke Booij wrote:
> It's usually a good idea to test if your patch actually applies...
> Also, why didn't you use the tools built into git to generate the
> patch?
> 

The social norm in Gentoo mailing lists is bottom posting. See
http://www.caliburn.nl/topposting.html

And indeed for everyone taking their first steps I recommend reading one
of the tutorials online about git. For example:

http://book.git-scm.com/

The answer how to send patches to a mailing list like this can also be
found in that online book.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]

Re: [gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Mu Qiao]

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

On Tue, Mar 30, 2010 at 8:14 PM, Petteri Räty <betelgeuse@gentoo.org> wrote:

> On 03/30/2010 02:47 PM, Auke Booij wrote:
> > It's usually a good idea to test if your patch actually applies...
> > Also, why didn't you use the tools built into git to generate the
> > patch?
> >
>
> The social norm in Gentoo mailing lists is bottom posting. See
> http://www.caliburn.nl/topposting.html
>
> And indeed for everyone taking their first steps I recommend reading one
> of the tutorials online about git. For example:
>
> http://book.git-scm.com/
>
> The answer how to send patches to a mailing list like this can also be
> found in that online book.
>
> Regards,
> Petteri
>
>
I didn't know about bottom posting. Sorry for bother you all and thanks for
telling me about it.


-- 
Best wishes,
Mu Qiao

[-- Attachment #2: Type: text/html, Size: 1355 bytes --]

Re: [gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 451 bytes --]

On 03/30/2010 03:20 PM, Mu Qiao wrote:
> 
> I didn't know about bottom posting. Sorry for bother you all and thanks
> for telling me about it.
> 

Maybe something lost in translation here but let's be clear that
students are not expected to know the Gentoo ways at this point so
mistakes do happen and we just try to guide you to the right direction.
To conclude you are not bothering us unless you continue to do it.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]

Re: [gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Mu Qiao]

[-- Attachment #1.1: Type: text/plain, Size: 357 bytes --]

I guess this time I've done the right thing.
I went through git tutorials Petteri linked above.
I used git clone, branch, checkout, format-patch, am and several other
commands to generate the patch and make sure the patch work.
The patch is attached.

If there is still anything I'm not doing in the right way, please let me
know.

-- 
Best wishes,
Mu Qiao

[-- Attachment #1.2: Type: text/html, Size: 411 bytes --]

[-- Attachment #2: 0001-GIT-Test.patch --]
[-- Type: application/octet-stream, Size: 849 bytes --]

From c9710839a078e497ef2133873eb78824538f8036 Mon Sep 17 00:00:00 2001
From: Mu Qiao <qiaomuf@gmail.com>
Date: Tue, 30 Mar 2010 22:06:44 +0800
Subject: [PATCH] GIT-Test

---
 FRONTEND_FEATURES |    2 +-
 README            |    5 +----
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/FRONTEND_FEATURES b/FRONTEND_FEATURES
index b9da37a..8d5203e 100644
--- a/FRONTEND_FEATURES
+++ b/FRONTEND_FEATURES
@@ -79,4 +79,4 @@ Global optional parameters:
 	See etc/const_data.py for which arches are exotic.
 	All includes both common and exotic.
 	[HTML]
-
+I added this line
diff --git a/README b/README
index 04c8896..f95b87e 100644
--- a/README
+++ b/README
@@ -116,7 +116,4 @@ pkggroup (eg: gpackages)
 (the PORTDIR in packages2 etc/make.conf!)
 
 6. chmod o-rwx,g+rX $APPROOT $PORTDIR
-
-TESTING
-BITE
-X
+I deleted 3 lines
-- 
1.6.3.3

Re: [gentoo-soc] Use the tools to make changes to code ( following the Gentoo Soc instructions)

[Petteri Räty]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On 03/30/2010 05:16 PM, Mu Qiao wrote:
> I guess this time I've done the right thing.
> I went through git tutorials Petteri linked above.
> I used git clone, branch, checkout, format-patch, am and several other
> commands to generate the patch and make sure the patch work.
> The patch is attached.
> 
> If there is still anything I'm not doing in the right way, please let me
> know.
> 

I tested applying it with git-am and seemed to work.

Regards,
Petteri


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 900 bytes --]