From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.gentoo.org (pigeon.gentoo.org [208.92.234.80]) by finch.gentoo.org (Postfix) with ESMTP id 8E2DC138247 for ; Tue, 21 Jan 2014 17:05:05 +0000 (UTC) Received: from pigeon.gentoo.org (localhost [127.0.0.1]) by pigeon.gentoo.org (Postfix) with SMTP id 1D5F9E0F8E; Tue, 21 Jan 2014 17:05:00 +0000 (UTC) Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by pigeon.gentoo.org (Postfix) with ESMTPS id 72095E0F7F for ; Tue, 21 Jan 2014 17:04:59 +0000 (UTC) Received: from mail-ie0-f176.google.com (mail-ie0-f176.google.com [209.85.223.176]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: bicatali) by smtp.gentoo.org (Postfix) with ESMTPSA id 6D37A33FA79 for ; Tue, 21 Jan 2014 17:04:58 +0000 (UTC) Received: by mail-ie0-f176.google.com with SMTP id tp5so3722119ieb.7 for ; Tue, 21 Jan 2014 09:04:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:reply-to:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=YQqg5/PdspyDCD48zkDraaUNBfiWonHio2b+x4EZQYU=; b=AH3p5ZTrWQxT2GrIlXwAlpYOpi0kWwiYmxi0fa/XZuOmsr/zyWg8XdayLkkkamRQRf qbuI4dTfRb11rX3aG4bDMDOxxkc7YjVxzeiHE7xQgYR68/ozu/PN1Oi/nPqxT9ozUY1p MEVfZ0tgMeYvgTjkDrca5h4x3HF6wxgLL+SRpDiEe37Kh/Y/HEJ6C9oxLGMqiPVYARqO ZWlU72VulJhi9iBuYDcGQPULiXxgEY3Vv5+JHM7auePKTPkR9s2OTAx9/eTyYSoFkwuQ B1liorBYy1NF8IUXmjXABgbJZMLVaRqjB0SEIa4VG4njfrYvtooXzF0lgIAe3OLZTDqh XWzw== Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Subscribe: List-Id: Gentoo Linux mail X-BeenThere: gentoo-science@lists.gentoo.org Reply-to: gentoo-science@lists.gentoo.org MIME-Version: 1.0 X-Received: by 10.43.171.194 with SMTP id nv2mr19533480icc.7.1390323896813; Tue, 21 Jan 2014 09:04:56 -0800 (PST) Received: by 10.64.89.41 with HTTP; Tue, 21 Jan 2014 09:04:56 -0800 (PST) In-Reply-To: <1390240392-12173-1-git-send-email-rei4dan@gmail.com> References: <1390240392-12173-1-git-send-email-rei4dan@gmail.com> Date: Tue, 21 Jan 2014 09:04:56 -0800 Message-ID: Subject: Re: [gentoo-science] [PATCH 00/10] alternatives-2.eclass updates From: =?UTF-8?Q?S=C3=A9bastien_Fabbro?= To: gentoo-science@lists.gentoo.org Content-Type: multipart/alternative; boundary=001a11c2f790fe109104f07e01b9 X-Archives-Salt: 54d65320-f18d-406c-af13-9d65555220e3 X-Archives-Hash: 7bc14896265eb9adb866fb1aaed0abcc --001a11c2f790fe109104f07e01b9 Content-Type: text/plain; charset=UTF-8 On Mon, Jan 20, 2014 at 9:53 AM, Reinis Danne wrote: > > I have cleaned up a bit alternatives-2.eclass to make it easier to review. > Also if someone knows any shortcommings of this eclass as it is, then point > it out, I'll try to address them. > > I hope this can be soon moved to the main tree thus closing the divide > between > science overlay and portage tree. > Your changes are mostly minor and only apply to the eclass, so I have no comments. You should commit them to the overlay, code reviews on the github review panel are more practical than on the mailing list. One important thing the creation of eselect modules could be done directly from eselect rather than the eclass, keeping the eclass much more simple, and allowing users to create their own providers easily. I may work on it. I had some local changes of eselect and I added the repo [1] to the github gentoo-science, that you can test by unmasking eselect-9999. Known issues of the alternatives framework: * when having more than 1 provider, updating a package that provided the eselected provider, will not re-eselect the same provider unless it was the first on the list * possible residual orphan files * given the number of bugs, we should keep the linking to the reference names libraries, so we could eselect providers without re-compiling all reverse dependencies. We could do this in the open sourced providers by changing the soname of the libraries we compile, and in the binary ones (mkl,amcl...) with a link script generated library. [1] https://github.com/gentoo-science/eselect Sebastien --001a11c2f790fe109104f07e01b9 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Mon, Jan 20, 2014 at 9:53 AM= , Reinis Danne <rei4dan@gmail.com> wrote:

I have cleaned up a bit alternatives-2.eclass to make it easier to review.<= br> Also if someone knows any shortcommings of this eclass as it is, then point=
it out, I'll try to address them.

I hope this can be soon moved to the main tree thus closing the divide betw= een
science overlay and portage tree.
=C2=A0
Your changes are mostly minor and only apply to the eclass, so = I have no comments. You should commit them to the overlay, code reviews on = the github review panel are more practical than on the mailing list.
One important thing the creation of eselect modules could be don= e directly from eselect rather than the eclass, keeping the eclass much mor= e simple, and allowing users to create their own providers easily. I may wo= rk on it.
I had some local changes of eselect and I added the repo [1] to the gi= thub gentoo-science, that you can test by unmasking eselect-9999.

Known issues of the alternatives framework:
* when having more than 1 provider, updating a =C2=A0package that provided = the eselected provider, will not re-eselect the same provider unless it was= the first on the list
* possible residual orphan files
* given the number of bugs,= we should keep the linking to the reference names libraries, so we could e= select providers without re-compiling all reverse dependencies. We could do= this in the open sourced providers by changing the soname of the libraries= we compile, and in the binary ones (mkl,amcl...) with a link script genera= ted library.


<= br>
Sebastien
=C2=A0
--001a11c2f790fe109104f07e01b9--